Re: [PATCH weston] compositor: when unmapping a surface remove it from the compositor's list

2013-09-22 Thread Kristian Høgsberg
On Sun, Sep 22, 2013 at 02:27:41PM +0200, Giulio Camuffo wrote: > Oh, i just noticed you pushed your commit that removes the > weston_compositor_build_surface_list() but you didn't push this one. :) Yeah, not good. Pushed now. Kristian > 2013/9/22 Giulio Camuffo : > > 2013/9/22 Kristian Høgsber

Re: [PATCH weston] compositor: when unmapping a surface remove it from the compositor's list

2013-09-22 Thread Giulio Camuffo
Oh, i just noticed you pushed your commit that removes the weston_compositor_build_surface_list() but you didn't push this one. :) 2013/9/22 Giulio Camuffo : > 2013/9/22 Kristian Høgsberg : >> On Sat, Sep 21, 2013 at 06:08:28PM +0200, Giulio Camuffo wrote: >>> compositor.surface_list is recreated

Re: [PATCH weston] compositor: when unmapping a surface remove it from the compositor's list

2013-09-22 Thread Giulio Camuffo
2013/9/22 Kristian Høgsberg : > On Sat, Sep 21, 2013 at 06:08:28PM +0200, Giulio Camuffo wrote: >> compositor.surface_list is recreated every redraw with the mapped >> surfaces, but if a surface gets unmapped and then in the same frame >> weston_compositor_pick_surface() is called we must make sure

Re: [PATCH weston] compositor: when unmapping a surface remove it from the compositor's list

2013-09-21 Thread Kristian Høgsberg
On Sat, Sep 21, 2013 at 06:08:28PM +0200, Giulio Camuffo wrote: > compositor.surface_list is recreated every redraw with the mapped > surfaces, but if a surface gets unmapped and then in the same frame > weston_compositor_pick_surface() is called we must make sure it > does not pick the unmapped su

[PATCH weston] compositor: when unmapping a surface remove it from the compositor's list

2013-09-21 Thread Giulio Camuffo
compositor.surface_list is recreated every redraw with the mapped surfaces, but if a surface gets unmapped and then in the same frame weston_compositor_pick_surface() is called we must make sure it does not pick the unmapped surface, since it traverses the surface_list to find one. If after the unm