Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-28 Thread Daniel Stone
Hi Dima, Apparently my reply here got lost in the ether ... On 24 November 2016 at 12:50, Dima Ryazanov wrote: > Forgot to mention: this only happens when using the wayland backend, not > x11. It's triggered by the next call to eglMakeCurrent (when the remaining > window is repainted), so it migh

Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-24 Thread Dima Ryazanov
Hi Daniel, Forgot to mention: this only happens when using the wayland backend, not x11. It's triggered by the next call to eglMakeCurrent (when the remaining window is repainted), so it might not happen immediately, either. I'm using an Intel graphics card and Mesa 12.0.3. I actually saw the com

Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-24 Thread Daniel Stone
Hi Dima, On 24 November 2016 at 02:41, Dima Ryazanov wrote: > Call eglMakeCurrent before destroying the native EGL window, similar to what > other sample clients are already doing. This doesn't show as an error here, with your suggested reproduction instructions. From eglDestroySurface: 'If the

Re: [PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-23 Thread Dima Ryazanov
To repro, run "valgrind weston --output-count=2", and close one of the windows. (When you close the last window, there are even more errors, so this particular one isn't as noticeable.) On Wed, Nov 23, 2016 at 6:41 PM, Dima Ryazanov wrote: > Call eglMakeCurrent before destroying the native EGL w

[PATCH weston] gl-renderer: Fix an invalid write when closing a Weston window

2016-11-23 Thread Dima Ryazanov
Call eglMakeCurrent before destroying the native EGL window, similar to what other sample clients are already doing. Signed-off-by: Dima Ryazanov --- libweston/gl-renderer.c | 4 1 file changed, 4 insertions(+) diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c index d08bfd0..c