To: Ucan, Emre (ADITG/SW1)
> > Cc: Nobuhiko Tanibata; securitych...@denso.co.jp; Natsume, Wataru
> > (ADITJ/SWG); wayland-devel@lists.freedesktop.org; Friedrich, Eugen
> > (ADITG/SW1)
> > Subject: Re: [PATCH weston] hmi-controller: remove duplicate
> > commit_changes in rand
WG); wayland-devel@lists.freedesktop.org; Friedrich, Eugen
> (ADITG/SW1)
> Subject: Re: [PATCH weston] hmi-controller: remove duplicate
> commit_changes in random mode
>
> On Fri, 5 Feb 2016 21:42:02 +
> "Ucan, Emre (ADITG/SW1)" wrote:
>
> > Hi Pekka,
> >
> > Firs
co.jp;
> Natsume, Wataru (ADITJ/SWG); wayland-devel@lists.freedesktop.org
> Subject: Re: [PATCH weston] hmi-controller: remove duplicate
> commit_changes in random mode
>
> On Thu, 4 Feb 2016 16:31:50 +
> "Ucan, Emre (ADITG/SW1)" wrote:
>
> > Hi Pekka,
>
To: Ucan, Emre (ADITG/SW1)
Cc: Nobuhiko Tanibata; securitych...@denso.co.jp; Natsume, Wataru (ADITJ/SWG);
wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH weston] hmi-controller: remove duplicate commit_changes in
random mode
On Thu, 4 Feb 2016 16:31:50 +
"Ucan, Emre (ADIT
...@lists.freedesktop.org] On Behalf Of
> Pekka Paalanen Sent: Dienstag, 2. Februar 2016 16:43 To: Nobuhiko
> Tanibata Cc: securitych...@denso.co.jp; Natsume, Wataru (ADITJ/SWG);
> wayland-devel@lists.freedesktop.org Subject: Re: [PATCH weston]
> hmi-controller: remove duplicate commit_changes
[mailto:wayland-devel-boun...@lists.freedesktop.org] On
Behalf Of Pekka Paalanen
Sent: Dienstag, 2. Februar 2016 16:43
To: Nobuhiko Tanibata
Cc: securitych...@denso.co.jp; Natsume, Wataru (ADITJ/SWG);
wayland-devel@lists.freedesktop.org
Subject: Re: [PATCH weston] hmi-controller: remove duplicate
Hi,
I don't think this patch is ready to be merged, more below.
TL;DR: It would probably be best to just ignore which ivilayer an
ivisurface is currently on, and always just remove and add. That would be
the simplest solution, if the ivilayout API just allows it.
Specifically, do not clear the l
From: Nobuhiko Tanibata
Previous code cleaned up surfaces in layer once and then added surfaces
to a layer in random. In this flow, two commitchanges are required.
This patch proposes that it avoids calling add_surface if a surface is
already added to a layer in random. In this flow, cleaning up
