Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-11-11 Thread Pekka Paalanen
On Sun, 12 Oct 2014 18:57:31 -0700 "Jasper St. Pierre" wrote: > Committing to an xdg_surface with a NULL buffer is currently illegal in > the mutter implementation, so this simply causes the client to error and > exit. The patch is good, but I'd like to reiterate on what this actually fixes. AF

Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-10-16 Thread Jasper St. Pierre
Wayland does not have child windows. On Oct 16, 2014 8:22 PM, "Bill Spitzak" wrote: > On 10/16/2014 08:03 PM, Jasper St. Pierre wrote: > > Are there any use cases for hiding a window while keeping it in the same >> place? We couldn't think of any on IRC. >> > > There may be a desire to do that w

Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-10-16 Thread Bill Spitzak
On 10/16/2014 08:03 PM, Jasper St. Pierre wrote: Are there any use cases for hiding a window while keeping it in the same place? We couldn't think of any on IRC. There may be a desire to do that with child windows. If a client has a button that turns a child window on/off, and the user moves

Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-10-16 Thread Jasper St. Pierre
On Tue, Oct 14, 2014 at 2:45 AM, Giulio Camuffo wrote: > 2014-10-13 4:57 GMT+03:00 Jasper St. Pierre : > > Committing to an xdg_surface with a NULL buffer is currently illegal in > > the mutter implementation, so this simply causes the client to error and > > exit. > > The patch looks good to me.

Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-10-14 Thread Giulio Camuffo
2014-10-13 4:57 GMT+03:00 Jasper St. Pierre : > Committing to an xdg_surface with a NULL buffer is currently illegal in > the mutter implementation, so this simply causes the client to error and > exit. The patch looks good to me. However, this leaves me wondering how does a client hide a surface.

Re: [PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-10-13 Thread Bryce Harrington
On Sun, Oct 12, 2014 at 06:57:31PM -0700, Jasper St. Pierre wrote: > Committing to an xdg_surface with a NULL buffer is currently illegal in > the mutter implementation, so this simply causes the client to error and > exit. > > It seems the reason the client did this was so it could add its own >

[PATCH weston] smoke: Don't commit an xdg_surface with a NULL buffer

2014-10-12 Thread Jasper St. Pierre
Committing to an xdg_surface with a NULL buffer is currently illegal in the mutter implementation, so this simply causes the client to error and exit. It seems the reason the client did this was so it could add its own frame callback, but toytoolkit actually provides accurate everything we need. J