Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-03-02 Thread Pekka Paalanen
On Wed, 1 Mar 2017 11:17:14 + Daniel Stone wrote: > Hi, > > On 1 March 2017 at 10:29, Pekka Paalanen wrote: > > On Tue, 28 Feb 2017 14:46:21 + Daniel Stone > > wrote: > >> On 28 February 2017 at 10:59, Pekka Paalanen wrote: > >> > The important thing to document about this change

Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-03-01 Thread Daniel Stone
Hi, On 1 March 2017 at 10:29, Pekka Paalanen wrote: > On Tue, 28 Feb 2017 14:46:21 + Daniel Stone wrote: >> On 28 February 2017 at 10:59, Pekka Paalanen wrote: >> > The important thing to document about this change is that is exchanges >> > a (almost never hit) double-unref into a (always h

Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-03-01 Thread Pekka Paalanen
On Tue, 28 Feb 2017 14:46:21 + Daniel Stone wrote: > Hi, > > On 28 February 2017 at 10:59, Pekka Paalanen wrote: > > On Mon, 27 Feb 2017 22:58:48 + Daniel Stone > > wrote: > >> It's indeed almost certainly a bugfix: if you have one client buffer > >> with multiple views, both of whi

Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-02-28 Thread Daniel Stone
Hi, On 28 February 2017 at 10:59, Pekka Paalanen wrote: > On Mon, 27 Feb 2017 22:58:48 + Daniel Stone wrote: >> It's indeed almost certainly a bugfix: if you have one client buffer >> with multiple views, both of which could be promoted to scanout, >> you'll get the same user data (drm_fb) h

Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-02-28 Thread Pekka Paalanen
On Mon, 27 Feb 2017 22:58:48 + Daniel Stone wrote: > Hi Pekka, > > On 21 February 2017 at 15:19, Pekka Paalanen wrote: > > On Fri, 9 Dec 2016 19:57:34 + Daniel Stone > > wrote: > >> @@ -312,6 +316,7 @@ drm_fb_create_dumb(struct drm_backend *b, int width, > >> int height, > >>

Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-02-27 Thread Daniel Stone
Hi Pekka, On 21 February 2017 at 15:19, Pekka Paalanen wrote: > On Fri, 9 Dec 2016 19:57:34 + Daniel Stone wrote: >> @@ -312,6 +316,7 @@ drm_fb_create_dumb(struct drm_backend *b, int width, int >> height, >> if (!fb->format->depth || !fb->format->bpp) { >> weston_log("f

Re: [PATCH weston 19/68] compositor-drm: Refcount drm_fb

2017-02-21 Thread Pekka Paalanen
On Fri, 9 Dec 2016 19:57:34 + Daniel Stone wrote: > Sometimes we need to duplicate an existing drm_fb, e.g. when > pageflipping to the same buffer to kickstart the repaint loop. To handle > situations like these, and simplify resource management for dumb and > cursor buffers, refcount drm_fb

[PATCH weston 19/68] compositor-drm: Refcount drm_fb

2016-12-09 Thread Daniel Stone
Sometimes we need to duplicate an existing drm_fb, e.g. when pageflipping to the same buffer to kickstart the repaint loop. To handle situations like these, and simplify resource management for dumb and cursor buffers, refcount drm_fb. Differential Revision: https://phabricator.freedesktop.org/D14