Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

2017-01-17 Thread Quentin Glidic
On 17/01/2017 12:54, Daniel Stone wrote: Hi, On 21 November 2016 at 11:07, Jan Engelhardt wrote: On Monday 2016-11-21 12:00, Daniel Stone wrote: COMPOSITOR_LIBS is full of -Lfoo -lsyslib. To the best of my knowledge, these belong in LDADD Negative. _LDADD is ignored for library type outputs

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

2017-01-17 Thread Daniel Stone
Hi, On 21 November 2016 at 11:07, Jan Engelhardt wrote: > On Monday 2016-11-21 12:00, Daniel Stone wrote: >>COMPOSITOR_LIBS is full of -Lfoo -lsyslib. To the best of my >>knowledge, these belong in LDADD > > Negative. _LDADD is ignored for library type outputs, and _LIBADD > is ignored for progra

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

2016-11-21 Thread Jan Engelhardt
On Monday 2016-11-21 12:00, Daniel Stone wrote: >On 18 August 2016 at 10:15, Quentin Glidic > wrote: >> @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES = >>\ >> lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la >> libweston_desktop_@LIBWESTON_MAJOR@_la_CPP

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

2016-11-21 Thread Daniel Stone
Hi Quentin, On 18 August 2016 at 10:15, Quentin Glidic wrote: > @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES = > \ > lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la > libweston_desktop_@LIBWESTON_MAJOR@_la_CPPFLAGS = $(AM_CPPFLAGS) -DIN_WESTON > libw

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

2016-08-18 Thread Pekka Paalanen
On Thu, 18 Aug 2016 11:15:45 +0200 Quentin Glidic wrote: > From: Quentin Glidic > > Modules are using libweston symbols (at least weston_log) and should > explicitly link to it. > > This patch also reorders some flags. > > Signed-off-by: Quentin Glidic > --- > > It doesn’t allow to build wi

[PATCH weston 2/2] Makefile.am: Link modules to libweston.la

2016-08-18 Thread Quentin Glidic
From: Quentin Glidic Modules are using libweston symbols (at least weston_log) and should explicitly link to it. This patch also reorders some flags. Signed-off-by: Quentin Glidic --- It doesn’t allow to build with --no-undefined, but it gets closer to that. Makefile.am | 105 ++