Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-09-17 Thread Jamey Sharp
It took me longer than I hoped to get back to this, but I have now tested Quentin Glidic's two patches (the revert followed by the revised fix) plus my "Restore keyboard focus after VT switch", applied to Weston 4. With all three patches applied, Weston passes my tests. Hooray! And just to be sure

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-24 Thread Derek Foreman
On 2018-08-24 12:23 PM, Jamey Sharp wrote: > For what it's worth, I'm happy to use backported patches. I just hope > this gets addressed upstream eventually. > > It's a little more than just cosmetic if you have a graphical > application that can be driven purely by keyboard, and sometimes you > d

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-24 Thread Jamey Sharp
For what it's worth, I'm happy to use backported patches. I just hope this gets addressed upstream eventually. It's a little more than just cosmetic if you have a graphical application that can be driven purely by keyboard, and sometimes you don't have a working pointer input device so you can't g

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-24 Thread Derek Foreman
On 2018-08-16 02:33 AM, Quentin Glidic wrote: > On 8/16/18 5:24 AM, Peter Hutterer wrote: >> On Fri, Aug 10, 2018 at 12:55:42PM -0500, Derek Foreman wrote: >>> On 2018-08-02 03:32 AM, Quentin Glidic wrote: On 8/2/18 10:29 AM, Quentin Glidic wrote: > From: Quentin Glidic > > If we

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-16 Thread Quentin Glidic
On 8/16/18 5:24 AM, Peter Hutterer wrote: On Fri, Aug 10, 2018 at 12:55:42PM -0500, Derek Foreman wrote: On 2018-08-02 03:32 AM, Quentin Glidic wrote: On 8/2/18 10:29 AM, Quentin Glidic wrote: From: Quentin Glidic If we start a special (grabbing) client when Weston is unfocused, it would los

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-15 Thread Peter Hutterer
On Fri, Aug 10, 2018 at 12:55:42PM -0500, Derek Foreman wrote: > On 2018-08-02 03:32 AM, Quentin Glidic wrote: > > On 8/2/18 10:29 AM, Quentin Glidic wrote: > >> From: Quentin Glidic > >> > >> If we start a special (grabbing) client when Weston is unfocused, it > >> would lose focus when coming ba

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-10 Thread Derek Foreman
On 2018-08-02 03:32 AM, Quentin Glidic wrote: > On 8/2/18 10:29 AM, Quentin Glidic wrote: >> From: Quentin Glidic >> >> If we start a special (grabbing) client when Weston is unfocused, it >> would lose focus when coming back to Weston. >> >> A first attempt to fix this was 85d55540cb64bf97a08b40f

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-02 Thread Peter Hutterer
On Thu, Aug 02, 2018 at 10:29:53AM +0200, Quentin Glidic wrote: > From: Quentin Glidic > > If we start a special (grabbing) client when Weston is unfocused, it > would lose focus when coming back to Weston. > > A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b > but it mes

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-02 Thread Quentin Glidic
On 8/2/18 10:29 AM, Quentin Glidic wrote: From: Quentin Glidic If we start a special (grabbing) client when Weston is unfocused, it would lose focus when coming back to Weston. A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b but it messed with VT switching. This fix j

[PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-02 Thread Quentin Glidic
From: Quentin Glidic If we start a special (grabbing) client when Weston is unfocused, it would lose focus when coming back to Weston. A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b but it messed with VT switching. This fix just updates the saved focus, so when Weston