Re: Testing static functions in testsuite (was Re: [PATCH weston 2/3] drm: port the drm backend to the new init api)

2015-08-27 Thread Bryce Harrington
On Thu, Aug 27, 2015 at 10:17:30AM +0300, Pekka Paalanen wrote: > On Wed, 26 Aug 2015 14:26:09 -0700 > Bryce Harrington wrote: > > > On Wed, Aug 26, 2015 at 04:35:59PM +0300, Pekka Paalanen wrote: > > > On Tue, 25 Aug 2015 14:24:23 -0700 > > > Bryce Harrington wrote: > > > > > 2. Another appro

Re: Testing static functions in testsuite (was Re: [PATCH weston 2/3] drm: port the drm backend to the new init api)

2015-08-27 Thread Pekka Paalanen
On Wed, 26 Aug 2015 14:26:09 -0700 Bryce Harrington wrote: > On Wed, Aug 26, 2015 at 04:35:59PM +0300, Pekka Paalanen wrote: > > On Tue, 25 Aug 2015 14:24:23 -0700 > > Bryce Harrington wrote: > > > 2. Another approach is to #define unit_static (or debug_export, or > > > similar) to be stat

Testing static functions in testsuite (was Re: [PATCH weston 2/3] drm: port the drm backend to the new init api)

2015-08-26 Thread Bryce Harrington
On Wed, Aug 26, 2015 at 04:35:59PM +0300, Pekka Paalanen wrote: > On Tue, 25 Aug 2015 14:24:23 -0700 > Bryce Harrington wrote: > > On Tue, Aug 25, 2015 at 09:03:36AM -0700, Jon A. Cruz wrote: > > > On 08/25/2015 03:08 AM, Pekka Paalanen wrote: > > > > How would you suggest we arrange the source co

Re: [PATCH weston 2/3] drm: port the drm backend to the new init api

2015-08-26 Thread Pekka Paalanen
Hi On Tue, 25 Aug 2015 14:24:23 -0700 Bryce Harrington wrote: > On Tue, Aug 25, 2015 at 09:03:36AM -0700, Jon A. Cruz wrote: > > On 08/25/2015 03:08 AM, Pekka Paalanen wrote: > > > How would you suggest we arrange the source code such that we can pick > > > arbitrary functions for unit tests wi

Re: [PATCH weston 2/3] drm: port the drm backend to the new init api

2015-08-25 Thread Bryce Harrington
On Tue, Aug 25, 2015 at 09:03:36AM -0700, Jon A. Cruz wrote: > On 08/25/2015 03:08 AM, Pekka Paalanen wrote: > > On Mon, 24 Aug 2015 19:26:48 -0700 > > Bryce Harrington wrote: > > > >> On Thu, Aug 13, 2015 at 01:53:05PM +0300, Pekka Paalanen wrote: > >>> From: Giulio Camuffo > >> > >> This is a

Re: [PATCH weston 2/3] drm: port the drm backend to the new init api

2015-08-25 Thread Jon A. Cruz
On 08/25/2015 03:08 AM, Pekka Paalanen wrote: > On Mon, 24 Aug 2015 19:26:48 -0700 > Bryce Harrington wrote: > >> On Thu, Aug 13, 2015 at 01:53:05PM +0300, Pekka Paalanen wrote: >>> From: Giulio Camuffo >> >> This is a big patch with a lot of changes, and I'm worried about landing >> it right as

Re: [PATCH weston 2/3] drm: port the drm backend to the new init api

2015-08-25 Thread Pekka Paalanen
On Mon, 24 Aug 2015 19:26:48 -0700 Bryce Harrington wrote: > On Thu, Aug 13, 2015 at 01:53:05PM +0300, Pekka Paalanen wrote: > > From: Giulio Camuffo > > This is a big patch with a lot of changes, and I'm worried about landing > it right as we're on the eve of beta. If it could be broken up in

Re: [PATCH weston 2/3] drm: port the drm backend to the new init api

2015-08-24 Thread Bryce Harrington
On Thu, Aug 13, 2015 at 01:53:05PM +0300, Pekka Paalanen wrote: > From: Giulio Camuffo This is a big patch with a lot of changes, and I'm worried about landing it right as we're on the eve of beta. If it could be broken up into smaller easy-to-review bits, it might make it more digestible... Th

[PATCH weston 2/3] drm: port the drm backend to the new init api

2015-08-13 Thread Pekka Paalanen
From: Giulio Camuffo --- Makefile.am | 3 + src/compositor-drm.c | 234 --- src/compositor-drm.h | 89 src/main.c | 127 +++- 4 files changed, 292 insertions(+), 161 deletions(-) c