Re: [PATCH weston 2/3] simple-touch: Handle multiple seats properly

2014-05-08 Thread Ander Conselvan de Oliveira
On 05/07/2014 05:27 PM, Neil Roberts wrote: Oh no, I didn't notice this patch buried in the patch series and implemented the same thing: http://lists.freedesktop.org/archives/wayland-devel/2014-May/014690.html Ander, it would be really helpful if you could leave a little note on the bug report

[PATCH weston 2/3] simple-touch: Handle multiple seats properly

2014-05-07 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com If simple-touch ran on a compositor with multiple seats, and the first one happened to have the touch capability while the second one didn't, the handler for seat capabilities would destroy the wl_touch device it created on

Re: [PATCH weston 2/3] simple-touch: Handle multiple seats properly

2014-05-07 Thread Jasper St. Pierre
I was wondering why you didn't move the pointer / keyboard fields to the seat, before noticing that they were unused. It might make sense to have a prereq patch that removes those unused fields. This patch looks good, though. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira

Re: [PATCH weston 2/3] simple-touch: Handle multiple seats properly

2014-05-07 Thread Neil Roberts
Oh no, I didn't notice this patch buried in the patch series and implemented the same thing: http://lists.freedesktop.org/archives/wayland-devel/2014-May/014690.html Ander, it would be really helpful if you could leave a little note on the bug report if you post a patch to reduce that chance