Re: [PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

2014-05-09 Thread Kristian Høgsberg
On Wed, May 07, 2014 at 11:57:28AM +0300, Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com The check to avoid calling weston_keyboard_set_focus() for a seat that didn't have a keyboard in restore_focus_state() was cheking the wrong

[PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

2014-05-07 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com The check to avoid calling weston_keyboard_set_focus() for a seat that didn't have a keyboard in restore_focus_state() was cheking the wrong seat (the one from the previous loop). That caused a crash when switching workspaces

Re: [PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

2014-05-07 Thread Jasper St. Pierre
Yep, looks good. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira conselv...@gmail.com wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com The check to avoid calling weston_keyboard_set_focus() for a seat that didn't have a keyboard in