Re: [PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-12 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 9:02 AM, Tiago Vignatti wrote: > On 07/12/2012 05:39 AM, Kristian Høgsberg wrote: >> >> On Thu, Jul 12, 2012 at 12:46:12AM +0300, Tiago Vignatti wrote: >>> >>> +static void >>> +weston_wm_handle_leave(struct weston_wm *wm, xcb_generic_event_t *event) >>> +{ >>> + xcb_

Re: [PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-12 Thread Tiago Vignatti
On 07/12/2012 05:39 AM, Kristian Høgsberg wrote: On Thu, Jul 12, 2012 at 12:46:12AM +0300, Tiago Vignatti wrote: +static void +weston_wm_handle_leave(struct weston_wm *wm, xcb_generic_event_t *event) +{ + xcb_leave_notify_event_t *leave_notify = + (xcb_leave_n

Re: [PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-12 Thread Tiago Vignatti
On 07/12/2012 06:01 AM, Scott Moreau wrote: We don't need to set the cursor on leave, whatever window the cursor moves into will set it. But we do need to set it on enter. What if the surface the cursor moves to is the background image? Could the desktop surface set the cursor to a de

Re: [PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-11 Thread Scott Moreau
> We don't need to set the cursor on leave, whatever window the cursor > moves into will set it. But we do need to set it on enter. > > What if the surface the cursor moves to is the background image? Could the desktop surface set the cursor to a default pointer? Scott __

Re: [PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-11 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 12:46:12AM +0300, Tiago Vignatti wrote: > based on xcb-cursor. Looks good, but there's a couple of comments below. Kristian > Signed-off-by: Tiago Vignatti > --- > src/xwayland/window-manager.c | 132 > + > src/xwayland/xwayland

[PATCH weston 3/6] xwm: set appropriate cursors for the frame window

2012-07-11 Thread Tiago Vignatti
based on xcb-cursor. Signed-off-by: Tiago Vignatti --- src/xwayland/window-manager.c | 132 + src/xwayland/xwayland.h |2 + 2 files changed, 134 insertions(+) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c index 6e03