Re: [PATCH weston 4/7] input: fix use-after-free issue at pointer_cancel

2018-03-28 Thread Pekka Paalanen
On Tue, 20 Mar 2018 15:28:24 +0100 Emre Ucan wrote: > If the constraint is an one-shot constraint, constraint > is freed in disable_pointer_constraint function. > Therefore, we should not try to read freed memory at > "switch (constraint->lifetime)" statement. > > The removed code is anyway supe

[PATCH weston 4/7] input: fix use-after-free issue at pointer_cancel

2018-03-20 Thread Emre Ucan
If the constraint is an one-shot constraint, constraint is freed in disable_pointer_constraint function. Therefore, we should not try to read freed memory at "switch (constraint->lifetime)" statement. The removed code is anyway superfluous. Because surface destroy signal is only removed, when cons