Re: [PATCH weston v2 02/21] input: Make pointer grab motion callbacks take an event struct

On Tue, Oct 27, 2015 at 05:40:33PM +, Daniel Stone wrote: > Hi Jonas, > > On 13 May 2015 at 11:26, Jonas Ådahl wrote: > > @@ -3182,18 +3182,20 @@ popup_grab_focus(struct weston_pointer_grab *grab) > > > > static void > > popup_grab_motion(struct weston_pointer_grab *grab,

Re: [PATCH weston v2 02/21] input: Make pointer grab motion callbacks take an event struct

Agreed. Absolute input needs to be handled separately. The usage pattern on an absolute input device is that the cursor warps to the new position, it didn't simply move from the old to the new. As an example, pointer barriers shouldn't take effect on absolute input. On Tue, Oct 27, 2015, 10:40

Re: [PATCH weston v2 02/21] input: Make pointer grab motion callbacks take an event struct

Hi Jonas, On 13 May 2015 at 11:26, Jonas Ådahl wrote: > @@ -3182,18 +3182,20 @@ popup_grab_focus(struct weston_pointer_grab *grab) > > static void > popup_grab_motion(struct weston_pointer_grab *grab, uint32_t time, > - wl_fixed_t x, wl_fixed_t y) > +

[PATCH weston v2 02/21] input: Make pointer grab motion callbacks take an event struct

Instead of only passing absolute pointer coordinates, effectively loosing motion event data, pass a struct that can potentially contain different types of motion events, currently being absolute and relative. A helper function to get resulting absolute coordinates was added for when previous