Re: [PATCH weston v2 07/12] gl-renderer: Always setup gl-renderer

2016-06-30 Thread Pekka Paalanen
On Thu, 30 Jun 2016 06:26:11 +0200 Armin Krezović wrote: > On 27.06.2016 15:08, Pekka Paalanen wrote: > >> diff --git a/src/gl-renderer.c b/src/gl-renderer.c > >> index 23c0cd7..28c0b50 100644 > >> --- a/src/gl-renderer.c > >> +++ b/src/gl-renderer.c > >> @@ -2873,6

Re: [PATCH weston v2 07/12] gl-renderer: Always setup gl-renderer

2016-06-29 Thread Armin Krezović
On 27.06.2016 15:08, Pekka Paalanen wrote: >> diff --git a/src/gl-renderer.c b/src/gl-renderer.c >> index 23c0cd7..28c0b50 100644 >> --- a/src/gl-renderer.c >> +++ b/src/gl-renderer.c >> @@ -2873,6 +2878,43 @@ platform_to_extension(EGLenum platform) >> } >> >> static int >>

Re: [PATCH weston v2 07/12] gl-renderer: Always setup gl-renderer

2016-06-28 Thread Pekka Paalanen
On Tue, 28 Jun 2016 16:02:10 +0200 Armin Krezović wrote: > On 27.06.2016 15:08, Pekka Paalanen wrote: > > Hi Armin, > > > > several minor nitpicks on wording here, but the code looks good. > > > > On Thu, 23 Jun 2016 11:59:35 +0200 > > Armin Krezović

Re: [PATCH weston v2 07/12] gl-renderer: Always setup gl-renderer

2016-06-28 Thread Armin Krezović
On 27.06.2016 15:08, Pekka Paalanen wrote: > Hi Armin, > > several minor nitpicks on wording here, but the code looks good. > > On Thu, 23 Jun 2016 11:59:35 +0200 > Armin Krezović wrote: > >> Currently, the gl-renderer setup is being done on per-output >> basis. This

Re: [PATCH weston v2 07/12] gl-renderer: Always setup gl-renderer

2016-06-27 Thread Pekka Paalanen
Hi Armin, several minor nitpicks on wording here, but the code looks good. On Thu, 23 Jun 2016 11:59:35 +0200 Armin Krezović wrote: > Currently, the gl-renderer setup is being done on per-output > basis. This isn't desirable when trying to make weston run > with zero

[PATCH weston v2 07/12] gl-renderer: Always setup gl-renderer

2016-06-23 Thread Armin Krezović
Currently, the gl-renderer setup is being done on per-output basis. This isn't desirable when trying to make weston run with zero outputs. When there are no outputs present, there is no surface available to attach an EGLContext to with eglMakeCurrent, which makes any EGL command fail. The