Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-03 Thread Pekka Paalanen
On Tue, 03 Dec 2013 08:59:16 +0100 Lubomir Rintel wrote: > On Mon, 2013-12-02 at 15:53 -0800, Kristian Høgsberg wrote: > > On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: > > > While the pixman image might be attached, the underlying buffer > > > might be already gone under certai

Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-03 Thread Kristian Høgsberg
> On Dec 2, 2013, at 11:59 PM, Lubomir Rintel wrote: > >> On Mon, 2013-12-02 at 15:53 -0800, Kristian Høgsberg wrote: >>> On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: >>> While the pixman image might be attached, the underlying buffer might be >>> already gone under certain c

Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-03 Thread Lubomir Rintel
On Mon, 2013-12-02 at 15:53 -0800, Kristian Høgsberg wrote: > On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: > > While the pixman image might be attached, the underlying buffer might be > > already gone under certain circumstances. This is easily reproduced by > > attempting to res

Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-02 Thread Kristian Høgsberg
On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace

Re: [RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-12-02 Thread Bryce W. Harrington
On Sat, Nov 30, 2013 at 03:41:00PM +0100, Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace

[RESEND PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-30 Thread Lubomir Rintel
While the pixman image might be attached, the underlying buffer might be already gone under certain circumstances. This is easily reproduced by attempting to resize gnome-terminal on a fbdev backend. $ WAYLAND_DEBUG=1 strace -emunmap weston --backend=fbdev-backend.so ... [1524826.942] wl_shm@7.cre

Re: [PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-25 Thread Lubomir Rintel
Hi Arnaud, On Fri, 2013-11-22 at 15:48 +0100, Arnaud Vrac wrote: > Wouldn't it be better to do this in compositor.c and call > renderer->attach(surface, NULL) when the buffer attached to a surface > is destroyed ? I don't think that's possible. A buffer does not keep track of the surface it's att

Re: [PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-22 Thread Arnaud Vrac
Wouldn't it be better to do this in compositor.c and call renderer->attach(surface, NULL) when the buffer attached to a surface is destroyed ? Is there a case where a renderer wouldn't want this to be done ? On Thu, Nov 21, 2013 at 8:35 AM, Pekka Paalanen wrote: > On Tue, 19 Nov 2013 15:44:44 +

Re: [PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-20 Thread Pekka Paalanen
On Tue, 19 Nov 2013 15:44:44 +0100 Lubomir Rintel wrote: > While the pixman image might be attached, the underlying buffer might be > already gone under certain circumstances. This is easily reproduced by > attempting to resize gnome-terminal on a fbdev backend. > > $ WAYLAND_DEBUG=1 strace -emu

[PATCH weston v3] pixman: Destroy pixman images when underlying buffer is destroyed

2013-11-19 Thread Lubomir Rintel
While the pixman image might be attached, the underlying buffer might be already gone under certain circumstances. This is easily reproduced by attempting to resize gnome-terminal on a fbdev backend. $ WAYLAND_DEBUG=1 strace -emunmap weston --backend=fbdev-backend.so ... [1524826.942] wl_shm@7.cre