Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-28 Thread Pekka Paalanen
On Mon, 27 Aug 2018 16:20:41 +0100 Daniel Stone wrote: > Hi Pekka, > > On Fri, 24 Aug 2018 at 09:12, Pekka Paalanen wrote: > > On another matter, I've been wondering if storing the debug scopes in > > weston_compositor is a good thing. We have the logger initialized > > earlier, and quite a lot

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-28 Thread Pekka Paalanen
On Mon, 27 Aug 2018 16:15:23 +0100 Daniel Stone wrote: > Hi Pekka, > > On Mon, 6 Aug 2018 at 14:05, Pekka Paalanen wrote: > > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone > > wrote: > > > + while (len_ > 0) { > > > + ret = write(stream->fd, data, len_); > > > +

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-27 Thread Daniel Stone
Hi Pekka, On Fri, 24 Aug 2018 at 09:12, Pekka Paalanen wrote: > On Thu, 23 Aug 2018 17:53:07 +0100 Daniel Stone wrote: > > The users introduced in this patchset already check if the scope is > > enabled, which bails out if the scope is NULL. Given that, and that I > > can't see a sensible behavi

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-27 Thread Daniel Stone
Hi Pekka, On Mon, 6 Aug 2018 at 14:05, Pekka Paalanen wrote: > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > > + while (len_ > 0) { > > + ret = write(stream->fd, data, len_); > > + e = errno; > > + if (ret < 0) { > > + if (e

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-24 Thread Pekka Paalanen
On Thu, 23 Aug 2018 17:53:07 +0100 Daniel Stone wrote: > Hi Pekka, > > On Mon, 6 Aug 2018 at 12:16, Pekka Paalanen wrote: > > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone > > wrote: > > > +/** Format current time as a string > > > + * and append the debug scope name to it > > > + * > > >

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-23 Thread Daniel Stone
Hi Pekka, On Mon, 6 Aug 2018 at 12:16, Pekka Paalanen wrote: > On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > > +/** Format current time as a string > > + * and append the debug scope name to it > > + * > > + * \param scope[in] debug scope. > > + * \param buf[out] Buffer to store the s

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > weston_debug is both a libweston API for relaying debugging messages, > and the compositor-debug wayland protocol implementation for accessing those > debug messages from a Wayland client. > > weston_debug_compos

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-06 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > weston_debug is both a libweston API for relaying debugging messages, > and the compositor-debug wayland protocol implementation for accessing those > debug messages from a Wayland client. > > weston_debug_compos

Re: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-08-03 Thread Pekka Paalanen
On Fri, 20 Jul 2018 20:03:24 +0100 Daniel Stone wrote: > From: Pekka Paalanen > > weston_debug is both a libweston API for relaying debugging messages, > and the compositor-debug wayland protocol implementation for accessing those > debug messages from a Wayland client. > > weston_debug_compos

RE: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-07-26 Thread Ucan, Emre (ADITG/ESB)
gt; To: wayland-devel@lists.freedesktop.org > Cc: pekka.paala...@collabora.co.uk; emre.u...@de.adit-jv.com; > maniraj.devad...@in.bosch.com > Subject: [PATCH weston v5 03/14] libweston: add weston_debug API and > implementation > > From: Pekka Paalanen > > weston_debug is both

[PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen weston_debug is both a libweston API for relaying debugging messages, and the compositor-debug wayland protocol implementation for accessing those debug messages from a Wayland client. weston_debug_compositor_{create,destroy}() are private API, hence not exported. Signed-of