Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-05-10 Thread Bryce Harrington
On Tue, May 10, 2016 at 03:33:59PM +0300, Pekka Paalanen wrote: > On Fri, 29 Apr 2016 15:40:35 -0700 > Bryce Harrington wrote: > > > The drm backend was copying most everything out of the config object > > already, but now also copy the use_current_mode parameter and the > > config_output functio

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-05-10 Thread Pekka Paalanen
On Fri, 29 Apr 2016 15:40:35 -0700 Bryce Harrington wrote: > The drm backend was copying most everything out of the config object > already, but now also copy the use_current_mode parameter and the > config_output function pointer, so that there are no remaining > references to the config object

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-05-05 Thread Benoit Gschwind
Hello Bryce, Ok I can live with this patches ;) Reviewed-by: Benoit Gschwind On 05/05/2016 00:24, Bryce Harrington wrote: > On Sat, Apr 30, 2016 at 11:41:15AM +0200, Benoit Gschwind wrote: >> Hello Bryce, >> >> I think my comments on previous patch apply here, while you did some >> useful updat

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-05-04 Thread Bryce Harrington
On Sat, Apr 30, 2016 at 11:41:15AM +0200, Benoit Gschwind wrote: > Hello Bryce, > > I think my comments on previous patch apply here, while you did some > useful update here. This patch essentially takes care of much of what you mentioned in the previous review. Your other suggestions sound like

Re: [PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-04-30 Thread Benoit Gschwind
Hello Bryce, I think my comments on previous patch apply here, while you did some useful update here. Best regards. Le 30/04/2016 00:40, Bryce Harrington a écrit : > The drm backend was copying most everything out of the config object > already, but now also copy the use_current_mode parameter a

[PATCH weston v7 3/3] drm: Don't hang onto the backend config object post-backend_init

2016-04-29 Thread Bryce Harrington
The drm backend was copying most everything out of the config object already, but now also copy the use_current_mode parameter and the config_output function pointer, so that there are no remaining references to the config object passed into backend_init(). By decoupling the config struct to the b