Re: [PATCH xwayland 2/3] Check for frame being NULL before setting/unsetting flags

2013-11-15 Thread Dima Ryazanov
You're right, your fix does look better! On Fri, Nov 15, 2013 at 5:07 AM, Axel Davy wrote: > I've posted a patch, which prevents wm->focus_window to be a window > without frame. > > This solves the same bug than this patch, but looks better to me. > > > http://lists.freedesktop.org/archives/wa

Re: [PATCH xwayland 2/3] Check for frame being NULL before setting/unsetting flags

2013-11-15 Thread Axel Davy
I've posted a patch, which prevents wm->focus_window to be a window without frame. This solves the same bug than this patch, but looks better to me. http://lists.freedesktop.org/archives/wayland-devel/2013-November/012008.html Axel Davy Le 15/11/2013 11:25, Axel Davy a écrit : This patch (Ag

Re: [PATCH xwayland 2/3] Check for frame being NULL before setting/unsetting flags

2013-11-15 Thread Axel Davy
This patch (Again, I had the same), solves the last bugs for XWayland, but for this one, I'm not sure it is the correct fix. In fact it would mean than focus_window would be an unmapped windows, which looks strange to me. Axel Davy Le 15/11/2013 11:01, Dima Ryazanov a écrit : Fixes a crash in

[PATCH xwayland 2/3] Check for frame being NULL before setting/unsetting flags

2013-11-15 Thread Dima Ryazanov
Fixes a crash in Firefox when clicking an "install plugin" popup. Signed-off-by: Dima Ryazanov --- src/xwayland/window-manager.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/xwayland/window-manager.c b/src/xwayland/window-manager.c index 5ee9480..6d29026 100644 -