Re: [RFCv3 weston 01/15] compositor: refactor more into weston_surface_attach

2014-03-08 Thread Pekka Paalanen
On Sat, 8 Mar 2014 00:01:49 +0100 Daniel Stone wrote: > Hi, > > On 7 March 2014 13:03, Pekka Paalanen wrote: > > Merge more code into a common function. No functional changes. > > Quick nitpick: does this not break all the pixman_region32_*() calls > in weston_surface_commit(), which rely on s

Re: [RFCv3 weston 01/15] compositor: refactor more into weston_surface_attach

2014-03-07 Thread Daniel Stone
Hi, On 7 March 2014 13:03, Pekka Paalanen wrote: > Merge more code into a common function. No functional changes. Quick nitpick: does this not break all the pixman_region32_*() calls in weston_surface_commit(), which rely on surface->{width,height}? Should be pretty easy to see this breakage whe

[RFCv3 weston 01/15] compositor: refactor more into weston_surface_attach

2014-03-07 Thread Pekka Paalanen
From: Pekka Paalanen Merge more code into a common function. No functional changes. Signed-off-by: Pekka Paalanen --- src/compositor.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 7c29d51..09e1acb 100644 --- a/src/comp