Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Pekka Paalanen
On Tue, 10 Dec 2013 16:09:18 +0100 Giulio Camuffo wrote: > 2013/12/10 Pekka Paalanen : > > On Tue, 10 Dec 2013 14:46:25 +0100 > > Giulio Camuffo wrote: > > > >> But the visible region of a surface wouldn't be a rect minus a > >> rect, but the intersection of two rects, which is always a rect as

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Giulio Camuffo
2013/12/10 Pekka Paalanen : > On Tue, 10 Dec 2013 14:46:25 +0100 > Giulio Camuffo wrote: > >> But the visible region of a surface wouldn't be a rect minus a rect, >> but the intersection of two rects, which is always a rect as long as >> they are both axis aligned, and surface rotation isn't suppo

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Pekka Paalanen
On Tue, 10 Dec 2013 14:46:25 +0100 Giulio Camuffo wrote: > But the visible region of a surface wouldn't be a rect minus a rect, > but the intersection of two rects, which is always a rect as long as > they are both axis aligned, and surface rotation isn't supported > anyway by the rpi renderer, r

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Giulio Camuffo
But the visible region of a surface wouldn't be a rect minus a rect, but the intersection of two rects, which is always a rect as long as they are both axis aligned, and surface rotation isn't supported anyway by the rpi renderer, right? What's a rect minus a rect is the weston_view::clip region, w

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Pekka Paalanen
On Tue, 10 Dec 2013 14:13:50 +0100 Giulio Camuffo wrote: > 2013/12/10 Pekka Paalanen : > > On Tue, 10 Dec 2013 11:13:42 +0100 > > Giulio Camuffo wrote: > > > >> 2013/12/10 Jason Ekstrand : > >> > Giulio, > >> > Couple thoughts. First, you don't provide an implementation of > >> > the clipping i

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Giulio Camuffo
2013/12/10 Pekka Paalanen : > On Tue, 10 Dec 2013 11:13:42 +0100 > Giulio Camuffo wrote: > >> 2013/12/10 Jason Ekstrand : >> > Giulio, >> > Couple thoughts. First, you don't provide an implementation of the >> > clipping in any of the renderers. Probably have to wait on the >> > Collabora peopl

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Pekka Paalanen
On Tue, 10 Dec 2013 11:13:42 +0100 Giulio Camuffo wrote: > 2013/12/10 Jason Ekstrand : > > Giulio, > > Couple thoughts. First, you don't provide an implementation of the > > clipping in any of the renderers. Probably have to wait on the > > Collabora people for the RPi renderer, but we should

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-10 Thread Giulio Camuffo
2013/12/10 Jason Ekstrand : > Giulio, > Couple thoughts. First, you don't provide an implementation of the clipping > in any of the renderers. Probably have to wait on the Collabora people for > the RPi renderer, but we should have pixman and gl implementations of this. There is no need to add

Re: [PATCH weston] compositor: add a masking mechanism to weston_layer

2013-12-09 Thread Jason Ekstrand
Giulio, Couple thoughts. First, you don't provide an implementation of the clipping in any of the renderers. Probably have to wait on the Collabora people for the RPi renderer, but we should have pixman and gl implementations of this. Second, is there any particular reason why you're using pixm