Re: [prefix=PATCH weston] gl-renderer.c: Pass visual ID for choosing egl configs for pbuffer

2018-08-02 Thread Daniel Stone
Hi Madhurkiran, On Tue, 31 Jul 2018 at 02:02, Madhurkiran Harikrishnan wrote: > Thanks for the comments. For a not having configless_context, can you > explain why should I check gr->egl_config, because the attributes passed > while getting this gr->egl_config does not have EGL_PBUFFER_BIT set

Re: [PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-02 Thread Quentin Glidic
On 8/2/18 10:29 AM, Quentin Glidic wrote: From: Quentin Glidic If we start a special (grabbing) client when Weston is unfocused, it would lose focus when coming back to Weston. A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b but it messed with VT switching. This fix

[PATCH weston 2/2] input: Update to-be-restored focus when unfocused

2018-08-02 Thread Quentin Glidic
From: Quentin Glidic If we start a special (grabbing) client when Weston is unfocused, it would lose focus when coming back to Weston. A first attempt to fix this was 85d55540cb64bf97a08b40f79dc66843f8295d3b but it messed with VT switching. This fix just updates the saved focus, so when Weston

[PATCH weston 1/2] Revert "input: Do not override keyboard focus on restore"

2018-08-02 Thread Quentin Glidic
From: Quentin Glidic This reverts commit 85d55540cb64bf97a08b40f79dc66843f8295d3b. It brought issues for proper VT switching focus handling. Signed-off-by: Quentin Glidic --- libweston/input.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/libw

Re: [PATCH weston] libinput: Restore keyboard focus after VT switch

2018-08-01 Thread Peter Hutterer
for the archives, this had a short discusson on IRC but then fell under the radar again On Sun, Jul 22, 2018 at 06:53:56AM -0700, Jamey Sharp wrote: > Hey Daniel, thanks for taking a look! It turns out that this patch worked > in Weston 3, but in Weston 4,

RE: [prefix=PATCH weston] gl-renderer.c: Pass visual ID for choosing egl configs for pbuffer

2018-07-30 Thread Madhurkiran Harikrishnan
arikrishnan Subject: Re: [prefix=PATCH weston] gl-renderer.c: Pass visual ID for choosing egl configs for pbuffer Hi Madhurkiran, On Wed, 21 Mar 2018 at 22:45, Madhurkiran Harikrishnan wrote: > + if (pbuffer_config != gr->egl_config && > +

Re: [PATCH weston 3/4] README: Move to Markdown, rewrite introduction

2018-07-30 Thread Daniel Stone
fuck it then, I'll wait for gitlab Given that overwhelming balance, I propose to merge these patches to Weston shortly before RC1, plus a similar set of patches for Wayland at the same time. Cheers, Daniel ___ wayland-devel mailing list wayland-deve

RE: [PATCH weston v5 10/14] compositor: protocol logger

2018-07-30 Thread Ucan, Emre (ADITG/ESB)
nd-devel- > boun...@lists.freedesktop.org] On Behalf Of Daniel Stone > Sent: Freitag, 20. Juli 2018 21:07 > To: wayland-devel@lists.freedesktop.org > Cc: pekka.paala...@collabora.co.uk; emre.u...@de.adit-jv.com; > maniraj.devad...@in.bosch.com > Subject: [PATCH weston v5 10/14] compositor: protoco

[ANNOUNCE] weston 4.0.92

2018-07-27 Thread Derek Foreman
Hello, Here is the beta release for weston 5.0. Daniel Stone (3): compositor-drm: Remove unnecessary libdrm defines compositor-drm: Don't test render-only atomic configuration compositor-drm: Remove addfb warning for user buffers Derek Foreman (1): configure.ac: bu

RE: DRM page-flip with damage for weston

2018-07-26 Thread Deepak Singh Rawat
working from git master, I recommend you > > > do so, as the DRM backend has changed hugely since 4.0.0. > > > > Thanks Daniel for help and it the change suggested by you are working with > > my drm code. Another question regarding Weston, does each output in > &g

Re: DRM page-flip with damage for weston

2018-07-26 Thread Daniel Stone
, if you are not already working from git master, I recommend you > > do so, as the DRM backend has changed hugely since 4.0.0. > > Thanks Daniel for help and it the change suggested by you are working with > my drm code. Another question regarding Weston, does each output in > Westo

RE: [PATCH weston v5 05/14] clients: add weston-debug

2018-07-26 Thread Ucan, Emre (ADITG/ESB)
gt; To: wayland-devel@lists.freedesktop.org > Cc: pekka.paala...@collabora.co.uk; emre.u...@de.adit-jv.com; > maniraj.devad...@in.bosch.com > Subject: [PATCH weston v5 05/14] clients: add weston-debug > > From: Pekka Paalanen > > A tool for accessing the zcompositor_debug_v1 inte

RE: [PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-07-26 Thread Ucan, Emre (ADITG/ESB)
gt; To: wayland-devel@lists.freedesktop.org > Cc: pekka.paala...@collabora.co.uk; emre.u...@de.adit-jv.com; > maniraj.devad...@in.bosch.com > Subject: [PATCH weston v5 03/14] libweston: add weston_debug API and > implementation > > From: Pekka Paalanen > > weston_debug is both

RE: [PATCH weston v5 02/14] protocol: add weston-debug.xml

2018-07-26 Thread Ucan, Emre (ADITG/ESB)
gt; To: wayland-devel@lists.freedesktop.org > Cc: pekka.paala...@collabora.co.uk; emre.u...@de.adit-jv.com; > maniraj.devad...@in.bosch.com > Subject: [PATCH weston v5 02/14] protocol: add weston-debug.xml > > From: Pekka Paalanen > > This is a new debugging extension for non-p

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-26 Thread Daniel Stone
he cursor surface. e.g. > If the left side of the surface has a resize left cursor, you leave, and > hover over the right, you don't want to see the resize left cursor for a > split second before the resize right cursor appears. > > The original implementation of Weston respected t

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-25 Thread Jasper St. Pierre
ou leave, and hover over the right, you don't want to see the resize left cursor for a split second before the resize right cursor appears. The original implementation of Weston respected this and would only change the cursor on set_cursor calls and would not even remember a per-client cu

RE: DRM page-flip with damage for weston

2018-07-25 Thread Deepak Singh Rawat
hugely since 4.0.0. Thanks Daniel for help and it the change suggested by you are working with my drm code. Another question regarding Weston, does each output in Weston create separate scan-out framebuffer always ? Thanks, Deepak > > Cheers, > Daniel ___

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-24 Thread Daniel Stone
Hey, On Tue, 24 Jul 2018 at 22:45, Derek Foreman wrote: > On 2018-07-22 05:55 AM, Daniel Stone wrote: > > I take it the problem is that the client sets a particular surface as > > the pointer surface, loses focus, sets the same surface as the pointer > > surface on re-enter after not changing the

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-24 Thread Derek Foreman
;t just an obviously pointless optimization, it turns all >> of toy toolkit into a test case for handling this properly. >> >> Signed-off-by: Derek Foreman >> --- >> >> Continuing my streak of posting unpopular patches, this patch breaks >> weston, so I&

Re: [PATCH weston] simple-dmabuf-drm: use GBM generic calls

2018-07-24 Thread Emil Velikov
located, and this was > before the GBM modifiers interface existed > - at the time, I was doing bring-up of a GBM implementation which > wasn't usable by generic clients (privileged allocation only) > - YUV format support > > I'm pretty ambivalent about it though.

RE: [PATCH v3 weston 4/5] tests: add test for setting gamma

2018-07-24 Thread Harsha Manjula Mallikarjun (RBEI/ECF3)
> -Original Message- > From: Daniel Stone [mailto:dan...@fooishbar.org] > Sent: Saturday, July 21, 2018 5:52 PM > To: Harsha Manjula Mallikarjun (RBEI/ECF3) > > Cc: wayland > Subject: Re: [PATCH v3 weston 4/5] tests: add test for setting gamma > > Hi Harsha,

RE: [PATCH v3 weston 3/5] compositor-drm: add support for CTM property

2018-07-24 Thread Harsha Manjula Mallikarjun (RBEI/ECF3)
> -Original Message- > From: Daniel Stone [mailto:dan...@fooishbar.org] > Sent: Saturday, July 21, 2018 5:48 PM > To: Harsha Manjula Mallikarjun (RBEI/ECF3) > > Cc: wayland > Subject: Re: [PATCH v3 weston 3/5] compositor-drm: add support for CTM > property > &

Re: [PATCH weston] libinput: Restore keyboard focus after VT switch

2018-07-22 Thread Jamey Sharp
Hey Daniel, thanks for taking a look! It turns out that this patch worked in Weston 3, but in Weston 4, commit 85d55540cb64bf97a08b40f79dc66843f8295d3 broke it. I didn't investigate carefully enough to understand what that commit was for or why it broke this, but my patch plus a revert of

Re: [RFC weston] clients: Don't attach a buffer if mouse cursor surface is unchanged

2018-07-22 Thread Daniel Stone
lkit into a test case for handling this properly. > > Signed-off-by: Derek Foreman > --- > > Continuing my streak of posting unpopular patches, this patch breaks > weston, so I'm not pushing for inclusion, but I think we need to > resolve why it breaks, and fix either we

Re: [PATCH weston] shared/config-parser: Allow spaces/tabs at the end for

2018-07-22 Thread Daniel Stone
Hi Marius, On Wed, 21 Feb 2018 at 14:38, Marius Vlad wrote: > @@ -456,6 +457,10 @@ weston_config_parse(const char *name) > section = config_add_section(config, &line[1]); > continue; > default: > + start_line = s

Re: [prefix=PATCH weston] gl-renderer.c: Pass visual ID for choosing egl configs for pbuffer

2018-07-22 Thread Daniel Stone
Hi Madhurkiran, On Wed, 21 Mar 2018 at 22:45, Madhurkiran Harikrishnan wrote: > + if (pbuffer_config != gr->egl_config && > + !gr->has_configless_context) { > + weston_log("attempted to use a different EGL config for an " > + "output but EGL_

Re: [PATCH weston v2] ivi-shell: use install paths in example config

2018-07-22 Thread Daniel Stone
, Emre Ucan wrote: > >>> > The example weston.ini file uses source and build > >>> > directory paths. Therefore, it is only useful when > >>> > used on the same system that is used to build Weston. > >>> > > >>> > We ca

Re: [PATCH weston] libinput: Restore keyboard focus after VT switch

2018-07-22 Thread Daniel Stone
Hi Jamey, On Wed, 23 May 2018 at 14:16, Jamey Sharp wrote: > Under Weston's drm-backend, after returning to Weston from another VT, > no window has focus. > > There's already code in notify_keyboard_focus_out and > notify_keyboard_focus_in to save and restore

Re: [PATCH weston] ivi-shell: listen compositor wake_signal

2018-07-22 Thread Daniel Stone
Hi Emre, On Tue, 5 Jun 2018 at 09:30, Emre Ucan wrote: > If compositor wakes up from sleep state, we have > to trigger repaint for all outputs. Seems trivially correct, merged with review: 280b73014..cf4113c62 cf4113c629751adcbb9904087932e12b5621219b -> master Cheers, Daniel ___

Re: [PATCH v3 weston 4/5] tests: add test for setting gamma

2018-07-21 Thread Daniel Stone
Hi Harsha, On Thu, 28 Jun 2018 at 14:28, wrote: > +static int > +gamma_update_event(void *data) > +{ > + struct gamma_tobject *obj; > + struct output_obj *op_obj; > + uint16_t *r, *g, *b; > + bool all_tests_complete = true; > + > + obj = (struct gamma_tobject *)data;

Re: [PATCH v3 weston 3/5] compositor-drm: add support for CTM property

2018-07-21 Thread Daniel Stone
Hi Harsha, On Thu, 28 Jun 2018 at 14:29, wrote: > + struct drm_output *output = to_drm_output(output_base); > + struct drm_backend *backend = to_drm_backend(output->base.compositor); > + struct drm_color_ctm ctm; > + uint32_t ctm_blobid = 0; > + uint32_t ctm_prop_id;

Re: [PATCH v3 weston 1/5] compositor-drm: Implement support for GAMMA_LUT drm property

2018-07-21 Thread Daniel Stone
Hi Harsha, Some small comments here, but more substantial comments in another patch. On Thu, 28 Jun 2018 at 14:28, wrote: > + gamma_prop_id = output->props_crtc[WDRM_CRTC_GAMMA_LUT].prop_id; > + gamma_size_prop_id = output->props_crtc[WDRM_CRTC_GAMMA_LUT_SIZE]. > +

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-21 Thread Guido Günther
fic code for each supported > > > driver, we can just let GBM call the right one for us now. > > > > This one breaks NV12 on intel when using rootston as compositor for me. > > > > $ ./weston-simple-dmabuf-drm --import-format=NV12 > > Error: zwp_linux_buffer_para

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-20 Thread Guido Günther
t; > This one breaks NV12 on intel when using rootston as compositor for me. > > $ ./weston-simple-dmabuf-drm --import-format=NV12 > Error: zwp_linux_buffer_params.create failed. > Error: zwp_linux_buffer_params.create failed. > Error: zwp_linux_buffer_params.cre

Re: [PATCH weston 2/2] simple-dmabuf-drm: use GBM generic calls

2018-07-20 Thread Guido Günther
Hi, On Thu, Jul 19, 2018 at 04:45:02PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. > > Signed-off-by: Emilio Pozuelo Monfort > --- > Some improvements from Daniel (thanks!). I a

[PATCH weston v5 10/14] compositor: protocol logger

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen This is better than running Weston with WAYLAND_DEBUG=server: - It is enabled on demand, no unnecessary flooding and no need to restart the compositor if debug was enabled. - It prints client pointers so that messages with different clients can be seen apart. Signed-off

[PATCH weston v5 13/14] compositor-drm: Calculate atomic-commit flags earlier

2018-07-20 Thread Daniel Stone
Shift up our calculation of the flags we use for atomic commits. We will later use this to differentiate between test-only and full commits when printing debug information inside drm_output_state_apply_atomic. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 25 +-

[PATCH weston v5 07/14] xwm: dump_property() to use FILE internally

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen Write the output of dump_property() out in one log call. When multiple processes (weston and Xwayland) are writing to the same file, this will keep the property dump uninterrupted by Xwayland debug prints. This is also preparation for more development in the same direction

[PATCH weston v5 11/14] compositor: Add weston_layer_mask_is_infinite

2018-07-20 Thread Daniel Stone
As a counterpart to weston_layer_set_mask_infinite(), returning if the mask is the same as what is set. Signed-off-by: Daniel Stone --- libweston/compositor.c | 9 + libweston/compositor.h | 3 +++ 2 files changed, 12 insertions(+) diff --git a/libweston/compositor.c b/libweston/composi

[PATCH weston v5 04/14] compositor: add option to enable weston_debug

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen Let users enable the compositor debug protocol on the compositor command line. This allows weston-debug tool to work. Signed-off-by: Pekka Paalanen Signed-off-by: Maniraj Devadoss Reviewed-by: Pekka Paalanen --- compositor/main.c | 7 +++ man/weston.man| 11

[PATCH weston v5 06/14] compositor: offer logs via weston-debug

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen This registers a new weston-debug scope "log" through which one can get live log output interspersed with possible other debugging prints. Signed-off-by: Pekka Paalanen pass the log_scope to weston_debug_scope_timestamp API to append the scope name to the

[PATCH weston v5 14/14] compositor-drm: Add drm-backend log debug scope

2018-07-20 Thread Daniel Stone
le changed, 206 insertions(+), 27 deletions(-) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 653d13e0c..2cadf036c 100644 --- a/libweston/compositor-drm.c +++ b/libweston/compositor-drm.c @@ -51,6 +51,7 @@ #include "compositor.h" #include "compositor-dr

[PATCH weston v5 05/14] clients: add weston-debug

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen A tool for accessing the zcompositor_debug_v1 interface features. Installed along weston-info, because it should be potentially useful for people running libweston-based compositors. Signed-off-by: Pekka Paalanen Added a man page for weston-debug client Signed-off-by

[PATCH weston v5 12/14] compositor: Add scene-graph debug scope

2018-07-20 Thread Daniel Stone
libweston/compositor.h | 4 + 2 files changed, 223 insertions(+) diff --git a/libweston/compositor.c b/libweston/compositor.c index 0c147d4a6..dea91d173 100644 --- a/libweston/compositor.c +++ b/libweston/compositor.c @@ -55,6 +55,8 @@ #include "timeline.h" #include "compos

[PATCH weston v5 08/14] xwm: move FILE to the callers of dump_property()

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen This is preparation for using the weston-debug infrastructure for WM_DEBUG. dump_property() may be called from different debugging contexts and often needs to be prefixed with more information. An alternative to this patch would be to pass in the weston_debug_scope as an

[PATCH weston v5 09/14] xwm: convert WM_DEBUG into a weston-debug scope

2018-07-20 Thread Daniel Stone
From: Pekka Paalanen Instead of a compile time choice, offer the XWM debugging messages through the weston-debug protocol and tool on demand. Users will not need to recompile weston to get XWM debugging, and it won't flood the weston log. The debug scope needs to be initialized in launc

[PATCH weston v5 03/14] libweston: add weston_debug API and implementation

2018-07-20 Thread Daniel Stone
+ libweston/compositor.c | 6 + libweston/compositor.h | 9 + libweston/weston-debug.c | 723 +++ libweston/weston-debug.h | 107 ++ 5 files changed, 847 insertions(+) create mode 100644 libweston/weston-debug.c create mode 100644 libweston/weston-debug.h

[PATCH weston v5 00/14] weston-debug API and tool

2018-07-20 Thread Daniel Stone
Hi, This patch series implements the weston-debug interface and tool, as previously worked on by Pekka, Maniraj and Emre. The xwm changes are unchanged from the previous series, and additionally reviewed by myself. The core protocol has seen the addition of a registry-like advertising interface

[PATCH weston v5 01/14] compositor-drm: Add backend pointer to drm_output

2018-07-20 Thread Daniel Stone
Add this for convenience, so it's easier to access when we add the DRM backend debug scope. Signed-off-by: Daniel Stone --- libweston/compositor-drm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c index 704ac32c7..e27671437 100644

[PATCH weston v5 02/14] protocol: add weston-debug.xml

2018-07-20 Thread Daniel Stone
that for external projects to find the XML files installed by libweston. Signed-off-by: Maniraj Devadoss Use noarch_pkgconfig_DATA instead, add ${pc_sysrootdir}, drop unnecessary EXTRA_DIST of weston-debug.xml. Signed-off-by: Pekka Paalanen Add explicit advertisement of available debug

Re: DRM page-flip with damage for weston

2018-07-20 Thread Daniel Stone
like vmwgfx where each > framebuffer > change needs to be transmitted over network, usb, etc. > > Now that I have some code ready and got it working for vmwgfx driver, the > next step is to change weston to send damage during page flip. With my current > understanding of weston I th

DRM page-flip with damage for weston

2018-07-20 Thread Deepak Singh Rawat
fixed point. Damage during page flip is helpful for some drivers like vmwgfx where each framebuffer change needs to be transmitted over network, usb, etc. Now that I have some code ready and got it working for vmwgfx driver, the next step is to change weston to send damage during page flip. With my

Re: [PATCH weston 3/4] README: Move to Markdown, rewrite introduction

2018-07-20 Thread Quentin Glidic
On 7/14/18 3:09 PM, Daniel Stone wrote: Move the README file to Markdown, and update it to attempt to explain the current status and use of Weston. From patch 1: > The patch is a single logical change. If the commit message addresses > multiple points, it is a hint that the commit migh

[PATCH weston 1/2 v5] simple-dmabuf-drm: nv12: properly fill Y plane

2018-07-19 Thread Emilio Pozuelo Monfort
We want 0..255 values, not 0..254. Signed-off-by: Emilio Pozuelo Monfort --- No changes in this version. clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index bd0f9224..5bc5323e 100644 ---

[PATCH weston 2/2] simple-dmabuf-drm: use GBM generic calls

2018-07-19 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- Some improvements from Daniel (thanks!). I also added missing error messages, formatting fixes and a logic error in your improvement

[PATCH weston 2/4] doc: Update CONTRIBUTING for Weston

2018-07-14 Thread Daniel Stone
Change some Wayland-specific references to instead refer to Weston. Signed-off-by: Daniel Stone --- CONTRIBUTING.md | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4273d99d4..91b3fffe9 100644 --- a/CONTRIBUTING.md +++ b

[PATCH weston 4/4] doc: Use GitLab MRs for patches, not the list

2018-07-14 Thread Daniel Stone
Though Wayland and the protocols still use mail-based patch review, Weston can now move to GitLab MRs with review through that system. Add some documentation on how to submit patches through GitLab, specifically targeted at people who may be familiar with GitLab review, but not familiar with our

[PATCH weston 1/4] Add CONTRIBUTING.md document

2018-07-14 Thread Daniel Stone
From: Pekka Paalanen Taken from Pekka's wayland/wayland@630c25f4c160 and follow-ups, use Wayland's CONTRIBUTING document as a basis for Weston. Signed-off-by: Daniel Stone --- CONTRIBUTING.md | 343 1 file changed, 343 insertions(

[PATCH weston 0/4] Doc updates, GitLab MRs

2018-07-14 Thread Daniel Stone
Hi, The first two patches simply copy Pekka's CONTRIBUTING.md work, which just landed in Wayland, into Weston. The third patch attempts to use the power of the English language, augmented with Markdown, to explain to people what Weston is in 2018, and how they might go about using it

[ANNOUNCE] weston 4.0.91

2018-07-13 Thread Derek Foreman
This is the alpha for weston 5.0. Lots of changes from lots of people - highlights include, but certainly aren't limited to: The use of hardware planes in atomic mode setting Clone mode, and all the infrastructure changes to make it possible A new touchscreen calibrator Full change hi

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-13 Thread Daniel Stone
surface_v6@7, wl_surface@3) [1495104.404] -> zxdg_surface_v6@7.get_toplevel(new id zxdg_toplevel_v6@8) [1495104.414] -> zxdg_toplevel_v6@8.set_title("simple-dmabuf") [1495104.422] -> wl_surface@3.commit() Missing separate debuginfo for /lib64/libstdc++.so.6 Try: dnf --enabl

Re: [PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-13 Thread Guido Günther
Hi, On Thu, Jul 12, 2018 at 01:46:25PM +0200, Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. This one breaks NV12 on intel when using rootston as compositor for me. $ ./weston-

Re: [PATCH weston v4] simple-dmabuf-drm: nv12: properly fill Y plane

2018-07-13 Thread Daniel Stone
Hi Emilio, On Thu, 12 Jul 2018 at 12:46, Emilio Pozuelo Monfort wrote: > @@ -147,7 +147,7 @@ fill_content(struct buffer *my_buf, uint64_t modifier) > for (y = 0; y < my_buf->height; y++) { > pix8 = my_buf->mmap + y * my_buf->stride; >

Re: [PATCH weston 1/3 v4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-13 Thread Daniel Stone
Hi Emilio, On Thu, 12 Jul 2018 at 12:47, Emilio Pozuelo Monfort wrote: > @@ -821,16 +820,8 @@ registry_handle_global(void *data, struct wl_registry > *registry, > d->fshell = wl_registry_bind(registry, > id, > &zwp_fullscreen_shell_v1

Weston default pixel format

2018-07-12 Thread Santiago Otero
Hi all, I have a display device that supports up to three different display buffers: one graphic layer and two video layers. The graphic layer is at the top (zpos=2). I'm using Weston (DRM backend) with a Qt5 application at full screen (graphic layer). Weston is using pixel format XR24

Re: [PATCH weston 3/4] simple-dmabuf-drm: use GBM generic calls

2018-07-12 Thread Emilio Pozuelo Monfort
On 11/07/18 13:55, Daniel Stone wrote: > Hi Emilio, > > On Wed, 11 Jul 2018 at 12:53, Emilio Pozuelo Monfort > wrote: >> As for NV12 support: I tried to make gbm support that in >> backends/dri/gbm_dri.c by adding a mapping to gbm_dri_visuals_table >> from GBM_FORMAT_NV12 to __DRI_IMAGE_FOURCC_N

[PATCH weston 3/3 v4] simple-dmabuf-drm: use GBM generic calls

2018-07-12 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- v4: now with working NV12, (thanks Daniel!). clients/simple-dmabuf-drm.c | 411 configure.ac

[PATCH weston v4] simple-dmabuf-drm: nv12: properly fill Y plane

2018-07-12 Thread Emilio Pozuelo Monfort
We want 0..255 values, not 0..254. Signed-off-by: Emilio Pozuelo Monfort --- New patch. clients/simple-dmabuf-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 4f88f12e..198d88e8 100644 --- a/clients/simple-

[PATCH weston 2/3 v4] simple-dmabuf-drm: fix build with --disable-egl

2018-07-12 Thread Emilio Pozuelo Monfort
Just rely on getting the supported formats through the dmabuf extension. Signed-off-by: Emilio Pozuelo Monfort --- v4: no changes. clients/simple-dmabuf-drm.c | 11 --- configure.ac| 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/clients/simple-dma

[PATCH weston 1/3 v4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-12 Thread Emilio Pozuelo Monfort
We effectively require it as we don't react to dmabuf_format, only to dmabuf_modifiers, so there's a chance we may not get the supported formats information at all. Signed-off-by: Emilio Pozuelo Monfort --- v4: No changes here. clients/simple-dmabuf-drm.c | 12 +--- 1 file changed, 1 in

Re: [PATCH weston 3/4] simple-dmabuf-drm: use GBM generic calls

2018-07-11 Thread Daniel Stone
Hi Emilio, On Wed, 11 Jul 2018 at 12:53, Emilio Pozuelo Monfort wrote: > As for NV12 support: I tried to make gbm support that in > backends/dri/gbm_dri.c by adding a mapping to gbm_dri_visuals_table > from GBM_FORMAT_NV12 to __DRI_IMAGE_FOURCC_NV12 or DRM_FORMAT_NV12, > but that didn't work. I'm

[PATCH weston 2/4 v3] simple-dmabuf-drm: fix build with --disable-egl

2018-07-11 Thread Emilio Pozuelo Monfort
Just rely on getting the supported formats through the dmabuf extension. Signed-off-by: Emilio Pozuelo Monfort --- v3: this now drops the dependency on libEGL clients/simple-dmabuf-drm.c | 11 --- configure.ac| 2 +- 2 files changed, 1 insertion(+), 12 deletions(-) dif

[PATCH weston] simple-dmabuf-drm: drop dependency on libdrm

2018-07-11 Thread Emilio Pozuelo Monfort
Signed-off-by: Emilio Pozuelo Monfort --- clients/simple-dmabuf-drm.c | 32 +++- configure.ac| 2 +- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/clients/simple-dmabuf-drm.c b/clients/simple-dmabuf-drm.c index 1d452183..a6c3b16d 100

[PATCH weston 1/4] simple-dmabuf-drm: require zwp_linux_dmabuf_v1 v3

2018-07-11 Thread Emilio Pozuelo Monfort
We effectively require it as we don't react to dmabuf_format, only to dmabuf_modifiers, so there's a chance we may not get the supported formats information at all. Signed-off-by: Emilio Pozuelo Monfort --- clients/simple-dmabuf-drm.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletio

[PATCH weston 3/4] simple-dmabuf-drm: use GBM generic calls

2018-07-11 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- v2: we now pass the correct modifier to fill_content and zwp_linux_buffer_params_v1_add(). Added a new note since I'm not sure if we

[PATCH weston 0/4] simple-dmabuf-drm improvements

2018-07-11 Thread Emilio Pozuelo Monfort
The first patch is new, makes us always parse the formats / modifiers. Currently we don't parse them if we end up binding to version 1 or 2, which can cause us to abort for no good reason. The last patch is just to show how we could remove the libdrm dependency. The problem there is the lack of DR

Re: [PATCH weston] simple-dmabuf-drm: use GBM generic calls

2018-07-11 Thread Guido Günther
s simplifies the code a lot, using gbm_bo as Emil suggested. Some problems > I still see: > > - NV12 doesn't work, it seems that > backends/dri/gbm_dri.c:gbm_format_to_dri_format() > doesn't support it. Simple means of testing NV12 is a useful feature so it'd be s

Re: [PATCH weston] simple-dmabuf-drm: use GBM generic calls

2018-07-11 Thread Daniel Stone
Hi, On Wed, 11 Jul 2018 at 09:16, Pekka Paalanen wrote: > On Tue, 10 Jul 2018 17:53:15 +0200 Emilio Pozuelo Monfort > wrote: > > No need to write libdrm driver specific code for each supported > > driver, we can just let GBM call the right one for us now. > > > > Signed-off-by: Emilio Pozuelo Mo

Re: [PATCH weston] simple-dmabuf-drm: use GBM generic calls

2018-07-11 Thread Pekka Paalanen
Adding more people to CC. On Tue, 10 Jul 2018 17:53:15 +0200 Emilio Pozuelo Monfort wrote: > No need to write libdrm driver specific code for each supported > driver, we can just let GBM call the right one for us now. > > Signed-off-by: Emilio Pozuelo Monfort > --- > > Hi, > > This simplifie

[PATCH weston] simple-dmabuf-drm: use GBM generic calls

2018-07-10 Thread Emilio Pozuelo Monfort
No need to write libdrm driver specific code for each supported driver, we can just let GBM call the right one for us now. Signed-off-by: Emilio Pozuelo Monfort --- Hi, This simplifies the code a lot, using gbm_bo as Emil suggested. Some problems I still see: - NV12 doesn't work, it seems that

Re: [PATCH weston v2] simple-dmabuf-drm: fix build with --disable-egl

2018-07-10 Thread Emilio Pozuelo Monfort
On 10/07/18 15:16, Pekka Paalanen wrote: > On Mon, 9 Jul 2018 17:38:49 +0200 > Emilio Pozuelo Monfort wrote: > >> This code calls into EGL to see if the dmabuf import modifiers >> extension is available, and if not it assumes XRGB is supported. >> >> Rather than disabling this client doesn't

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-10 Thread Emilio Pozuelo Monfort
On 10/07/18 14:52, Pekka Paalanen wrote: > On Tue, 3 Jul 2018 16:46:29 +0100 > Emil Velikov wrote: > >> Hi Emilio, >> >> On 2 July 2018 at 16:22, Emilio Pozuelo Monfort wrote: >>> Signed-off-by: Emilio Pozuelo Monfort >>> --- >>> I tried a build with --disable-egl as I didn't have the headers >

Re: [PATCH weston v2] simple-dmabuf-drm: fix build with --disable-egl

2018-07-10 Thread Pekka Paalanen
On Mon, 9 Jul 2018 17:38:49 +0200 Emilio Pozuelo Monfort wrote: > This code calls into EGL to see if the dmabuf import modifiers > extension is available, and if not it assumes XRGB is supported. > > Rather than disabling this client doesn't get build if one disables > EGL, we can just remo

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-10 Thread Pekka Paalanen
On Tue, 3 Jul 2018 16:46:29 +0100 Emil Velikov wrote: > Hi Emilio, > > On 2 July 2018 at 16:22, Emilio Pozuelo Monfort wrote: > > Signed-off-by: Emilio Pozuelo Monfort > > --- > > I tried a build with --disable-egl as I didn't have the headers > > installed, and it broke here. The EGL usage he

Re: [PATCH weston] libweston: Fix clear timing of output repainted flag

2018-07-10 Thread Pekka Paalanen
On Tue, 10 Jul 2018 11:47:15 +0900 Tomohito Esaki wrote: > Since the repaint status of the flushed output may be reset if a output > repaint is failed, it is necessary to clear the repainted flag > immediately after output repaint flush/cancel. > > Signed-off-by: Tomohito Esaki > --- > libwest

[PATCH weston] libweston: Fix clear timing of output repainted flag

2018-07-09 Thread Tomohito Esaki
Since the repaint status of the flushed output may be reset if a output repaint is failed, it is necessary to clear the repainted flag immediately after output repaint flush/cancel. Signed-off-by: Tomohito Esaki --- libweston/compositor.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-

[PATCH weston v2] simple-dmabuf-drm: fix build with --disable-egl

2018-07-09 Thread Emilio Pozuelo Monfort
This code calls into EGL to see if the dmabuf import modifiers extension is available, and if not it assumes XRGB is supported. Rather than disabling this client doesn't get build if one disables EGL, we can just remove this and stop lying to ourselves. Signed-off-by: Emilio Pozuelo Monfort

[PATCH weston 1/2] shot: add test for sub-surface with unmapped parent

2018-07-09 Thread Emilio Pozuelo Monfort
This reproduces https://bugs.freedesktop.org/show_bug.cgi?id=94735. Signed-off-by: Emilio Pozuelo Monfort --- tests/reference/subsurface_mapped-00.png | Bin 0 -> 799 bytes tests/reference/subsurface_mapped-01.png | Bin 0 -> 841 bytes tests/subsurface-shot-test.c | 76 +

[PATCH weston 2/2] weston-test: don't map surfaces that have no content

2018-07-09 Thread Emilio Pozuelo Monfort
If a surface has no content (e.g. no buffer), then it shouldn't be mapped, so that its subsurfaces don't get mapped either. This works fine in the desktop-shell, but is currently broken on the weston-test module. https://bugs.freedesktop.org/show_bug.cgi?id Signed-off-by: Emilio Pozue

[PATCH weston 0/2 v3] sub-surface with unmapped parent

2018-07-09 Thread Emilio Pozuelo Monfort
I forgot to git add the test ref images. That's the only change here. Emilio Pozuelo Monfort (2): shot: add test for sub-surface with unmapped parent weston-test: don't map surfaces that have no content tests/reference/subsurface_mapped-00.png | Bin 0 -> 799 bytes te

[PATCH weston 0/2] add test for sub-surface with unmapped parent

2018-07-06 Thread Emilio Pozuelo Monfort
Nothing to fix in weston itself, a similar test works fine with the desktop shell. However the test doesn't work in the test shell, so fix it there. Pekka, I see what you meant when you said that we needed to call committed() and that my previous fix was wrong. This may need some improvemen

[PATCH weston 1/2] shot: add test for sub-surface with unmapped parent

2018-07-06 Thread Emilio Pozuelo Monfort
This reproduces https://bugs.freedesktop.org/show_bug.cgi?id=94735. Signed-off-by: Emilio Pozuelo Monfort --- tests/reference/subsurface_mapped-00.png | Bin 0 -> 5294 bytes tests/reference/subsurface_mapped-01.png | Bin 0 -> 5612 bytes tests/subsurface-shot-test.c | 76 +++

[PATCH weston 2/2] weston-test: don't map surfaces that have no content

2018-07-06 Thread Emilio Pozuelo Monfort
If a surface has no content (e.g. no buffer), then it shouldn't be mapped, so that its subsurfaces don't get mapped either. This works fine in the desktop-shell, but is currently broken on the weston-test module. https://bugs.freedesktop.org/show_bug.cgi?id Signed-off-by: Emilio Pozue

Re: EXT: [PATCH weston 2/2] libweston: fix output reflow on removal

2018-07-05 Thread Pekka Paalanen
On Wed, 4 Jul 2018 13:21:14 + "Ray, Ian (GE Healthcare)" wrote: > > On 21 Jun 2018, at 15.53, Pekka Paalanen wrote: > > > > From: Pekka Paalanen > > > > This is regression apparently introduced in > > 0de859ede4bad72b5d3b78e086632f02196d997f, which accidentally swapped the > > sign of 'de

Re: EXT: [PATCH weston 2/2] libweston: fix output reflow on removal

2018-07-04 Thread Ray, Ian (GE Healthcare)
> On 21 Jun 2018, at 15.53, Pekka Paalanen wrote: > > From: Pekka Paalanen > > This is regression apparently introduced in > 0de859ede4bad72b5d3b78e086632f02196d997f, which accidentally swapped the > sign of 'delta_width' in the original call site. If one removes an > output, the remaining ou

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-03 Thread Emil Velikov
Hi Emilio, On 2 July 2018 at 16:22, Emilio Pozuelo Monfort wrote: > Signed-off-by: Emilio Pozuelo Monfort > --- > I tried a build with --disable-egl as I didn't have the headers > installed, and it broke here. The EGL usage here seemed optional so I > did that, but I didn't run-test the result.

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-03 Thread Pekka Paalanen
On Tue, 3 Jul 2018 12:35:30 +0200 Emilio Pozuelo Monfort wrote: > On 03/07/18 11:00, Pekka Paalanen wrote: > > On Mon, 2 Jul 2018 17:22:30 +0200 > > Emilio Pozuelo Monfort wrote: > > > >> Signed-off-by: Emilio Pozuelo Monfort > >> --- > >> I tried a build with --disable-egl as I didn't have

Re: [PATCH weston] simple-dmabuf-drm: fix build with --disable-egl

2018-07-03 Thread Emilio Pozuelo Monfort
On 03/07/18 11:00, Pekka Paalanen wrote: > On Mon, 2 Jul 2018 17:22:30 +0200 > Emilio Pozuelo Monfort wrote: > >> Signed-off-by: Emilio Pozuelo Monfort >> --- >> I tried a build with --disable-egl as I didn't have the headers >> installed, and it broke here. The EGL usage here seemed optional s

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-07-03 Thread Guido Günther
Hi, On Tue, Jul 03, 2018 at 12:04:37PM +0300, Pekka Paalanen wrote: > On Tue, 26 Jun 2018 20:40:08 +0200 > Guido Günther wrote: > > > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > > that too since it's not ambigous. > > > > Signed-off-by: Guido Günther > > --- > > li

Re: [PATCH weston] parse_modeline: Ignore case of {h,v}sync flags

2018-07-03 Thread Pekka Paalanen
On Tue, 26 Jun 2018 20:40:08 +0200 Guido Günther wrote: > Some modeline generators put out e.g. +HSync instead of +hsync. Accept > that too since it's not ambigous. > > Signed-off-by: Guido Günther > --- > libweston/compositor-drm.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(

<    3   4   5   6   7   8   9   10   11   12   >