Re: [PATCH weston v2 08/20] compositor: add weston_matrix_transform_rect() and use it where appropriate

2015-01-19 Thread Bill Spitzak
On 01/09/2015 01:42 PM, Giulio Camuffo wrote: Just a nitpick below: +WL_EXPORT pixman_box32_t +weston_matrix_transform_rect(struct weston_matrix *matrix, +pixman_box32_t rect) The function name doesn't imply it returns an axis aligned bounding box. Maybe

Re: [PATCH weston v2 08/20] compositor: add weston_matrix_transform_rect() and use it where appropriate

2015-01-09 Thread Giulio Camuffo
Just a nitpick below: 2014-10-16 18:55 GMT+03:00 Derek Foreman der...@osg.samsung.com: New function that transforms a pixman_box32_t rectangle by a matrix. Since pixman rectangles are represented by 2 corners, non-90 degree rotations can't be properly represented. This function gives the

[PATCH weston v2 08/20] compositor: add weston_matrix_transform_rect() and use it where appropriate

2014-10-16 Thread Derek Foreman
New function that transforms a pixman_box32_t rectangle by a matrix. Since pixman rectangles are represented by 2 corners, non-90 degree rotations can't be properly represented. This function gives the axis aligned rectangle that encloses the rotated rectangle. We use this for