Re: [webkit-changes] [109026] trunk/Source/WebCore

2012-02-27 Thread Mark Rowe
This broke release builds: On 2012-02-27, at 14:53, ad...@chromium.org wrote: > Modified: trunk/Source/WebCore/dom/Attr.cpp (109025 => 109026) > > --- trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:19:27 UTC (rev 109025) > +++ trunk/Source/WebCore/dom/Attr.cpp 2012-02-27 22:53:25 UTC (rev 10902

Re: [webkit-changes] [105940] trunk/Source

2012-01-25 Thread Mark Rowe
This change broke the build. The ChangeLog entry suggests that you committed only a subset of the changes that were expected to be in this patch. Can you please take a look and work out what is needed to fix this? Thanks, - Mark On 2012-01-25, at 16:18, e...@webkit.org wrote: > Revision > 1

Re: [webkit-changes] [104954] trunk

2012-01-13 Thread Mark Rowe
hanks for the fix! - Mark > On Fri, Jan 13, 2012 at 11:41 AM, Mark Rowe wrote: >> This broke all of the Mac builds. Please fix them ASAP, and keep an eye on >> the build bot after landing changes in the future. >> >> - Mark >> >> On 2012-01-13, at 11:0

Re: [webkit-changes] [104954] trunk

2012-01-13 Thread Mark Rowe
This broke all of the Mac builds. Please fix them ASAP, and keep an eye on the build bot after landing changes in the future. - Mark On 2012-01-13, at 11:02, commit-qu...@webkit.org wrote: > Revision > 104954 > Author > commit-qu...@webkit.org > Date > 2012-01-13 11:02:16 -0800 (Fri, 13 Jan 20

Re: [webkit-changes] [101241] trunk/Source/WebKit/mac

2011-11-28 Thread Mark Rowe
On 2011-11-28, at 19:53, Hayato Ito wrote: > Thanks. Can anyone file this as a bug in http://crbug.com/ ? I am not real > strong on Chromium Mac build. > If no one does it, I'll file a bug. - Mark ___ webkit-changes maili

Re: [webkit-changes] [101241] trunk/Source/WebKit/mac

2011-11-28 Thread Mark Rowe
urposes appears to be entirely specific to the Mac port. - Mark > On Tue, Nov 29, 2011 at 3:26 AM, Mark Rowe wrote: > This change appears to be incorrect. WebSystemInterface.mm is a Mac-only > file, so it's not clear why you're adding PLATFORM(MAC) to it. > > - Mark &

Re: [webkit-changes] [101241] trunk/Source/WebKit/mac

2011-11-28 Thread Mark Rowe
This change appears to be incorrect. WebSystemInterface.mm is a Mac-only file, so it's not clear why you're adding PLATFORM(MAC) to it. - Mark On 2011-11-28, at 03:01, hay...@chromium.org wrote: > Revision > 101241 > Author > hay...@chromium.org > Date > 2011-11-28 03:01:26 -0800 (Mon, 28 Nov 2

Re: [webkit-changes] [92113] trunk/Source/WebKit2

2011-08-01 Thread Mark Rowe
You really, really, really need to reopen the original bug when you roll out a patch like this. Leaving the original bug closed as "fixed" when the change is no longer in the tree is incredibly misleading. - Mark On 2011-08-01, at 02:53, commit-qu...@webkit.org wrote: > Revision > 92113 > Aut