[webkit-changes] [146784] trunk

2013-03-25 Thread dcheng
Title: [146784] trunk Revision 146784 Author dch...@chromium.org Date 2013-03-25 09:47:02 -0700 (Mon, 25 Mar 2013) Log Message Don't allow drags to start after a mouse press that creates a context menu https://bugs.webkit.org/show_bug.cgi?id=112079 Reviewed by Tony Chang. .: *

[webkit-changes] [146723] trunk

2013-03-23 Thread dcheng
Title: [146723] trunk Revision 146723 Author dch...@chromium.org Date 2013-03-23 18:24:42 -0700 (Sat, 23 Mar 2013) Log Message [Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing https://bugs.webkit.org/show_bug.cgi?id=113126

[webkit-changes] [142027] trunk/Source/WebKit/chromium

2013-02-06 Thread dcheng
Title: [142027] trunk/Source/WebKit/chromium Revision 142027 Author dch...@chromium.org Date 2013-02-06 13:35:55 -0800 (Wed, 06 Feb 2013) Log Message [chromium] Remove config.h header from WebUnitTests.cpp https://bugs.webkit.org/show_bug.cgi?id=108966 Reviewed by Tony Chang. This file

[webkit-changes] [132716] trunk

2012-10-26 Thread dcheng
Title: [132716] trunk Revision 132716 Author dch...@chromium.org Date 2012-10-26 18:31:08 -0700 (Fri, 26 Oct 2012) Log Message dragover's default action should prevent drop for file drags https://bugs.webkit.org/show_bug.cgi?id=79173 Reviewed by Tony Chang. Source/WebCore: During a

[webkit-changes] [123495] trunk/Source/WebCore

2012-07-24 Thread dcheng
Title: [123495] trunk/Source/WebCore Revision 123495 Author dch...@chromium.org Date 2012-07-24 11:17:44 -0700 (Tue, 24 Jul 2012) Log Message Files from drag and file input should use getMIMETypeForExtension to determine content type. https://bugs.webkit.org/show_bug.cgi?id=91702

[webkit-changes] [123370] trunk/Source/WebKit/chromium

2012-07-23 Thread dcheng
Title: [123370] trunk/Source/WebKit/chromium Revision 123370 Author dch...@chromium.org Date 2012-07-23 13:22:29 -0700 (Mon, 23 Jul 2012) Log Message [chromium] Fix build on Ubuntu Precise. https://bugs.webkit.org/show_bug.cgi?id=92021 Reviewed by Adrienne Walker. Remove an array

[webkit-changes] [121388] trunk

2012-06-27 Thread dcheng
Title: [121388] trunk Revision 121388 Author dch...@chromium.org Date 2012-06-27 17:09:03 -0700 (Wed, 27 Jun 2012) Log Message Fix crash in Frame::nodeImage. https://bugs.webkit.org/show_bug.cgi?id=89911 Reviewed by Abhishek Arya. Source/WebCore: We were caching a pointer to a

[webkit-changes] [113088] trunk

2012-04-03 Thread dcheng
Title: [113088] trunk Revision 113088 Author dch...@chromium.org Date 2012-04-03 14:21:46 -0700 (Tue, 03 Apr 2012) Log Message Having a drop handler prevents navigation on drop even if event is not cancelled https://bugs.webkit.org/show_bug.cgi?id=79172 Reviewed by Ryosuke Niwa.

[webkit-changes] [112954] trunk

2012-04-02 Thread dcheng
Title: [112954] trunk Revision 112954 Author dch...@chromium.org Date 2012-04-02 15:33:42 -0700 (Mon, 02 Apr 2012) Log Message Having a drop handler prevents navigation on drop even if event is not cancelled https://bugs.webkit.org/show_bug.cgi?id=79172 Reviewed by Ryosuke Niwa.

[webkit-changes] [112969] trunk/LayoutTests

2012-04-02 Thread dcheng
Title: [112969] trunk/LayoutTests Revision 112969 Author dch...@chromium.org Date 2012-04-02 17:25:34 -0700 (Mon, 02 Apr 2012) Log Message fast/events/drop-handler-should-not-stop-navigate.html fails on Lion https://bugs.webkit.org/show_bug.cgi?id=82984 Reviewed by Enrica Casucci. *

[webkit-changes] [111919] trunk

2012-03-23 Thread dcheng
Title: [111919] trunk Revision 111919 Author dch...@chromium.org Date 2012-03-23 15:25:16 -0700 (Fri, 23 Mar 2012) Log Message [chromium] Support file drag out using DataTransferItemList::add(File) https://bugs.webkit.org/show_bug.cgi?id=81261 Reviewed by Tony Chang. Source/WebCore:

[webkit-changes] [111090] trunk/LayoutTests

2012-03-16 Thread dcheng
Title: [111090] trunk/LayoutTests Revision 111090 Author dch...@chromium.org Date 2012-03-16 16:49:40 -0700 (Fri, 16 Mar 2012) Log Message Add layout tests that accidentally got left out of r111061 * fast/events/clipboard-dataTransferItemList-expected.txt: Added. *

[webkit-changes] [109280] trunk

2012-02-29 Thread dcheng
Title: [109280] trunk Revision 109280 Author dch...@chromium.org Date 2012-02-29 16:14:42 -0800 (Wed, 29 Feb 2012) Log Message [chromium] REGRESSION: Cannot drag a file out https://bugs.webkit.org/show_bug.cgi?id=79817 Reviewed by Ryosuke Niwa. Source/WebCore: Temporary fix for file

[webkit-changes] [109176] trunk

2012-02-28 Thread dcheng
Title: [109176] trunk Revision 109176 Author dch...@chromium.org Date 2012-02-28 17:31:55 -0800 (Tue, 28 Feb 2012) Log Message Clipboard::getData should return an empty string instead of undefined https://bugs.webkit.org/show_bug.cgi?id=79712 Reviewed by Tony Chang. Source/WebCore:

[webkit-changes] [109189] trunk/Source/WebKit/chromium

2012-02-28 Thread dcheng
://bugs.webkit.org/show_bug.cgi?id=79865 Fix the chromium build. (Requested by dcheng on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-28 * src/WebDragData.cpp: (WebKit::WebDragData::items): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src

[webkit-changes] [108554] trunk/Source/WebKit/chromium

2012-02-22 Thread dcheng
Title: [108554] trunk/Source/WebKit/chromium Revision 108554 Author dch...@chromium.org Date 2012-02-22 14:52:26 -0800 (Wed, 22 Feb 2012) Log Message [chromium] Cleanup unused WebDragData methods after r107846 https://bugs.webkit.org/show_bug.cgi?id=78837 Reviewed by Tony Chang. The

[webkit-changes] [108419] trunk

2012-02-21 Thread dcheng
Title: [108419] trunk Revision 108419 Author dch...@chromium.org Date 2012-02-21 16:47:28 -0800 (Tue, 21 Feb 2012) Log Message [chromium] Fix image drag out on Chromium https://bugs.webkit.org/show_bug.cgi?id=79158 Reviewed by Tony Chang. Source/WebKit/chromium: We constructed the

[webkit-changes] [107983] trunk/Source/WebKit/chromium

2012-02-16 Thread dcheng
Title: [107983] trunk/Source/WebKit/chromium Revision 107983 Author dch...@chromium.org Date 2012-02-16 14:54:43 -0800 (Thu, 16 Feb 2012) Log Message [chromium] Add WEBKIT_EXPORT to new WebDragData methods. https://bugs.webkit.org/show_bug.cgi?id=78843 Reviewed by Tony Chang. *

[webkit-changes] [107846] trunk/Source/WebKit/chromium

2012-02-15 Thread dcheng
Title: [107846] trunk/Source/WebKit/chromium Revision 107846 Author dch...@chromium.org Date 2012-02-15 15:14:24 -0800 (Wed, 15 Feb 2012) Log Message [chromium] Add setter/getter to expose drag data as a list of items https://bugs.webkit.org/show_bug.cgi?id=77125 This change supports

[webkit-changes] [106018] trunk/Source/WebCore

2012-01-26 Thread dcheng
Title: [106018] trunk/Source/WebCore Revision 106018 Author dch...@chromium.org Date 2012-01-26 11:23:42 -0800 (Thu, 26 Jan 2012) Log Message Revert code changes from r105800 https://bugs.webkit.org/show_bug.cgi?id=77071 The strings are already lowercased in

[webkit-changes] [105928] trunk/Source/WebCore

2012-01-25 Thread dcheng
Title: [105928] trunk/Source/WebCore Revision 105928 Author dch...@chromium.org Date 2012-01-25 14:33:33 -0800 (Wed, 25 Jan 2012) Log Message [chromium] Refactor Clipboard invalidate for DataTransferItem/DataTransferItemList into a wrapper https://bugs.webkit.org/show_bug.cgi?id=76993

[webkit-changes] [105962] trunk/Source

2012-01-25 Thread dcheng
Title: [105962] trunk/Source Revision 105962 Author dch...@chromium.org Date 2012-01-25 21:02:12 -0800 (Wed, 25 Jan 2012) Log Message [chromium] Fix ClipboardChromium::validateFilename to actually operate on extensions https://bugs.webkit.org/show_bug.cgi?id=76996 Source/WebCore: As it

[webkit-changes] [105800] trunk

2012-01-24 Thread dcheng
Title: [105800] trunk Revision 105800 Author dch...@chromium.org Date 2012-01-24 13:32:39 -0800 (Tue, 24 Jan 2012) Log Message dropzone does not normalize type strings https://bugs.webkit.org/show_bug.cgi?id=76925 Source/WebCore: Per the HTML spec, we are supposed to normalize types

[webkit-changes] [105825] trunk/Source/WebCore

2012-01-24 Thread dcheng
Title: [105825] trunk/Source/WebCore Revision 105825 Author dch...@chromium.org Date 2012-01-24 15:46:49 -0800 (Tue, 24 Jan 2012) Log Message Make DataTransferItemList::length() const. https://bugs.webkit.org/show_bug.cgi?id=76946 Just a const-correctness change. Reviewed by Tony

[webkit-changes] [105826] trunk

2012-01-24 Thread dcheng
Title: [105826] trunk Revision 105826 Author dch...@chromium.org Date 2012-01-24 15:48:23 -0800 (Tue, 24 Jan 2012) Log Message [chromium] event.dataTransfer.types should not return Text or URL https://bugs.webkit.org/show_bug.cgi?id=76218 Source/WebCore: Per the spec, Text and URL are

[webkit-changes] [105648] trunk/Source/WebCore

2012-01-23 Thread dcheng
Title: [105648] trunk/Source/WebCore Revision 105648 Author dch...@chromium.org Date 2012-01-23 15:35:44 -0800 (Mon, 23 Jan 2012) Log Message Convert DataTransferItem/DataTransferItemList back into an interface class https://bugs.webkit.org/show_bug.cgi?id=76856 When Qt implemented the

[webkit-changes] [104650] trunk/Source/WebKit/chromium

2012-01-10 Thread dcheng
Title: [104650] trunk/Source/WebKit/chromium Revision 104650 Author dch...@chromium.org Date 2012-01-10 16:39:01 -0800 (Tue, 10 Jan 2012) Log Message [chromium] Unreviewed, roll Chromium DEPS to r117121. * DEPS: Modified Paths trunk/Source/WebKit/chromium/ChangeLog

[webkit-changes] [104655] trunk

2012-01-10 Thread dcheng
Title: [104655] trunk Revision 104655 Author dch...@chromium.org Date 2012-01-10 17:19:14 -0800 (Tue, 10 Jan 2012) Log Message [chromium] Pasteboard::documentFragment should fall back to text if there's no HTML text https://bugs.webkit.org/show_bug.cgi?id=75923 Reviewed by Tony Chang.

[webkit-changes] [102610] trunk/Source/WebKit/chromium

2011-12-12 Thread dcheng
Title: [102610] trunk/Source/WebKit/chromium Revision 102610 Author dch...@chromium.org Date 2011-12-12 12:47:48 -0800 (Mon, 12 Dec 2011) Log Message [chromium] Remove BufferDrag from WebClipboard::Buffer enum. https://bugs.webkit.org/show_bug.cgi?id=74227 Reviewed by Tony Chang. This

[webkit-changes] [101828] trunk

2011-12-02 Thread dcheng
Title: [101828] trunk Revision 101828 Author dch...@chromium.org Date 2011-12-02 10:52:52 -0800 (Fri, 02 Dec 2011) Log Message [chromium] Add plumbing for supporting custom MIME types in DataTransfer. https://bugs.webkit.org/show_bug.cgi?id=73594 Reviewed by David Levin.

[webkit-changes] [101876] trunk

2011-12-02 Thread dcheng
. (Requested by dcheng on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-12-02 Source/WebCore: * editing/SpellChecker.cpp: (WebCore::SpellChecker::SpellChecker): (WebCore::SpellChecker::initRequest): (WebCore::SpellChecker::clearRequest): (WebCore::SpellChecker::canCheckAsynchronously

[webkit-changes] [101031] trunk/Source

2011-11-22 Thread dcheng
Title: [101031] trunk/Source Revision 101031 Author dch...@chromium.org Date 2011-11-22 16:39:29 -0800 (Tue, 22 Nov 2011) Log Message [chromium] Fix plumbing for differentiating between clipboard/selection pastes. https://bugs.webkit.org/show_bug.cgi?id=72056 Reviewed by

[webkit-changes] [101033] trunk/Source/WebCore/ChangeLog

2011-11-22 Thread dcheng
Title: [101033] trunk/Source/WebCore/ChangeLog Revision 101033 Author dch...@chromium.org Date 2011-11-22 16:44:43 -0800 (Tue, 22 Nov 2011) Log Message Unreviewed. Fix ChangeLog typo in r101031. Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified:

[webkit-changes] [100828] trunk

2011-11-18 Thread dcheng
Title: [100828] trunk Revision 100828 Author dch...@chromium.org Date 2011-11-18 16:46:42 -0800 (Fri, 18 Nov 2011) Log Message [chromium] Use correct backing store for ChromiumDataObject in pasteboard writes. https://bugs.webkit.org/show_bug.cgi?id=72767 Source/WebCore: Reviewed by

[webkit-changes] [99924] trunk/Source/WebCore

2011-11-10 Thread dcheng
Title: [99924] trunk/Source/WebCore Revision 99924 Author dch...@chromium.org Date 2011-11-10 20:12:14 -0800 (Thu, 10 Nov 2011) Log Message Atomically update the system clipboard for copy/cut events https://bugs.webkit.org/show_bug.cgi?id=40515 Reviewed by David Levin. This change

[webkit-changes] [99925] trunk/Source

2011-11-10 Thread dcheng
Title: [99925] trunk/Source Revision 99925 Author dch...@chromium.org Date 2011-11-10 20:13:25 -0800 (Thu, 10 Nov 2011) Log Message [chromium] Add plumbing for JS to write to clipboard in copy/cut events. https://bugs.webkit.org/show_bug.cgi?id=71414 Reviewed by Darin Fisher.

[webkit-changes] [99368] trunk

2011-11-05 Thread dcheng
Title: [99368] trunk Revision 99368 Author dch...@chromium.org Date 2011-11-05 21:14:58 -0700 (Sat, 05 Nov 2011) Log Message [chromium] Use the security origin instead of the URL when checking notification permissions https://bugs.webkit.org/show_bug.cgi?id=71590 Reviewed by Adam Barth.

[webkit-changes] [99237] trunk/Source

2011-11-03 Thread dcheng
Title: [99237] trunk/Source Revision 99237 Author dch...@chromium.org Date 2011-11-03 15:28:51 -0700 (Thu, 03 Nov 2011) Log Message [chromium] Remove unused clipboard methods https://bugs.webkit.org/show_bug.cgi?id=71512 Reviewed by Tony Chang. Source/WebCore: *

[webkit-changes] [98578] trunk/Source/WebCore

2011-10-27 Thread dcheng
Title: [98578] trunk/Source/WebCore Revision 98578 Author dch...@chromium.org Date 2011-10-27 08:14:55 -0700 (Thu, 27 Oct 2011) Log Message Clean up MicroDataItemValue to use const String instead of String https://bugs.webkit.org/show_bug.cgi?id=70978 Reviewed by Tony Chang. *

[webkit-changes] [98004] trunk/LayoutTests

2011-10-20 Thread dcheng
Title: [98004] trunk/LayoutTests Revision 98004 Author dch...@chromium.org Date 2011-10-20 11:25:21 -0700 (Thu, 20 Oct 2011) Log Message Update expectations after r97878. https://bugs.webkit.org/show_bug.cgi?id=70527 Reviewed by Tony Chang. *

[webkit-changes] [97878] trunk

2011-10-19 Thread dcheng
Title: [97878] trunk Revision 97878 Author dch...@chromium.org Date 2011-10-19 14:38:03 -0700 (Wed, 19 Oct 2011) Log Message Don't always select images during an image drag. https://bugs.webkit.org/show_bug.cgi?id=62998 Reviewed by Tony Chang. Source/WebCore: Only select an image

[webkit-changes] [97497] trunk/Source

2011-10-14 Thread dcheng
Title: [97497] trunk/Source Revision 97497 Author dch...@chromium.org Date 2011-10-14 12:55:59 -0700 (Fri, 14 Oct 2011) Log Message Context-aware HTML paste for Chromium https://bugs.webkit.org/show_bug.cgi?id=62112 Reviewed by Ryosuke Niwa. Source/WebCore: Add

[webkit-changes] [88704] trunk/Source/WebCore

2011-06-13 Thread dcheng
Title: [88704] trunk/Source/WebCore Revision 88704 Author dch...@chromium.org Date 2011-06-13 15:06:18 -0700 (Mon, 13 Jun 2011) Log Message 2011-06-13 Daniel Cheng dch...@chromium.org Reviewed by Eric Seidel. [chromium] Dragging images to Mail.app results in broken

[webkit-changes] [88249] trunk/LayoutTests

2011-06-07 Thread dcheng
Title: [88249] trunk/LayoutTests Revision 88249 Author dch...@chromium.org Date 2011-06-07 11:29:54 -0700 (Tue, 07 Jun 2011) Log Message 2011-06-07 Daniel Cheng dch...@chromium.org Reviewed by Tony Chang. [Chromium] REGRESSION

[webkit-changes] [88192] trunk/Source

2011-06-06 Thread dcheng
Title: [88192] trunk/Source Revision 88192 Author dch...@chromium.org Date 2011-06-06 14:52:46 -0700 (Mon, 06 Jun 2011) Log Message 2011-06-06 Daniel Cheng dch...@chromium.org Reviewed by Tony Chang. [chromium] Delete dead clipboard code.

[webkit-changes] [88117] branches/chromium/782

2011-06-04 Thread dcheng
Title: [88117] branches/chromium/782 Revision 88117 Author dch...@chromium.org Date 2011-06-04 10:45:42 -0700 (Sat, 04 Jun 2011) Log Message Merge 87848 - 2011-06-01 Daniel Cheng dch...@chromium.org Reviewed by Tony Chang. [chromium] Use correct file name for dragging

[webkit-changes] [87848] trunk

2011-06-01 Thread dcheng
Title: [87848] trunk Revision 87848 Author dch...@chromium.org Date 2011-06-01 14:13:06 -0700 (Wed, 01 Jun 2011) Log Message 2011-06-01 Daniel Cheng dch...@chromium.org Reviewed by Tony Chang. [chromium] Use correct file name for dragging out images.