[webkit-changes] [140642] trunk

2013-01-23 Thread macpherson
sts/ChangeLog 2013-01-24 04:44:10 UTC (rev 140642) @@ -1,3 +1,15 @@ +2013-01-23 Luke Macpherson macpher...@chromium.org + +Support variables inside -webkit-box-reflect CSS property. +https://bugs.webkit.org/show_bug.cgi?id=106856 + +Adds test for variables as -webkit-box-refl

[webkit-changes] [139808] trunk/Source/WebCore

2013-01-15 Thread macpherson
/css/StylePropertySet.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (139807 => 139808) --- trunk/Source/WebCore/ChangeLog 2013-01-16 00:14:57 UTC (rev 139807) +++ trunk/Source/WebCore/ChangeLog 2013-01-16 00:16:22 UTC (rev 139808) @@ -1,3 +1,17 @@ +2013-01-15 Luke Macpherson macp

[webkit-changes] [138685] trunk/LayoutTests

2013-01-02 Thread macpherson
-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (138684 => 138685) --- trunk/LayoutTests/ChangeLog 2013-01-03 01:10:24 UTC (rev 138684) +++ trunk/LayoutTests/ChangeLog 2013-01-03 01:11:01 UTC (rev 138685) @@ -1,3 +1,11 @@ +2013-01-02 Luke Macpherson macpher...@chromium.

[webkit-changes] [137984] trunk/Source/WebCore

2012-12-17 Thread macpherson
012-12-18 05:30:10 UTC (rev 137983) +++ trunk/Source/WebCore/ChangeLog 2012-12-18 05:35:34 UTC (rev 137984) @@ -1,3 +1,19 @@ +2012-12-17 Luke Macpherson macpher...@chromium.org + +Add ASSERTions to ensure that CSSPropertys that are variables only ever refer to CSSValues that are variab

[webkit-changes] [137569] trunk/Source/WebCore

2012-12-12 Thread macpherson
012-12-13 05:51:43 UTC (rev 137568) +++ trunk/Source/WebCore/ChangeLog 2012-12-13 06:15:10 UTC (rev 137569) @@ -1,3 +1,19 @@ +2012-12-12 Luke Macpherson macpher...@chromium.org + +Add ASSERTions to ensure that CSSPropertys that are variables only ever refer to CSSValues that are variab

[webkit-changes] [135760] trunk/Source/WebCore

2012-11-26 Thread macpherson
uke Macpherson macpher...@chromium.org + +Make StyleResolver::applyProperty use isInherit in CSSPropertyWebkitMarquee instead of calculating equivalent in-place. +https://bugs.webkit.org/show_bug.cgi?id=102446 + +Reviewed by Tony Chang. + +!m_parentNode || !va

[webkit-changes] [134846] trunk/Source/WebCore

2012-11-15 Thread macpherson
845) +++ trunk/Source/WebCore/ChangeLog 2012-11-16 00:13:29 UTC (rev 134846) @@ -1,3 +1,18 @@ +2012-11-15 Luke Macpherson macpher...@chromium.org + +Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty() +https://bugs.webkit.org/show_bug.cgi?id=101

[webkit-changes] [134861] trunk/Source/WebCore

2012-11-15 Thread macpherson
Diff Modified: trunk/Source/WebCore/ChangeLog (134860 => 134861) --- trunk/Source/WebCore/ChangeLog 2012-11-16 00:47:01 UTC (rev 134860) +++ trunk/Source/WebCore/ChangeLog 2012-11-16 00:49:03 UTC (rev 134861) @@ -1,3 +1,16 @@ +2012-11-15 Luke Macpherson macpher...@chromium.

[webkit-changes] [131968] trunk/Source/WebCore

2012-10-19 Thread macpherson
/Source/WebCore/css/StyleResolver.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (131967 => 131968) --- trunk/Source/WebCore/ChangeLog 2012-10-20 00:55:33 UTC (rev 131967) +++ trunk/Source/WebCore/ChangeLog 2012-10-20 01:02:34 UTC (rev 131968) @@ -1,3 +1,21 @@ +2012-10-19 Luke Macpher

[webkit-changes] [131677] trunk/Source/WebCore

2012-10-17 Thread macpherson
676) +++ trunk/Source/WebCore/ChangeLog 2012-10-18 00:18:16 UTC (rev 131677) @@ -1,3 +1,19 @@ +2012-10-17 Luke Macpherson macpher...@chromium.org + +Move handling of CSSPropertyWebkitLineClamp from StyleResolver into StyleBuilder. +https://bugs.webkit.org/show_bug.cgi?id=99

[webkit-changes] [131443] trunk/Source/WebCore

2012-10-16 Thread macpherson
ore/ChangeLog 2012-10-16 12:13:55 UTC (rev 131443) @@ -1,3 +1,19 @@ +2012-10-16 Luke Macpherson macpher...@chromium.org + +Handle CSSPropertyOpacity in StyleBuilder. +https://bugs.webkit.org/show_bug.cgi?id=99418 + +Reviewed by Alexis Menard. + +One small step in mov

[webkit-changes] [131313] trunk

2012-10-15 Thread macpherson
012-10-15 17:09:25 UTC (rev 131313) @@ -1,3 +1,15 @@ +2012-10-15 Luke Macpherson macpher...@chromium.org + +Make CSS variable names case-insensitive. +https://bugs.webkit.org/show_bug.cgi?id=98712 + +Reviewed by Tony Chang. + +Add test that variable names are ma

[webkit-changes] [129831] trunk/Source/WebCore

2012-09-27 Thread macpherson
ore/ChangeLog 2012-09-28 02:16:38 UTC (rev 129831) @@ -1,3 +1,25 @@ +2012-09-27 Luke Macpherson macpher...@chromium.org + +Implement reviewer feedback that I missed on bug 95930. +https://bugs.webkit.org/show_bug.cgi?id=97752 + +Reviewed by Alexey Proskurya

[webkit-changes] [129579] trunk

2012-09-25 Thread macpherson
579) @@ -1,3 +1,21 @@ +2012-09-25 Luke Macpherson macpher...@chromium.org + +Ensure variables are resolved for specialized CSS primitive value types. +https://bugs.webkit.org/show_bug.cgi?id=95930 + +Reviewed by Tony Chang. + +Add tests that use specialized CSS values

[webkit-changes] [129189] trunk

2012-09-20 Thread macpherson
: trunk/LayoutTests/ChangeLog (129188 => 129189) --- trunk/LayoutTests/ChangeLog 2012-09-21 04:00:21 UTC (rev 129188) +++ trunk/LayoutTests/ChangeLog 2012-09-21 04:15:18 UTC (rev 129189) @@ -1,3 +1,15 @@ +2012-09-20 Luke Macpherson macpher...@chromium.org + +Fix bug when using a varia

[webkit-changes] [127838] trunk/Source/WebCore

2012-09-07 Thread macpherson
-09-07 Luke Macpherson macpher...@chromium.org + +Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process. +https://bugs.webkit.org/show_bug.cgi?id=95938 + +Reviewed by Andreas Kling. + +Several unit types have been added with

[webkit-changes] [127220] trunk

2012-08-30 Thread macpherson
@ -1,3 +1,47 @@ +2012-08-30 Luke Macpherson macpher...@chromium.org + +Make it possible to use CSS Variables inside Calc expressions. +https://bugs.webkit.org/show_bug.cgi?id=95284 + +Reviewed by Tony Chang. + +Allows calc expressions to contain unevaluated v

[webkit-changes] [126828] trunk

2012-08-27 Thread macpherson
sts/ChangeLog 2012-08-28 00:45:43 UTC (rev 126828) @@ -1,3 +1,15 @@ +2012-08-27 Luke Macpherson macpher...@chromium.org + +Fix CSSParserValue::createCSSValue() for viewport based units. +https://bugs.webkit.org/show_bug.cgi?id=94772 + +Reviewed by Tony Chang. + +Add t

[webkit-changes] [126118] trunk

2012-08-20 Thread macpherson
UTC (rev 126118) @@ -1,3 +1,15 @@ +2012-08-20 Luke Macpherson macpher...@chromium.org + +Fix inspector with variables enabled and enable inspector variables tests by default. +https://bugs.webkit.org/show_bug.cgi?id=94296 + +Reviewed by Hajime Morita. + +Fix pa

[webkit-changes] [125243] trunk

2012-08-09 Thread macpherson
Log 2012-08-10 03:05:10 UTC (rev 125242) +++ trunk/LayoutTests/ChangeLog 2012-08-10 03:37:03 UTC (rev 125243) @@ -1,3 +1,15 @@ +2012-08-09 Luke Macpherson macpher...@chromium.org + +Fix null pointer deref in RenderFileUploadControl::computePreferredLogicalWidth(). +ht

[webkit-changes] [124833] trunk

2012-08-06 Thread macpherson
/ChangeLog (124832 => 124833) --- trunk/LayoutTests/ChangeLog 2012-08-07 01:46:25 UTC (rev 124832) +++ trunk/LayoutTests/ChangeLog 2012-08-07 01:57:28 UTC (rev 124833) @@ -1,3 +1,15 @@ +2012-08-06 Luke Macpherson macpher...@chromium.org + +Handle variables in CSSParser::parseValidPrimit

[webkit-changes] [124723] trunk

2012-08-05 Thread macpherson
sts/ChangeLog 2012-08-06 01:19:58 UTC (rev 124722) +++ trunk/LayoutTests/ChangeLog 2012-08-06 01:22:40 UTC (rev 124723) @@ -1,3 +1,15 @@ +2012-08-05 Luke Macpherson macpher...@chromium.org + +Fix null pointer dereference when CSSParser::sinkFloatingValueList() returns null and is pas

[webkit-changes] [124726] trunk/LayoutTests

2012-08-05 Thread macpherson
unk/LayoutTests/ChangeLog 2012-08-06 01:50:27 UTC (rev 124725) +++ trunk/LayoutTests/ChangeLog 2012-08-06 02:35:53 UTC (rev 124726) @@ -1,3 +1,14 @@ +2012-08-05 Luke Macpherson macpher...@chromium.org + +Enable fast/css/variables tests by default for chromium. +ht

[webkit-changes] [124258] trunk

2012-07-31 Thread macpherson
-image-load-from-variable.html Diff Modified: trunk/LayoutTests/ChangeLog (124257 => 124258) --- trunk/LayoutTests/ChangeLog 2012-07-31 22:34:18 UTC (rev 124257) +++ trunk/LayoutTests/ChangeLog 2012-07-31 22:36:20 UTC (rev 124258) @@ -1,3 +1,15 @@ +2012-07-31 Luke Macpherson macp

[webkit-changes] [123714] trunk

2012-07-26 Thread macpherson
ngeLog (123713 => 123714) --- trunk/Source/WebCore/ChangeLog 2012-07-26 08:11:37 UTC (rev 123713) +++ trunk/Source/WebCore/ChangeLog 2012-07-26 08:32:35 UTC (rev 123714) @@ -1,3 +1,17 @@ +2012-07-26 Luke Macpherson macpher...@chromium.org + +Fix null ptr deref in

[webkit-changes] [123176] trunk/Source/WebKit/chromium

2012-07-19 Thread macpherson
,15 @@ +2012-07-19 Luke Macpherson macpher...@chromium.org + +Enable CSS variables compile time flag in Chrome. +https://bugs.webkit.org/show_bug.cgi?id=91708 + +Reviewed by Dimitri Glazkov. + +Flips the ENABLE_CSS_VARIABLES compile flag on for Chrome. There is also a

[webkit-changes] [122923] trunk/Source/WebCore

2012-07-18 Thread macpherson
923) --- trunk/Source/WebCore/ChangeLog 2012-07-18 06:50:25 UTC (rev 122922) +++ trunk/Source/WebCore/ChangeLog 2012-07-18 07:09:21 UTC (rev 122923) @@ -1,3 +1,18 @@ +2012-07-18 Luke Macpherson macpher...@chromium.org + +Fix null pointer dereference introduced by Changeset 121

[webkit-changes] [122700] trunk/Source/WebCore

2012-07-16 Thread macpherson
-16 Luke Macpherson macpher...@chromium.org + +Compilation failure in StyleResolver.cpp (clang) +https://bugs.webkit.org/show_bug.cgi?id=89892 + +Reviewed by Ryosuke Niwa. + +Patch adds assertions that unreachable code is in fact not reached. + +Covered by fast/

[webkit-changes] [121874] trunk

2012-07-04 Thread macpherson
PASS Modified: trunk/Source/WebCore/ChangeLog (121873 => 121874) --- trunk/Source/WebCore/ChangeLog 2012-07-04 22:41:17 UTC (rev 121873) +++ trunk/Source/WebCore/ChangeLog 2012-07-05 00:15:54 UTC (rev 121874) @@ -1,3 +1,29 @@ +2012-07-04 Luke Macpherson macpher...@chromium.org + +Inspec

[webkit-changes] [121311] trunk

2012-06-26 Thread macpherson
01:49:20 UTC (rev 121310) +++ trunk/Source/WebCore/ChangeLog 2012-06-27 01:57:13 UTC (rev 121311) @@ -1,3 +1,15 @@ +2012-06-26 Luke Macpherson macpher...@chromium.org + +Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions. +

[webkit-changes] [121320] trunk/Source/WebCore

2012-06-26 Thread macpherson
Modified: trunk/Source/WebCore/ChangeLog (121319 => 121320) --- trunk/Source/WebCore/ChangeLog 2012-06-27 04:22:47 UTC (rev 121319) +++ trunk/Source/WebCore/ChangeLog 2012-06-27 05:40:18 UTC (rev 121320) @@ -1,3 +1,16 @@ +2012-06-26 Luke Macpherson macpher...@chromium.org + +Return corr

[webkit-changes] [121229] trunk

2012-06-25 Thread macpherson
2012-06-26 05:23:57 UTC (rev 121229) @@ -1,3 +1,29 @@ +2012-06-25 Luke Macpherson macpher...@chromium.org + +Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). +https://bugs.webkit.org/show_bug.cgi?id=89542 + +Reviewed by Dimitri

[webkit-changes] [121129] trunk

2012-06-24 Thread macpherson
121128) +++ trunk/Source/WebCore/ChangeLog 2012-06-25 02:03:45 UTC (rev 121129) @@ -1,3 +1,29 @@ +2012-06-24 Luke Macpherson macpher...@chromium.org + +Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag). +https://bugs.webkit.org/

[webkit-changes] [118885] trunk/Source/WebCore

2012-05-29 Thread macpherson
885) --- trunk/Source/WebCore/ChangeLog 2012-05-30 03:15:25 UTC (rev 118884) +++ trunk/Source/WebCore/ChangeLog 2012-05-30 03:30:23 UTC (rev 118885) @@ -1,3 +1,20 @@ +2012-05-29 Luke Macpherson macpher...@chromium.org + +Implement post-landing feedback for WebKitCSSTransformValue::customCSST

[webkit-changes] [118656] trunk/Tools

2012-05-28 Thread macpherson
rev 118656) @@ -1,3 +1,17 @@ +2012-05-28 Luke Macpherson macpher...@chromium.org + +Fix mac build with older XCode by defining NSEC_PER_MSEC. +https://bugs.webkit.org/show_bug.cgi?id=87616 + +Reviewed by Hajime Morita. + +The following patch introduced the

[webkit-changes] [118712] trunk/Source/WebCore

2012-05-28 Thread macpherson
/css/CSSProperty.h Diff Modified: trunk/Source/WebCore/ChangeLog (118711 => 118712) --- trunk/Source/WebCore/ChangeLog 2012-05-28 23:52:47 UTC (rev 118711) +++ trunk/Source/WebCore/ChangeLog 2012-05-28 23:56:36 UTC (rev 118712) @@ -1,3 +1,26 @@ +2012-05-28 Luke Macpherson macp

[webkit-changes] [118639] trunk/Source/WebCore

2012-05-27 Thread macpherson
-05-28 01:52:50 UTC (rev 118638) +++ trunk/Source/WebCore/ChangeLog 2012-05-28 01:53:17 UTC (rev 118639) @@ -1,3 +1,19 @@ +2012-05-27 Luke Macpherson macpher...@chromium.org + +Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables. +ht

[webkit-changes] [117791] trunk/LayoutTests

2012-05-21 Thread macpherson
-21 16:12:10 UTC (rev 117790) +++ trunk/LayoutTests/ChangeLog 2012-05-21 16:13:52 UTC (rev 117791) @@ -1,3 +1,15 @@ +2012-05-21 Luke Macpherson macpher...@chromium.org + +Add additional test cases for CSS variables. +https://bugs.webkit.org/show_bug.cgi?id=86987 + +Revie

[webkit-changes] [117390] trunk/LayoutTests

2012-05-16 Thread macpherson
/LayoutTests/fast/css/variables/variable-chain.html Diff Modified: trunk/LayoutTests/ChangeLog (117389 => 117390) --- trunk/LayoutTests/ChangeLog 2012-05-17 03:52:17 UTC (rev 117389) +++ trunk/LayoutTests/ChangeLog 2012-05-17 03:55:41 UTC (rev 117390) @@ -1,3 +1,46 @@ +2012-05-16 Luke Macpher

[webkit-changes] [117034] trunk/Source/WebCore

2012-05-15 Thread macpherson
UTC (rev 117033) +++ trunk/Source/WebCore/ChangeLog 2012-05-15 06:36:25 UTC (rev 117034) @@ -1,3 +1,20 @@ +2012-05-14 Luke Macpherson macpher...@chromium.org + +Make StyleResolver::applyMatchedProperties and ::applyProperties use enum template parameter instead of bool. +ht

[webkit-changes] [117028] trunk

2012-05-14 Thread macpherson
UTC (rev 117028) @@ -1,3 +1,14 @@ +2012-05-14 Luke Macpherson macpher...@chromium.org + +Introduce ENABLE_CSS_VARIABLES compile flag. +https://bugs.webkit.org/show_bug.cgi?id=86338 + +Reviewed by Dimitri Glazkov. + +Add a configuration option for CSS Variables supp

[webkit-changes] [115602] trunk/Source/WebCore

2012-04-29 Thread macpherson
rce/WebCore/ChangeLog 2012-04-30 01:22:08 UTC (rev 115601) +++ trunk/Source/WebCore/ChangeLog 2012-04-30 01:28:34 UTC (rev 115602) @@ -1,3 +1,22 @@ +2012-04-29 Luke Macpherson macpher...@chromium.org + +Initialize member variables in CSSParser's constructor. +https://bugs.webkit.

[webkit-changes] [114655] trunk/Source/WebCore

2012-04-19 Thread macpherson
/WebCore/css/CSSStyleSelector.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (114654 => 114655) --- trunk/Source/WebCore/ChangeLog 2012-04-19 18:18:01 UTC (rev 114654) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 18:20:08 UTC (rev 114655) @@ -1,3 +1,17 @@ +2012-04-19 Luke Macpher

[webkit-changes] [114669] trunk/Source/WebCore

2012-04-19 Thread macpherson
rce/WebCore/ChangeLog 2012-04-19 20:53:03 UTC (rev 114668) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:20:23 UTC (rev 114669) @@ -1,3 +1,15 @@ +2012-04-19 Luke Macpherson macpher...@chromium.org + +Initialize all member variables in CSSImageSetValue's copy constructor. +ht

[webkit-changes] [114670] trunk/Source/WebCore

2012-04-19 Thread macpherson
unk/Source/WebCore/ChangeLog 2012-04-19 21:20:23 UTC (rev 114669) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:22:29 UTC (rev 114670) @@ -1,5 +1,17 @@ 2012-04-19 Luke Macpherson macpher...@chromium.org +Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionVa

[webkit-changes] [114676] trunk/Source/WebCore

2012-04-19 Thread macpherson
unk/Source/WebCore/ChangeLog 2012-04-19 21:55:00 UTC (rev 114675) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 21:56:59 UTC (rev 114676) @@ -1,3 +1,15 @@ +2012-04-19 Luke Macpherson macpher...@chromium.org + +Clean up list iteration in MediaQueryExp constructor (avoid unnecessary ca

[webkit-changes] [114677] trunk

2012-04-19 Thread macpherson
UTC (rev 114676) +++ trunk/LayoutTests/ChangeLog 2012-04-19 22:00:09 UTC (rev 114677) @@ -1,3 +1,13 @@ +2012-04-19 Luke Macpherson macpher...@chromium.org + +Fix null-pointer dereference in ApplyPropertyZoom::applyValue(). +https://bugs.webkit.org/show_bug.cgi?id=84

[webkit-changes] [114678] trunk/Source/WebCore

2012-04-19 Thread macpherson
(114677 => 114678) --- trunk/Source/WebCore/ChangeLog 2012-04-19 22:00:09 UTC (rev 114677) +++ trunk/Source/WebCore/ChangeLog 2012-04-19 22:03:01 UTC (rev 114678) @@ -1,5 +1,17 @@ 2012-04-19 Luke Macpherson macpher...@chromium.org +Eliminate potential null pointer derefere

[webkit-changes] [114500] trunk/Source/WebCore

2012-04-18 Thread macpherson
/WebCore/ChangeLog (114499 => 114500) --- trunk/Source/WebCore/ChangeLog 2012-04-18 12:26:33 UTC (rev 114499) +++ trunk/Source/WebCore/ChangeLog 2012-04-18 13:02:41 UTC (rev 114500) @@ -1,3 +1,17 @@ +2012-04-18 Luke Macpherson macpher...@chromium.org + +Remove unnecessary varia

[webkit-changes] [114560] trunk/Source/WebCore

2012-04-18 Thread macpherson
560) --- trunk/Source/WebCore/ChangeLog 2012-04-18 21:04:43 UTC (rev 114559) +++ trunk/Source/WebCore/ChangeLog 2012-04-18 21:21:35 UTC (rev 114560) @@ -1,3 +1,15 @@ +2012-04-18 Luke Macpherson macpher...@chromium.org + +Prevent switch case fallthrough in StylePropertySet::getPropertyVa

[webkit-changes] [114566] trunk/Source/WebCore

2012-04-18 Thread macpherson
(114565 => 114566) --- trunk/Source/WebCore/ChangeLog 2012-04-18 21:45:54 UTC (rev 114565) +++ trunk/Source/WebCore/ChangeLog 2012-04-18 21:51:48 UTC (rev 114566) @@ -1,5 +1,17 @@ 2012-04-18 Luke Macpherson macpher...@chromium.org +Prevent potential null pointer derefere

[webkit-changes] [114444] trunk/Source/WebCore

2012-04-17 Thread macpherson
: trunk/Source/WebCore/ChangeLog (114443 => 11) --- trunk/Source/WebCore/ChangeLog 2012-04-17 22:15:54 UTC (rev 114443) +++ trunk/Source/WebCore/ChangeLog 2012-04-17 22:16:55 UTC (rev 11) @@ -1,3 +1,18 @@ +2012-04-17 Luke Macpherson macpher...@chromium.org + +Clean up CSSPar

[webkit-changes] [114455] trunk/Source/WebCore

2012-04-17 Thread macpherson
UTC (rev 114455) @@ -1,3 +1,18 @@ +2012-04-17 Luke Macpherson macpher...@chromium.org + +Make CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct. +https://bugs.webkit.org/show_bug.cgi?id=83544 + +Reviewed by Kentaro Hara. + +No new te

[webkit-changes] [114468] trunk/Source/WebCore

2012-04-17 Thread macpherson
rev 114467) +++ trunk/Source/WebCore/ChangeLog 2012-04-18 00:24:06 UTC (rev 114468) @@ -1,3 +1,15 @@ +2012-04-17 Luke Macpherson macpher...@chromium.org + +Ensure CSSParser member variables are initialized. +https://bugs.webkit.org/show_bug.cgi?id=84205 + +Reviewed by Andreas Kl

[webkit-changes] [113854] trunk/Source/WebCore

2012-04-11 Thread macpherson
012-04-11 13:23:36 UTC (rev 113853) +++ trunk/Source/WebCore/ChangeLog 2012-04-11 13:29:01 UTC (rev 113854) @@ -1,3 +1,15 @@ +2012-04-11 Luke Macpherson macpher...@chromium.org + +Remove unnecessary assignments from CSSParser::parseLinearGradient(). +https://bugs.webkit.org/show_bug.

[webkit-changes] [113737] trunk/Source/WebCore

2012-04-10 Thread macpherson
-04-10 18:10:45 UTC (rev 113737) @@ -1,3 +1,19 @@ +2012-04-10 Luke Macpherson macpher...@chromium.org + +Remove unnecessary null check in void SimplifyMarkupCommand::doApply(). +https://bugs.webkit.org/show_bug.cgi?id=83535 + +Reviewed by Kentaro Hara. + +No new te

[webkit-changes] [113748] trunk/Source/WebCore

2012-04-10 Thread macpherson
rce/WebCore/ChangeLog 2012-04-10 19:10:53 UTC (rev 113748) @@ -1,3 +1,17 @@ +2012-04-10 Luke Macpherson macpher...@chromium.org + +Don't allow fallthrough for CSSPropertyBaselineShift in CSSComputedStyleDeclaration::getSVGPropertyCSSValue(). +https://bugs.webkit.org/show_bug.cgi?id=83

[webkit-changes] [113752] trunk/Source/WebCore

2012-04-10 Thread macpherson
rev 113752) @@ -1,3 +1,19 @@ +2012-04-10 Luke Macpherson macpher...@chromium.org + +Pass FontDescription as const reference instead of by value in CSSStyleSelector.h. +https://bugs.webkit.org/show_bug.cgi?id=83548 + +Reviewed by Kentaro Hara. + +FontDescription is relativ

[webkit-changes] [113753] trunk/Source/WebCore

2012-04-10 Thread macpherson
rce/WebCore/ChangeLog 2012-04-10 19:31:04 UTC (rev 113752) +++ trunk/Source/WebCore/ChangeLog 2012-04-10 19:36:14 UTC (rev 113753) @@ -1,5 +1,17 @@ 2012-04-10 Luke Macpherson macpher...@chromium.org +Pass PropertyHandler by reference in CSSStyleApplyProperty.h. +https://bugs.webkit.

[webkit-changes] [113643] trunk/Source/WebCore

2012-04-09 Thread macpherson
/makevalues.pl Diff Modified: trunk/Source/WebCore/ChangeLog (113642 => 113643) --- trunk/Source/WebCore/ChangeLog 2012-04-09 23:54:12 UTC (rev 113642) +++ trunk/Source/WebCore/ChangeLog 2012-04-09 23:58:56 UTC (rev 113643) @@ -1,3 +1,17 @@ +2012-04-09 Luke Macpherson macpher...@chromium.

[webkit-changes] [113676] trunk/Source/WebCore

2012-04-09 Thread macpherson
=> 113676) --- trunk/Source/WebCore/ChangeLog 2012-04-10 04:42:20 UTC (rev 113675) +++ trunk/Source/WebCore/ChangeLog 2012-04-10 04:47:51 UTC (rev 113676) @@ -1,3 +1,19 @@ +2012-04-09 Luke Macpherson macpher...@chromium.org + +Don't let CSSPropertyWebkitPerspective derefere

[webkit-changes] [113273] trunk/Source/WebCore

2012-04-04 Thread macpherson
272) +++ trunk/Source/WebCore/ChangeLog 2012-04-05 01:42:05 UTC (rev 113273) @@ -1,3 +1,35 @@ +2012-04-04 Luke Macpherson macpher...@chromium.org + +Replace further usage of int with CSSPropertyID. +https://bugs.webkit.org/show_bug.cgi?id=83119 + +Reviewed by Simon Fra

[webkit-changes] [113139] trunk

2012-04-03 Thread macpherson
00:54 UTC (rev 113138) +++ trunk/Source/WebCore/ChangeLog 2012-04-04 05:05:37 UTC (rev 113139) @@ -1,3 +1,15 @@ +2012-04-03 Luke Macpherson macpher...@chromium.org + +Don't parse show and hide as valid values for display property. +https://bugs.webkit.org/show_bug.cgi

[webkit-changes] [112336] trunk/Source/WebCore

2012-03-27 Thread macpherson
-27 Luke Macpherson macpher...@chromium.org + +Add assertions to valueForLength() and RenderBox::computeLogicalWidthInRegionUsing() to help with debugging. +https://bugs.webkit.org/show_bug.cgi?id=82393 + +Reviewed by Eric Seidel. + +No new tests / adding assetions o

[webkit-changes] [111631] trunk/Source/WebCore

2012-03-21 Thread macpherson
/WebCore/ChangeLog (111630 => 111631) --- trunk/Source/WebCore/ChangeLog 2012-03-22 00:43:05 UTC (rev 111630) +++ trunk/Source/WebCore/ChangeLog 2012-03-22 00:58:36 UTC (rev 111631) @@ -1,3 +1,20 @@ +2012-03-21 Luke Macpherson macpher...@chromium.org + +Use CSSPrimitiveVa

[webkit-changes] [111371] trunk/Source/WebCore

2012-03-20 Thread macpherson
370) +++ trunk/Source/WebCore/ChangeLog 2012-03-20 08:32:11 UTC (rev 111371) @@ -1,3 +1,19 @@ +2012-03-20 Luke Macpherson macpher...@chromium.org + +Remove min and max parameters from CSSPrimitiveValue's roundForImpreciseConversion function. +https://bugs.webkit.org/show_bug.cgi

[webkit-changes] [111460] trunk/Source/WebCore

2012-03-20 Thread macpherson
/ChangeLog (111459 => 111460) --- trunk/Source/WebCore/ChangeLog 2012-03-20 23:15:11 UTC (rev 111459) +++ trunk/Source/WebCore/ChangeLog 2012-03-20 23:18:52 UTC (rev 111460) @@ -1,3 +1,15 @@ +2012-03-20 Luke Macpherson macpher...@chromium.org + +Use CSSPrimitiveValue::convertToLen

[webkit-changes] [111156] trunk

2012-03-19 Thread macpherson
-19 06:16:44 UTC (rev 55) +++ trunk/LayoutTests/ChangeLog 2012-03-19 06:37:54 UTC (rev 56) @@ -1,3 +1,13 @@ +2012-03-18 Luke Macpherson macpher...@chromium.org + +Remove remnants of code that assume Lengths are 28 bit integers. +https://bugs.webkit.org/show_bug.cgi?id=67

[webkit-changes] [110985] trunk/Source/WebCore

2012-03-16 Thread macpherson
:03:23 UTC (rev 110984) +++ trunk/Source/WebCore/ChangeLog 2012-03-16 11:25:54 UTC (rev 110985) @@ -1,3 +1,20 @@ +2012-03-16 Luke Macpherson macpher...@chromium.org + +Implement cast between CSSPrimitiveValue and LineClampValue. +https://bugs.webkit.org/show_bug.cgi?id=76

[webkit-changes] [110544] trunk/Source/WebCore

2012-03-13 Thread macpherson
uke Macpherson macpher...@chromium.org + +Implement CSSPropertyTextOverflow in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=80934 + +Reviewed by Andreas Kling. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.

[webkit-changes] [110662] trunk/Source/WebCore

2012-03-13 Thread macpherson
Diff Modified: trunk/Source/WebCore/ChangeLog (110661 => 110662) --- trunk/Source/WebCore/ChangeLog 2012-03-14 02:54:58 UTC (rev 110661) +++ trunk/Source/WebCore/ChangeLog 2012-03-14 03:19:02 UTC (rev 110662) @@ -1,3 +1,17 @@ +2012-03-13 Luke Macpherson macpher...@chromium.

[webkit-changes] [110484] trunk/Source/WebCore

2012-03-12 Thread macpherson
rce/WebCore/ChangeLog 2012-03-12 21:52:14 UTC (rev 110483) +++ trunk/Source/WebCore/ChangeLog 2012-03-12 21:54:35 UTC (rev 110484) @@ -1,3 +1,19 @@ +2012-03-12 Luke Macpherson macpher...@chromium.org + +Remove CSSStyleSelector's convertToLength method and use CSSPrimitiveValue's vers

[webkit-changes] [109964] trunk/Source/WebCore

2012-03-06 Thread macpherson
ore/ChangeLog 2012-03-06 22:52:33 UTC (rev 109963) +++ trunk/Source/WebCore/ChangeLog 2012-03-06 23:06:51 UTC (rev 109964) @@ -1,3 +1,19 @@ +2012-03-06 Luke Macpherson macpher...@chromium.org + +Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLen

[webkit-changes] [109699] trunk/Source/WebCore

2012-03-04 Thread macpherson
ore/ChangeLog 2012-03-05 03:38:58 UTC (rev 109699) @@ -1,3 +1,17 @@ +2012-03-04 Luke Macpherson macpher...@chromium.org + +Handle CSSPropertyWebkitColumnBreakAfter, CSSPropertyWebkitColumnBreakBefore and CSSPropertyWebkitColumnBreakInside in CSSStyleApplyProperty. +https://bugs.webkit.

[webkit-changes] [109706] trunk/Source/WebCore

2012-03-04 Thread macpherson
06:52:44 UTC (rev 109705) +++ trunk/Source/WebCore/ChangeLog 2012-03-05 06:57:40 UTC (rev 109706) @@ -1,3 +1,15 @@ +2012-03-04 Luke Macpherson macpher...@chromium.org + +Remove unused macro HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE_WITH_VALUE. +https://bugs.webkit.org/show_bug.cgi

[webkit-changes] [109525] trunk/Source/WebCore

2012-03-02 Thread macpherson
-02 Luke Macpherson macpher...@chromium.org + +Handle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=80056 + +Reviewed by Eric Seidel. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.

[webkit-changes] [109530] trunk/Source/WebCore

2012-03-02 Thread macpherson
ore/ChangeLog 2012-03-02 09:22:37 UTC (rev 109530) @@ -1,3 +1,17 @@ +2012-03-02 Luke Macpherson macpher...@chromium.org + +Handle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and CSSPropertyWebkitRegionBreakInside in CSSStyleApplyProperty. +https://bugs.webkit.

[webkit-changes] [109331] trunk/Source/WebCore

2012-03-01 Thread macpherson
uke Macpherson macpher...@chromium.org + +Handle CSSPropertyWebkitHyphens in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=80004 + +Reviewed by Eric Seidel. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.cpp: +(WebC

[webkit-changes] [109450] trunk/Source/WebCore

2012-03-01 Thread macpherson
uke Macpherson macpher...@chromium.org + +Implement CSSPropertyImageRendering in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=79855 + +Reviewed by Eric Seidel. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.

[webkit-changes] [109472] trunk/Source/WebCore

2012-03-01 Thread macpherson
uke Macpherson macpher...@chromium.org + +Handle CSSPropertyBoxSizing in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=80001 + +Reviewed by Andreas Kling. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.cpp: +(WebC

[webkit-changes] [109488] trunk/Source/WebCore

2012-03-01 Thread macpherson
uke Macpherson macpher...@chromium.org + +Handle CSSPropertyWebkitBorderFit in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=79998 + +Reviewed by Andreas Kling. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.

[webkit-changes] [109279] trunk/Source/WebCore

2012-02-29 Thread macpherson
ore/ChangeLog 2012-02-29 23:59:59 UTC (rev 109278) +++ trunk/Source/WebCore/ChangeLog 2012-03-01 00:11:45 UTC (rev 109279) @@ -1,3 +1,15 @@ +2012-02-29 Luke Macpherson macpher...@chromium.org + +Clean up CSSPrimitiveValue::computeLengthDouble(). +https://bugs.webkit.org/show_bug.cgi

[webkit-changes] [109310] trunk/Source/WebCore

2012-02-29 Thread macpherson
uke Macpherson macpher...@chromium.org + +Handle CSSPropertyWebkitColumnAxis in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=79869 + +Reviewed by Eric Seidel. + +No new tests / refactoring only. + +* css/CSSStyleApplyProperty.

[webkit-changes] [109311] trunk/Source/WebCore

2012-02-29 Thread macpherson
Log 2012-03-01 06:22:39 UTC (rev 109311) @@ -1,5 +1,20 @@ 2012-02-29 Luke Macpherson macpher...@chromium.org +Handle CSSPropertySpeak in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=79879 + +Reviewed by Eric Seidel. + +No new tests / refactor

[webkit-changes] [108555] trunk/Source/WebCore

2012-02-22 Thread macpherson
UTC (rev 108554) +++ trunk/Source/WebCore/ChangeLog 2012-02-22 22:54:38 UTC (rev 108555) @@ -1,3 +1,18 @@ +2012-02-22 Luke Macpherson macpher...@chromium.org + +Re-implement many more HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macros in CSSStyleApplyProperty. +https://bugs.webkit.

[webkit-changes] [108410] trunk/Source/WebCore

2012-02-21 Thread macpherson
UTC (rev 108409) +++ trunk/Source/WebCore/ChangeLog 2012-02-22 00:03:28 UTC (rev 108410) @@ -1,3 +1,18 @@ +2012-02-21 Luke Macpherson macpher...@chromium.org + +Implement many instances of HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE in CSSStyleApplyProperty. +https://bugs.webkit.

[webkit-changes] [105678] trunk/Source/WebCore

2012-01-23 Thread macpherson
678) --- trunk/Source/WebCore/ChangeLog 2012-01-24 02:33:10 UTC (rev 105677) +++ trunk/Source/WebCore/ChangeLog 2012-01-24 02:36:19 UTC (rev 105678) @@ -1,3 +1,20 @@ +2012-01-23 Luke Macpherson macpher...@chromium.org + +Make zoom multiplier float instead of double to match RenderSt

[webkit-changes] [105682] trunk/Source/JavaScriptCore

2012-01-23 Thread macpherson
,17 @@ +2012-01-23 Luke Macpherson macpher...@chromium.org + +Unreviewed, rolling out r105676. +http://trac.webkit.org/changeset/105676 +https://bugs.webkit.org/show_bug.cgi?id=76665 + +Breaks build on max due to compile warnings. + +* runtime/JSObject.

[webkit-changes] [105693] trunk/Source/WebCore

2012-01-23 Thread macpherson
:44:22 UTC (rev 105693) @@ -1,3 +1,28 @@ +2012-01-23 Luke Macpherson macpher...@chromium.org + +Implement CSS clip property in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=74913 + +Reviewed by Andreas Kling. + +No new tests / refactoring o

[webkit-changes] [105033] trunk/Source/WebCore

2012-01-15 Thread macpherson
,37 @@ +2012-01-15 Luke Macpherson macpher...@chromium.org + +Remove external references to CSSPrimitiveValue::UnitTypes enum. +https://bugs.webkit.org/show_bug.cgi?id=76229 + +Reviewed by Darin Adler. + +No new tests / refactoring only. + +* css/CSSFontSelector.

[webkit-changes] [103208] trunk/Source/WebCore

2011-12-18 Thread macpherson
207) +++ trunk/Source/WebCore/ChangeLog 2011-12-19 03:01:29 UTC (rev 103208) @@ -1,3 +1,25 @@ +2011-12-18 Luke Macpherson macpher...@chromium.org + +Implement CSS font-size property in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=74368 + +Reviewed by Andreas Kl

[webkit-changes] [103209] trunk/Source/WebCore

2011-12-18 Thread macpherson
uke Macpherson macpher...@chromium.org +Separate box alignment and box pack values into separate enums. +https://bugs.webkit.org/show_bug.cgi?id=74580 + +Reviewed by Andreas Kling. + +No new tests / refactoring only. + +Separating these types cleans

[webkit-changes] [102989] trunk/Source/WebCore

2011-12-15 Thread macpherson
uke Macpherson macpher...@chromium.org + +Separate box alignment and box pack values into separate enums. +https://bugs.webkit.org/show_bug.cgi?id=74580 + +Reviewed by Darin Adler. + +No new tests / refactoring only. + +Separating these types cleans up the c

[webkit-changes] [102650] trunk/Source/WebCore

2011-12-12 Thread macpherson
unk/Source/WebCore/ChangeLog 2011-12-13 02:36:47 UTC (rev 102650) @@ -1,3 +1,19 @@ +2011-12-12 Luke Macpherson macpher...@chromium.org + +Implement CSS text-decoration property in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=74258 + +Reviewed by Andreas Kl

[webkit-changes] [102544] trunk/Source/WebCore

2011-12-11 Thread macpherson
ore/ChangeLog 2011-12-12 00:24:29 UTC (rev 102544) @@ -1,3 +1,19 @@ +2011-12-11 Luke Macpherson macpher...@chromium.org + +Implement CSS resize property in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=74162 + +Reviewed by Julien Chaffraix. + +No new te

[webkit-changes] [102552] trunk/Source/WebCore

2011-12-11 Thread macpherson
Diff Modified: trunk/Source/WebCore/ChangeLog (102551 => 102552) --- trunk/Source/WebCore/ChangeLog 2011-12-12 01:22:49 UTC (rev 102551) +++ trunk/Source/WebCore/ChangeLog 2011-12-12 02:24:28 UTC (rev 102552) @@ -1,3 +1,22 @@ +2011-12-11 Luke Macpherson macpher...@chromium.

[webkit-changes] [102557] trunk/Source/WebCore

2011-12-11 Thread macpherson
,17 @@ +2011-12-11 Luke Macpherson macpher...@chromium.org + +Implement webkit-line-grid and webkit-line-grid-snap CSS properties in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=74262 + +Reviewed by Andreas Kling. + +No new tests / refactoring o

[webkit-changes] [102311] trunk/Source/WebCore

2011-12-07 Thread macpherson
310) +++ trunk/Source/WebCore/ChangeLog 2011-12-08 05:08:32 UTC (rev 102311) @@ -1,3 +1,19 @@ +2011-12-07 Luke Macpherson macpher...@chromium.org + +Implement border image source properties in CSSStyleApplyProperty. +https://bugs.webkit.org/show_bug.cgi?id=73981 + +Revie

[webkit-changes] [102188] trunk/Source/WebCore

2011-12-06 Thread macpherson
Log 2011-12-06 23:49:19 UTC (rev 102187) +++ trunk/Source/WebCore/ChangeLog 2011-12-07 00:26:59 UTC (rev 102188) @@ -1,3 +1,24 @@ +2011-12-06 Luke Macpherson macpher...@chromium.org + +Implement remaining border-image and webkit-maskbox-image properties in CSSStyleApplyProperty. +ht

[webkit-changes] [101499] trunk/Source/WebCore

2011-11-30 Thread macpherson
rce/WebCore/ChangeLog 2011-11-30 13:46:21 UTC (rev 101498) +++ trunk/Source/WebCore/ChangeLog 2011-11-30 13:48:25 UTC (rev 101499) @@ -1,3 +1,27 @@ +2011-11-30 Luke Macpherson macpher...@chromium.org + +Implement Zoom Property in CtyleApplyProperty. +https://bugs.webkit.

  1   2   >