Title: [100192] trunk/Tools
- Revision
- 100192
- Author
- commit-qu...@webkit.org
- Date
- 2011-11-14 14:29:04 -0800 (Mon, 14 Nov 2011)
Log Message
new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
Override LOCALE to en_US.
Patch by John Yani <van...@gmail.com> on 2011-11-14
Reviewed by Eric Seidel.
* Scripts/webkitpy/layout_tests/port/base.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (100191 => 100192)
--- trunk/Tools/ChangeLog 2011-11-14 22:25:51 UTC (rev 100191)
+++ trunk/Tools/ChangeLog 2011-11-14 22:29:04 UTC (rev 100192)
@@ -1,3 +1,12 @@
+2011-11-14 John Yani <van...@gmail.com>
+
+ new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
+ Override LOCALE to en_US.
+
+ Reviewed by Eric Seidel.
+
+ * Scripts/webkitpy/layout_tests/port/base.py:
+
2011-11-14 Julien Chaffraix <jchaffr...@webkit.org>
[Chromium] build-webkit silently drops the features flags
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (100191 => 100192)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-11-14 22:25:51 UTC (rev 100191)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-11-14 22:29:04 UTC (rev 100192)
@@ -654,7 +654,13 @@
Returns:
Operating-system's environment.
"""
- return os.environ.copy()
+ env = os.environ.copy()
+ # FIXME: This is a hack. Tests shouldn't be locale dependent.
+ # This works only in unix environments.
+ env['LANGUAGE'] = 'en'
+ env['LC_MESSAGES'] = 'en_US.utf8'
+ env['LANG'] = 'en_US.UTF-8'
+ return env
def show_results_html_file(self, results_filename):
"""This routine should display the HTML file pointed at by
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py (100191 => 100192)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py 2011-11-14 22:25:51 UTC (rev 100191)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py 2011-11-14 22:29:04 UTC (rev 100192)
@@ -194,6 +194,13 @@
# This routine is a no-op. We just test it for coverage.
port.setup_test_run()
+ def test_setup_environ_for_server(self):
+ port = self.make_port()
+ env = port.setup_environ_for_server()
+ self.assertEquals(env['LANGUAGE'], 'en')
+ self.assertEquals(env['LC_MESSAGES'], 'en_US.utf8')
+ self.assertEquals(env['LANG'], 'en_US.UTF-8')
+
def test_test_dirs(self):
filesystem = MockFileSystem({
'/mock-checkout/LayoutTests/canvas/test': '',
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
