Title: [100631] trunk/Source/WebKit/gtk
Revision
100631
Author
ma...@webkit.org
Date
2011-11-17 08:45:19 -0800 (Thu, 17 Nov 2011)

Log Message

[Gtk] Ensure the parent for the webView's a11y object is set.

This should fix some accessibility related GTK API tests.

Rubber-stamped by Philippe Normand.

* webkit/webkitwebview.cpp:
(webkit_web_view_get_accessible): Always set the parent to make
navigation across GTK and WebKit worlds work properly.

Modified Paths

Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (100630 => 100631)


--- trunk/Source/WebKit/gtk/ChangeLog	2011-11-17 16:43:06 UTC (rev 100630)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-11-17 16:45:19 UTC (rev 100631)
@@ -1,5 +1,17 @@
 2011-11-17  Mario Sanchez Prada  <msanc...@igalia.com>
 
+        [Gtk] Ensure the parent for the webView's a11y object is set.
+
+        This should fix some accessibility related GTK API tests.
+
+        Rubber-stamped by Philippe Normand.
+
+        * webkit/webkitwebview.cpp:
+        (webkit_web_view_get_accessible): Always set the parent to make
+        navigation across GTK and WebKit worlds work properly.
+
+2011-11-17  Mario Sanchez Prada  <msanc...@igalia.com>
+
         [GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set
         https://bugs.webkit.org/show_bug.cgi?id=72525
 

Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (100630 => 100631)


--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp	2011-11-17 16:43:06 UTC (rev 100630)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp	2011-11-17 16:45:19 UTC (rev 100631)
@@ -1327,6 +1327,12 @@
     if (!axRoot || !ATK_IS_OBJECT(axRoot))
         return 0;
 
+    // Ensure the parent is set to make top-down and bottom-up navigation work.
+    GtkWidget* parentWidget = gtk_widget_get_parent(widget);
+    AtkObject* axParent = parentWidget ? gtk_widget_get_accessible(parentWidget) : 0;
+    if (axParent)
+        atk_object_set_parent(axRoot, axParent);
+
     return axRoot;
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to