Title: [103038] trunk/Tools
Revision
103038
Author
mrobin...@webkit.org
Date
2011-12-16 00:18:33 -0800 (Fri, 16 Dec 2011)

Log Message

[GTK] Make distcheck fails during the install
https://bugs.webkit.org/show_bug.cgi?id=74274

No review, since this is a build fix.

* GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
always runs. This means that the gtkdoc step was always running when make was
invoked. Generating gtkdoc during 'make install' was triggering a race condition
with the library file. Later we can fix generate-forwarding-headers and unbreak
'make docs,' but this bandaid is sufficient to let us release.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (103037 => 103038)


--- trunk/Tools/ChangeLog	2011-12-16 08:18:24 UTC (rev 103037)
+++ trunk/Tools/ChangeLog	2011-12-16 08:18:33 UTC (rev 103038)
@@ -1,3 +1,17 @@
+2011-12-16  Martin Robinson  <mrobin...@igalia.com>
+
+        [GTK] Make distcheck fails during the install
+        https://bugs.webkit.org/show_bug.cgi?id=74274
+
+        No review, since this is a build fix.
+
+        * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
+        step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
+        always runs. This means that the gtkdoc step was always running when make was
+        invoked. Generating gtkdoc during 'make install' was triggering a race condition
+        with the library file. Later we can fix generate-forwarding-headers and unbreak
+        'make docs,' but this bandaid is sufficient to let us release.
+
 2011-12-15  Eric Seidel  <e...@webkit.org>
 
         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)

Modified: trunk/Tools/GNUmakefile.am (103037 => 103038)


--- trunk/Tools/GNUmakefile.am	2011-12-16 08:18:24 UTC (rev 103037)
+++ trunk/Tools/GNUmakefile.am	2011-12-16 08:18:33 UTC (rev 103038)
@@ -242,7 +242,6 @@
 
 if ENABLE_WEBKIT2
 docs-build.stamp: \
-	$(BUILT_SOURCES) \
 	Source/WebKit/gtk/docs/webkitenvironment.xml \
 	Source/WebKit/gtk/docs/webkitgtk-docs.sgml \
 	Source/WebKit/gtk/docs/webkitgtk-sections.txt \
@@ -254,7 +253,6 @@
 	@touch docs-build.stamp
 else
 docs-build.stamp: \
-	$(BUILT_SOURCES) \
 	libwebkitgtk-@WEBKITGTK_API_MAJOR_VERSION@.@WEBKITGTK_API_MINOR_VERSION@.la \
 	Source/WebKit/gtk/docs/webkitenvironment.xml \
 	Source/WebKit/gtk/docs/webkitgtk-docs.sgml \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to