Diff
Modified: trunk/Source/WebCore/ChangeLog (103118 => 103119)
--- trunk/Source/WebCore/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebCore/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,22 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ Renamed registerCommandForUndo and registerCommandForRedo to
+ registerUndoStep and registerRedoStep respectively.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::appliedEditing):
+ (WebCore::Editor::unappliedEditing):
+ (WebCore::Editor::reappliedEditing):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyEditorClient::registerUndoStep):
+ (WebCore::EmptyEditorClient::registerRedoStep):
+ * page/EditorClient.h:
+
2011-12-16 Tim Horton <timothy_hor...@apple.com>
Canvas should respect backing store scale ratio when used as drawImage() source
Modified: trunk/Source/WebCore/editing/Editor.cpp (103118 => 103119)
--- trunk/Source/WebCore/editing/Editor.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebCore/editing/Editor.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -889,7 +889,7 @@
// different from the last command
m_lastEditCommand = cmd;
if (client())
- client()->registerCommandForUndo(toCompositeEditCommand(m_lastEditCommand.get())->ensureComposition());
+ client()->registerUndoStep(m_lastEditCommand->ensureComposition());
}
respondToChangedContents(newSelection);
@@ -907,7 +907,7 @@
m_lastEditCommand = 0;
if (client())
- client()->registerCommandForRedo(cmd);
+ client()->registerRedoStep(cmd);
respondToChangedContents(newSelection);
}
@@ -922,7 +922,7 @@
m_lastEditCommand = 0;
if (client())
- client()->registerCommandForUndo(cmd);
+ client()->registerUndoStep(cmd);
respondToChangedContents(newSelection);
}
Modified: trunk/Source/WebCore/loader/EmptyClients.h (103118 => 103119)
--- trunk/Source/WebCore/loader/EmptyClients.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -459,8 +459,8 @@
virtual void didWriteSelectionToPasteboard() { }
virtual void didSetSelectionTypesForPasteboard() { }
- virtual void registerCommandForUndo(PassRefPtr<UndoStep>) { }
- virtual void registerCommandForRedo(PassRefPtr<UndoStep>) { }
+ virtual void registerUndoStep(PassRefPtr<UndoStep>) { }
+ virtual void registerRedoStep(PassRefPtr<UndoStep>) { }
virtual void clearUndoRedoOperations() { }
virtual bool canCopyCut(Frame*, bool defaultValue) const { return defaultValue; }
Modified: trunk/Source/WebCore/page/EditorClient.h (103118 => 103119)
--- trunk/Source/WebCore/page/EditorClient.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebCore/page/EditorClient.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -99,8 +99,8 @@
virtual void didWriteSelectionToPasteboard() = 0;
virtual void didSetSelectionTypesForPasteboard() = 0;
- virtual void registerCommandForUndo(PassRefPtr<UndoStep>) = 0;
- virtual void registerCommandForRedo(PassRefPtr<UndoStep>) = 0;
+ virtual void registerUndoStep(PassRefPtr<UndoStep>) = 0;
+ virtual void registerRedoStep(PassRefPtr<UndoStep>) = 0;
virtual void clearUndoRedoOperations() = 0;
virtual bool canCopyCut(Frame*, bool defaultValue) const = 0;
Modified: trunk/Source/WebKit/chromium/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * src/EditorClientImpl.cpp:
+ (WebKit::EditorClientImpl::registerUndoStep):
+ (WebKit::EditorClientImpl::registerRedoStep):
+ * src/EditorClientImpl.h:
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp (103118 => 103119)
--- trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/chromium/src/EditorClientImpl.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -288,7 +288,7 @@
{
}
-void EditorClientImpl::registerCommandForUndo(PassRefPtr<UndoStep> step)
+void EditorClientImpl::registerUndoStep(PassRefPtr<UndoStep> step)
{
if (m_undoStack.size() == maximumUndoStackDepth)
m_undoStack.removeFirst(); // drop oldest item off the far end
@@ -297,7 +297,7 @@
m_undoStack.append(step);
}
-void EditorClientImpl::registerCommandForRedo(PassRefPtr<UndoStep> step)
+void EditorClientImpl::registerRedoStep(PassRefPtr<UndoStep> step)
{
m_redoStack.append(step);
}
Modified: trunk/Source/WebKit/chromium/src/EditorClientImpl.h (103118 => 103119)
--- trunk/Source/WebKit/chromium/src/EditorClientImpl.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/chromium/src/EditorClientImpl.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -75,8 +75,8 @@
virtual void didEndEditing();
virtual void didWriteSelectionToPasteboard();
virtual void didSetSelectionTypesForPasteboard();
- virtual void registerCommandForUndo(PassRefPtr<WebCore::UndoStep>);
- virtual void registerCommandForRedo(PassRefPtr<WebCore::UndoStep>);
+ virtual void registerUndoStep(PassRefPtr<WebCore::UndoStep>);
+ virtual void registerRedoStep(PassRefPtr<WebCore::UndoStep>);
virtual void clearUndoRedoOperations();
virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
virtual bool canPaste(WebCore::Frame*, bool defaultValue) const;
Modified: trunk/Source/WebKit/efl/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/efl/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebCoreSupport/EditorClientEfl.cpp:
+ (WebCore::EditorClientEfl::registerUndoStep):
+ (WebCore::EditorClientEfl::registerRedoStep):
+ * WebCoreSupport/EditorClientEfl.h:
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (103118 => 103119)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -160,14 +160,14 @@
notImplemented();
}
-void EditorClientEfl::registerCommandForUndo(WTF::PassRefPtr<UndoStep> step)
+void EditorClientEfl::registerUndoStep(WTF::PassRefPtr<UndoStep> step)
{
if (!m_isInRedo)
redoStack.clear();
undoStack.prepend(step);
}
-void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtr<UndoStep> step)
+void EditorClientEfl::registerRedoStep(WTF::PassRefPtr<UndoStep> step)
{
redoStack.prepend(step);
}
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h (103118 => 103119)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -84,8 +84,8 @@
virtual void didWriteSelectionToPasteboard();
virtual void didSetSelectionTypesForPasteboard();
- virtual void registerCommandForUndo(WTF::PassRefPtr<UndoStep>);
- virtual void registerCommandForRedo(WTF::PassRefPtr<UndoStep>);
+ virtual void registerUndoStep(WTF::PassRefPtr<UndoStep>);
+ virtual void registerRedoStep(WTF::PassRefPtr<UndoStep>);
virtual void clearUndoRedoOperations();
virtual bool canCopyCut(Frame*, bool defaultValue) const;
Modified: trunk/Source/WebKit/gtk/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebCoreSupport/EditorClientGtk.cpp:
+ (WebKit::EditorClient::registerUndoStep):
+ (WebKit::EditorClient::registerRedoStep):
+ * WebCoreSupport/EditorClientGtk.h:
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp (103118 => 103119)
--- trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -345,7 +345,7 @@
notImplemented();
}
-void EditorClient::registerCommandForUndo(WTF::PassRefPtr<WebCore::UndoStep> step)
+void EditorClient::registerUndoStep(WTF::PassRefPtr<WebCore::UndoStep> step)
{
if (undoStack.size() == maximumUndoStackDepth)
undoStack.removeFirst();
@@ -354,7 +354,7 @@
undoStack.append(step);
}
-void EditorClient::registerCommandForRedo(WTF::PassRefPtr<WebCore::UndoStep> step)
+void EditorClient::registerRedoStep(WTF::PassRefPtr<WebCore::UndoStep> step)
{
redoStack.append(step);
}
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h (103118 => 103119)
--- trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -105,8 +105,8 @@
virtual void didWriteSelectionToPasteboard();
virtual void didSetSelectionTypesForPasteboard();
- virtual void registerCommandForUndo(WTF::PassRefPtr<WebCore::UndoStep>);
- virtual void registerCommandForRedo(WTF::PassRefPtr<WebCore::UndoStep>);
+ virtual void registerUndoStep(WTF::PassRefPtr<WebCore::UndoStep>);
+ virtual void registerRedoStep(WTF::PassRefPtr<WebCore::UndoStep>);
virtual void clearUndoRedoOperations();
virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
Modified: trunk/Source/WebKit/mac/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/mac/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,16 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebCoreSupport/WebEditorClient.h:
+ * WebCoreSupport/WebEditorClient.mm:
+ (WebEditorClient::registerUndoOrRedoStep):
+ (WebEditorClient::registerUndoStep):
+ (WebEditorClient::registerRedoStep):
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h (103118 => 103119)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -100,8 +100,8 @@
virtual void respondToChangedContents() OVERRIDE;
virtual void respondToChangedSelection(WebCore::Frame*) OVERRIDE;
- virtual void registerCommandForUndo(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
- virtual void registerCommandForRedo(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
+ virtual void registerUndoStep(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
+ virtual void registerRedoStep(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
virtual void clearUndoRedoOperations() OVERRIDE;
virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const OVERRIDE;
@@ -143,7 +143,7 @@
virtual void recordAutocorrectionResponse(AutocorrectionResponseType, const String& replacedString, const String& replacementString) OVERRIDE;
#endif
private:
- void registerCommandForUndoOrRedo(PassRefPtr<WebCore::UndoStep>, bool isRedo);
+ void registerUndoOrRedoStep(PassRefPtr<WebCore::UndoStep>, bool isRedo);
WebEditorClient();
WebView *m_webView;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm (103118 => 103119)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2011-12-16 23:34:39 UTC (rev 103119)
@@ -512,7 +512,7 @@
return nil;
}
-void WebEditorClient::registerCommandForUndoOrRedo(PassRefPtr<UndoStep> step, bool isRedo)
+void WebEditorClient::registerUndoOrRedoStep(PassRefPtr<UndoStep> step, bool isRedo)
{
ASSERT(step);
@@ -525,14 +525,14 @@
m_haveUndoRedoOperations = YES;
}
-void WebEditorClient::registerCommandForUndo(PassRefPtr<UndoStep> cmd)
+void WebEditorClient::registerUndoStep(PassRefPtr<UndoStep> cmd)
{
- registerCommandForUndoOrRedo(cmd, false);
+ registerUndoOrRedoStep(cmd, false);
}
-void WebEditorClient::registerCommandForRedo(PassRefPtr<UndoStep> cmd)
+void WebEditorClient::registerRedoStep(PassRefPtr<UndoStep> cmd)
{
- registerCommandForUndoOrRedo(cmd, true);
+ registerUndoOrRedoStep(cmd, true);
}
void WebEditorClient::clearUndoRedoOperations()
Modified: trunk/Source/WebKit/qt/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/qt/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebCoreSupport/EditorClientQt.cpp:
+ (WebCore::EditorClientQt::registerUndoStep):
+ (WebCore::EditorClientQt::registerRedoStep):
+ * WebCoreSupport/EditorClientQt.h:
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp (103118 => 103119)
--- trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -237,7 +237,7 @@
return false;
}
-void EditorClientQt::registerCommandForUndo(WTF::PassRefPtr<WebCore::UndoStep> step)
+void EditorClientQt::registerUndoStep(WTF::PassRefPtr<WebCore::UndoStep> step)
{
#ifndef QT_NO_UNDOSTACK
Frame* frame = m_page->d->page->focusController()->focusedOrMainFrame();
@@ -247,7 +247,7 @@
#endif // QT_NO_UNDOSTACK
}
-void EditorClientQt::registerCommandForRedo(WTF::PassRefPtr<WebCore::UndoStep>)
+void EditorClientQt::registerRedoStep(WTF::PassRefPtr<WebCore::UndoStep>)
{
}
Modified: trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h (103118 => 103119)
--- trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -74,8 +74,8 @@
virtual void didWriteSelectionToPasteboard();
virtual void didSetSelectionTypesForPasteboard();
- virtual void registerCommandForUndo(PassRefPtr<UndoStep>);
- virtual void registerCommandForRedo(PassRefPtr<UndoStep>);
+ virtual void registerUndoStep(PassRefPtr<UndoStep>);
+ virtual void registerRedoStep(PassRefPtr<UndoStep>);
virtual void clearUndoRedoOperations();
virtual bool canCopyCut(Frame*, bool defaultValue) const;
Modified: trunk/Source/WebKit/win/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/win/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/win/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebCoreSupport/WebEditorClient.cpp:
+ (WebEditorClient::registerUndoStep):
+ (WebEditorClient::registerRedoStep):
+ * WebCoreSupport/WebEditorClient.h:
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp (103118 => 103119)
--- trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -527,7 +527,7 @@
return String();
}
-void WebEditorClient::registerCommandForUndo(PassRefPtr<UndoStep> step)
+void WebEditorClient::registerUndoStep(PassRefPtr<UndoStep> step)
{
IWebUIDelegate* uiDelegate = 0;
if (SUCCEEDED(m_webView->uiDelegate(&uiDelegate))) {
@@ -543,7 +543,7 @@
}
}
-void WebEditorClient::registerCommandForRedo(PassRefPtr<UndoStep> step)
+void WebEditorClient::registerRedoStep(PassRefPtr<UndoStep> step)
{
IWebUIDelegate* uiDelegate = 0;
if (SUCCEEDED(m_webView->uiDelegate(&uiDelegate))) {
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h (103118 => 103119)
--- trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -74,8 +74,8 @@
bool smartInsertDeleteEnabled();
bool isSelectTrailingWhitespaceEnabled();
- void registerCommandForUndo(PassRefPtr<WebCore::UndoStep>);
- void registerCommandForRedo(PassRefPtr<WebCore::UndoStep>);
+ void registerUndoStep(PassRefPtr<WebCore::UndoStep>);
+ void registerRedoStep(PassRefPtr<WebCore::UndoStep>);
void clearUndoRedoOperations();
bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
Modified: trunk/Source/WebKit/wince/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/wince/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/wince/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebCoreSupport/EditorClientWinCE.cpp:
+ (WebKit::EditorClientWinCE::registerUndoStep):
+ (WebKit::EditorClientWinCE::registerRedoStep):
+ * WebCoreSupport/EditorClientWinCE.h:
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp (103118 => 103119)
--- trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -144,12 +144,12 @@
notImplemented();
}
-void EditorClientWinCE::registerCommandForUndo(WTF::PassRefPtr<WebCore::UndoStep>)
+void EditorClientWinCE::registerUndoStep(WTF::PassRefPtr<WebCore::UndoStep>)
{
notImplemented();
}
-void EditorClientWinCE::registerCommandForRedo(WTF::PassRefPtr<WebCore::UndoStep>)
+void EditorClientWinCE::registerRedoStep(WTF::PassRefPtr<WebCore::UndoStep>)
{
notImplemented();
}
Modified: trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h (103118 => 103119)
--- trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -65,8 +65,8 @@
virtual void didWriteSelectionToPasteboard();
virtual void didSetSelectionTypesForPasteboard();
- virtual void registerCommandForUndo(WTF::PassRefPtr<WebCore::UndoStep>);
- virtual void registerCommandForRedo(WTF::PassRefPtr<WebCore::UndoStep>);
+ virtual void registerUndoStep(WTF::PassRefPtr<WebCore::UndoStep>);
+ virtual void registerRedoStep(WTF::PassRefPtr<WebCore::UndoStep>);
virtual void clearUndoRedoOperations();
virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const;
Modified: trunk/Source/WebKit/wx/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit/wx/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/wx/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebKitSupport/EditorClientWx.cpp:
+ (WebCore::EditorClientWx::registerUndoStep):
+ (WebCore::EditorClientWx::registerRedoStep):
+ * WebKitSupport/EditorClientWx.h:
+
2011-12-16 Sam Weinig <s...@webkit.org>
Give PlatformEvents a base class
Modified: trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.cpp (103118 => 103119)
--- trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -276,7 +276,7 @@
notImplemented();
}
-void EditorClientWx::registerCommandForUndo(PassRefPtr<EditCommand> command)
+void EditorClientWx::registerUndoStep(PassRefPtr<EditCommand> command)
{
Frame* frame = m_page->focusController()->focusedOrMainFrame();
@@ -288,7 +288,7 @@
}
}
-void EditorClientWx::registerCommandForRedo(PassRefPtr<EditCommand> command)
+void EditorClientWx::registerRedoStep(PassRefPtr<EditCommand> command)
{
Frame* frame = m_page->focusController()->focusedOrMainFrame();
Modified: trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.h (103118 => 103119)
--- trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit/wx/WebKitSupport/EditorClientWx.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -77,8 +77,8 @@
virtual void didWriteSelectionToPasteboard();
virtual void didSetSelectionTypesForPasteboard();
- virtual void registerCommandForUndo(PassRefPtr<EditCommand>);
- virtual void registerCommandForRedo(PassRefPtr<EditCommand>);
+ virtual void registerUndoStep(PassRefPtr<EditCommand>);
+ virtual void registerRedoStep(PassRefPtr<EditCommand>);
virtual void clearUndoRedoOperations();
virtual bool canCopyCut(Frame*, bool defaultValue) const;
Modified: trunk/Source/WebKit2/ChangeLog (103118 => 103119)
--- trunk/Source/WebKit2/ChangeLog 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit2/ChangeLog 2011-12-16 23:34:39 UTC (rev 103119)
@@ -1,3 +1,15 @@
+2011-12-16 Ryosuke Niwa <rn...@webkit.org>
+
+ Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
+ https://bugs.webkit.org/show_bug.cgi?id=74748
+
+ Reviewed by Eric Seidel.
+
+ * WebProcess/WebCoreSupport/WebEditorClient.cpp:
+ (WebKit::WebEditorClient::registerUndoStep):
+ (WebKit::WebEditorClient::registerRedoStep):
+ * WebProcess/WebCoreSupport/WebEditorClient.h:
+
2011-12-16 Anders Carlsson <ander...@apple.com>
Add a pretty dumb tile cache to WebTileCacheLayer
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (103118 => 103119)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2011-12-16 23:34:39 UTC (rev 103119)
@@ -220,7 +220,7 @@
notImplemented();
}
-void WebEditorClient::registerCommandForUndo(PassRefPtr<UndoStep> step)
+void WebEditorClient::registerUndoStep(PassRefPtr<UndoStep> step)
{
// FIXME: Add assertion that the command being reapplied is the same command that is
// being passed to us.
@@ -234,7 +234,7 @@
m_page->send(Messages::WebPageProxy::RegisterEditCommandForUndo(webStep->stepID(), editAction));
}
-void WebEditorClient::registerCommandForRedo(PassRefPtr<UndoStep>)
+void WebEditorClient::registerRedoStep(PassRefPtr<UndoStep>)
{
}
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h (103118 => 103119)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2011-12-16 23:29:12 UTC (rev 103118)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2011-12-16 23:34:39 UTC (rev 103119)
@@ -69,8 +69,8 @@
virtual void didWriteSelectionToPasteboard() OVERRIDE;
virtual void didSetSelectionTypesForPasteboard() OVERRIDE;
- virtual void registerCommandForUndo(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
- virtual void registerCommandForRedo(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
+ virtual void registerUndoStep(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
+ virtual void registerRedoStep(PassRefPtr<WebCore::UndoStep>) OVERRIDE;
virtual void clearUndoRedoOperations() OVERRIDE;
virtual bool canCopyCut(WebCore::Frame*, bool defaultValue) const OVERRIDE;
