Title: [103121] trunk/Source
Revision
103121
Author
mhahnenb...@apple.com
Date
2011-12-16 15:43:40 -0800 (Fri, 16 Dec 2011)

Log Message

Windows test fix

Source/WebCore: 

No new tests.

Unreviewed test fix. All Windows tests were crashing when objects who were pointing to 
static data members across DLL boundaries were getting garbage in their pointers.

* WebCore.exp.in:
* bindings/js/JSDOMWrapper.cpp:
* bindings/js/JSDOMWrapper.h:

Source/WebKit2: 

Unreviewed test fix. All Windows tests were crashing when objects who were pointing to 
static data members across DLL boundaries were getting garbage in their pointers.

* win/WebKit2.def:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (103120 => 103121)


--- trunk/Source/WebCore/ChangeLog	2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/ChangeLog	2011-12-16 23:43:40 UTC (rev 103121)
@@ -1,3 +1,16 @@
+2011-12-16  Mark Hahnenberg  <mhahnenb...@apple.com>
+
+        Windows test fix
+
+        No new tests.
+
+        Unreviewed test fix. All Windows tests were crashing when objects who were pointing to 
+        static data members across DLL boundaries were getting garbage in their pointers.
+
+        * WebCore.exp.in:
+        * bindings/js/JSDOMWrapper.cpp:
+        * bindings/js/JSDOMWrapper.h:
+
 2011-12-16  Ryosuke Niwa  <rn...@webkit.org>
 
         Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step

Modified: trunk/Source/WebCore/WebCore.exp.in (103120 => 103121)


--- trunk/Source/WebCore/WebCore.exp.in	2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-12-16 23:43:40 UTC (rev 103121)
@@ -261,7 +261,6 @@
 __ZN7WebCore12IconDatabase5closeEv
 __ZN7WebCore12IconDatabase9setClientEPNS_18IconDatabaseClientE
 __ZN7WebCore12IconDatabaseC1Ev
-__ZN7WebCore12JSDOMWrapper6s_infoE
 __ZN7WebCore12PopupMenuMacC1EPNS_15PopupMenuClientE
 __ZN7WebCore12PrintContext12pagePropertyEPNS_5FrameEPKci
 __ZN7WebCore12PrintContext13numberOfPagesEPNS_5FrameERKNS_9FloatSizeE

Modified: trunk/Source/WebCore/bindings/js/JSDOMWrapper.cpp (103120 => 103121)


--- trunk/Source/WebCore/bindings/js/JSDOMWrapper.cpp	2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/bindings/js/JSDOMWrapper.cpp	2011-12-16 23:43:40 UTC (rev 103121)
@@ -34,6 +34,4 @@
 
 ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSDOMWrapper);
 
-const ClassInfo JSDOMWrapper::s_info = { "JSDOMWrapper", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSDOMWrapper) };
-
 } // namespace WebCore

Modified: trunk/Source/WebCore/bindings/js/JSDOMWrapper.h (103120 => 103121)


--- trunk/Source/WebCore/bindings/js/JSDOMWrapper.h	2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebCore/bindings/js/JSDOMWrapper.h	2011-12-16 23:43:40 UTC (rev 103121)
@@ -42,13 +42,6 @@
         return globalObject()->scriptExecutionContext();
     }
 
-    static const JSC::ClassInfo s_info;
-
-    static JSC::Structure* createStructure(JSC::JSGlobalData& globalData, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype)
-    {
-        return JSC::Structure::create(globalData, globalObject, prototype, JSC::TypeInfo(JSC::ObjectType, StructureFlags), &s_info);
-    }
-
 protected:
     explicit JSDOMWrapper(JSC::Structure* structure, JSC::JSGlobalObject* globalObject) 
         : JSNonFinalObject(globalObject->globalData(), structure)

Modified: trunk/Source/WebKit2/ChangeLog (103120 => 103121)


--- trunk/Source/WebKit2/ChangeLog	2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-16 23:43:40 UTC (rev 103121)
@@ -1,3 +1,12 @@
+2011-12-16  Mark Hahnenberg  <mhahnenb...@apple.com>
+
+        Windows test fix
+
+        Unreviewed test fix. All Windows tests were crashing when objects who were pointing to 
+        static data members across DLL boundaries were getting garbage in their pointers.
+
+        * win/WebKit2.def:
+
 2011-12-16  Ryosuke Niwa  <rn...@webkit.org>
 
         Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step

Modified: trunk/Source/WebKit2/win/WebKit2.def (103120 => 103121)


--- trunk/Source/WebKit2/win/WebKit2.def	2011-12-16 23:36:10 UTC (rev 103120)
+++ trunk/Source/WebKit2/win/WebKit2.def	2011-12-16 23:43:40 UTC (rev 103121)
@@ -168,7 +168,6 @@
         ?paintControlTints@FrameView@WebCore@@AAEXXZ
         ?rangeFromLocationAndLength@TextIterator@WebCore@@SA?AV?$PassRefPtr@VRange@WebCore@@@WTF@@PAVElement@2@HH_N@Z
         ?removeShadowRoot@Element@WebCore@@QAEXXZ
-        ?s_info@JSDOMWrapper@WebCore@@2UClassInfo@JSC@@B
         ?scriptExecutionContext@JSDOMGlobalObject@WebCore@@QBEPAVScriptExecutionContext@2@XZ
         ?scrollElementToRect@FrameView@WebCore@@QAEXPAVElement@2@ABVIntRect@2@@Z
         ?setShouldLayoutFixedElementsRelativeToFrame@FrameView@WebCore@@QAEX_N@Z
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to