Title: [106359] trunk/Tools
- Revision
- 106359
- Author
- aro...@apple.com
- Date
- 2012-01-31 07:09:33 -0800 (Tue, 31 Jan 2012)
Log Message
Only call -typingAttributes on WebViews, not WebHTMLViews
Looks like this case was just missed in r105908.
Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
Reviewed by Antti Koivisto.
* TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
earlier.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (106358 => 106359)
--- trunk/Tools/ChangeLog 2012-01-31 14:58:37 UTC (rev 106358)
+++ trunk/Tools/ChangeLog 2012-01-31 15:09:33 UTC (rev 106359)
@@ -1,3 +1,17 @@
+2012-01-31 Adam Roben <aro...@apple.com>
+
+ Only call -typingAttributes on WebViews, not WebHTMLViews
+
+ Looks like this case was just missed in r105908.
+
+ Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
+
+ Reviewed by Antti Koivisto.
+
+ * TestWebKitAPI/Tests/mac/InspectorBar.mm:
+ (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
+ earlier.
+
2012-01-31 Jocelyn Turcotte <jocelyn.turco...@nokia.com>
[Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm (106358 => 106359)
--- trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm 2012-01-31 14:58:37 UTC (rev 106358)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm 2012-01-31 15:09:33 UTC (rev 106359)
@@ -66,7 +66,7 @@
EXPECT_TRUE([webView.get() respondsToSelector:@selector(typingAttributes)]);
NSDictionary *attributes = [(id)webView.get() typingAttributes];
[(id)[[[webView.get() mainFrame] frameView] documentView] doCommandBySelector:@selector(bold:)];
- EXPECT_FALSE([attributes isEqual:[(id)[[[webView.get() mainFrame] frameView] documentView] typingAttributes]]);
+ EXPECT_FALSE([attributes isEqual:[(id)webView.get() typingAttributes]]);
[webView.get() selectAll:nil];
NSAttributedString *attrString = [(NSView <NSTextInput> *)[[[webView.get() mainFrame] frameView] documentView] attributedSubstringFromRange:NSMakeRange(0, 5)];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
