Title: [106395] trunk/Source/WebKit/chromium
- Revision
- 106395
- Author
- fsam...@chromium.org
- Date
- 2012-01-31 14:42:26 -0800 (Tue, 31 Jan 2012)
Log Message
[Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News
https://bugs.webkit.org/show_bug.cgi?id=77429
Reviewed by Darin Fisher.
m_webView->isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true,
because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early
and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.
The simplest solution is to simply get rid of the early return in
WebViewImpl::setPageScaleFactorPreservingScrollOffset.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106394 => 106395)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:40:19 UTC (rev 106394)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 22:42:26 UTC (rev 106395)
@@ -1,5 +1,22 @@
2012-01-31 Fady Samuel <fsam...@chromium.org>
+ [Chromium] ChromeClientImpl::dispatchViewportPropertiesDidChange is repeatedly called in Google News
+ https://bugs.webkit.org/show_bug.cgi?id=77429
+
+ Reviewed by Darin Fisher.
+
+ m_webView->isPageScaleFactorSet() is tested in ChromeClientImpl::layoutUpdated, and it is never true,
+ because WebViewImpl::setPageScaleFactorPreservingScrollOffset is called repeatedly and exits early
+ and thus never calls WebViewImpl::setPageScaleFactor which sets the flag.
+
+ The simplest solution is to simply get rid of the early return in
+ WebViewImpl::setPageScaleFactorPreservingScrollOffset.
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
+
+2012-01-31 Fady Samuel <fsam...@chromium.org>
+
[Chromium] Expose setLayoutFallbackWidth as a WebSetting
https://bugs.webkit.org/show_bug.cgi?id=77431
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (106394 => 106395)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-31 22:40:19 UTC (rev 106394)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-01-31 22:42:26 UTC (rev 106395)
@@ -2030,8 +2030,6 @@
{
// Pick a scale factor that is within the expected limits
scaleFactor = clampPageScaleFactorToLimits(scaleFactor);
- if (scaleFactor == pageScaleFactor())
- return;
IntPoint scrollOffsetAtNewScale(mainFrame()->scrollOffset().width, mainFrame()->scrollOffset().height);
float deltaScale = scaleFactor / pageScaleFactor();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
