Title: [106410] trunk/Source/WebKit/chromium
- Revision
- 106410
- Author
- commit-qu...@webkit.org
- Date
- 2012-01-31 15:55:39 -0800 (Tue, 31 Jan 2012)
Log Message
[chromium] enable -Wexit-time-destructors for webkit unit tests
https://bugs.webkit.org/show_bug.cgi?id=77300
Fix the only extant violation (verified by building webkit_unit_tests in static build).
Patch by Ami Fischman <fisch...@chromium.org> on 2012-01-31
Reviewed by Tony Chang.
* WebKitUnitTests.gyp:
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::defaultWebFrameClient):
(WebKit::FrameTestHelpers::defaultWebViewClient):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (106409 => 106410)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 23:49:32 UTC (rev 106409)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-01-31 23:55:39 UTC (rev 106410)
@@ -1,3 +1,16 @@
+2012-01-31 Ami Fischman <fisch...@chromium.org>
+
+ [chromium] enable -Wexit-time-destructors for webkit unit tests
+ https://bugs.webkit.org/show_bug.cgi?id=77300
+ Fix the only extant violation (verified by building webkit_unit_tests in static build).
+
+ Reviewed by Tony Chang.
+
+ * WebKitUnitTests.gyp:
+ * tests/FrameTestHelpers.cpp:
+ (WebKit::FrameTestHelpers::defaultWebFrameClient):
+ (WebKit::FrameTestHelpers::defaultWebViewClient):
+
2012-01-31 Nico Weber <tha...@chromium.org>
[chromium] Expose windowResizerRectChanged() on WebWidget.
Modified: trunk/Source/WebKit/chromium/WebKitUnitTests.gyp (106409 => 106410)
--- trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-01-31 23:49:32 UTC (rev 106409)
+++ trunk/Source/WebKit/chromium/WebKitUnitTests.gyp 2012-01-31 23:55:39 UTC (rev 106410)
@@ -51,6 +51,7 @@
{
'target_name': 'webkit_unit_tests',
'type': 'executable',
+ 'variables': { 'enable_wexit_time_destructors': 1, },
'msvs_guid': '7CEFE800-8403-418A-AD6A-2D52C6FC3EAD',
'dependencies': [
'WebKit.gyp:webkit',
Modified: trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp (106409 => 106410)
--- trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp 2012-01-31 23:49:32 UTC (rev 106409)
+++ trunk/Source/WebKit/chromium/tests/FrameTestHelpers.cpp 2012-01-31 23:55:39 UTC (rev 106410)
@@ -31,6 +31,7 @@
#include "config.h"
#include "FrameTestHelpers.h"
+#include "StdLibExtras.h"
#include "WebFrame.h"
#include "WebFrameClient.h"
#include "WebSettings.h"
@@ -71,7 +72,7 @@
static WebFrameClient* defaultWebFrameClient()
{
- static TestWebFrameClient client;
+ DEFINE_STATIC_LOCAL(TestWebFrameClient, client, ());
return &client;
}
@@ -80,7 +81,7 @@
static WebViewClient* defaultWebViewClient()
{
- static TestWebViewClient client;
+ DEFINE_STATIC_LOCAL(TestWebViewClient, client, ());
return &client;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
