Title: [106912] trunk
Revision
106912
Author
commit-qu...@webkit.org
Date
2012-02-07 00:18:40 -0800 (Tue, 07 Feb 2012)

Log Message

Migrate createObjectURL & revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar <kaust...@motorola.com> on 2012-02-07
Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
    fast/files/revoke-blob-url.html
    fast/dom/window-domurl-crash.html
    fast/files/apply-blob-url-to-img.html
    fast/files/create-blob-url-crash.html
    fast/files/workers/inline-worker-via-blob-url.html

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
* html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
* html/DOMURL.idl:
* html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
* page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
* page/DOMWindow.h: ditto.
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL & revokeObjectURL are static functions.

* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (106911 => 106912)


--- trunk/LayoutTests/ChangeLog	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 08:18:40 UTC (rev 106912)
@@ -1,3 +1,15 @@
+2012-02-07  Kaustubh Atrawalkar  <kaust...@motorola.com>
+
+        Migrate createObjectURL & revokeObjectURL to static (Class) methods.
+        https://bugs.webkit.org/show_bug.cgi?id=74386
+
+        Reviewed by David Levin.
+
+        Added test to check if createObjectURL & revokeObjectURL are static functions.
+
+        * fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
+        * fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
+
 2012-02-03  Vsevolod Vlasov  <vse...@chromium.org>
 
         http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux

Added: trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt (0 => 106912)


--- trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt	2012-02-07 08:18:40 UTC (rev 106912)
@@ -0,0 +1,15 @@
+Test instanceof functions and properties of webkitURL.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS 'createObjectURL' in webkitURL is true
+PASS 'revokeObjectURL' in webkitURL is true
+PASS url.createObjectURL is undefined.
+PASS url.revokeObjectURL is undefined.
+PASS window.webkitURL.createObjectURL is defined.
+PASS window.webkitURL.revokeObjectURL is defined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html (0 => 106912)


--- trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html	                        (rev 0)
+++ trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html	2012-02-07 08:18:40 UTC (rev 106912)
@@ -0,0 +1,25 @@
+<!DOCTYPE HTML>
+<html>
+<head>
+<script src=""
+</head>
+<body>
+<script>
+description("Test instanceof functions and properties of webkitURL.");
+
+var url = "" webkitURL;
+
+shouldBeTrue("'createObjectURL' in webkitURL");
+shouldBeTrue("'revokeObjectURL' in webkitURL");
+
+shouldBeUndefined("url.createObjectURL");
+shouldBeUndefined("url.revokeObjectURL");
+
+shouldBeDefined("window.webkitURL.createObjectURL");
+shouldBeDefined("window.webkitURL.revokeObjectURL");
+
+
+</script>
+<script src=""
+</body>
+</html>

Modified: trunk/Source/WebCore/ChangeLog (106911 => 106912)


--- trunk/Source/WebCore/ChangeLog	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 08:18:40 UTC (rev 106912)
@@ -1,3 +1,51 @@
+2012-02-07  Kaustubh Atrawalkar  <kaust...@motorola.com>
+
+        Migrate createObjectURL & revokeObjectURL to static (Class) methods.
+        https://bugs.webkit.org/show_bug.cgi?id=74386
+
+        Reviewed by David Levin.
+
+        Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
+        Already Existing:
+            fast/files/revoke-blob-url.html
+            fast/dom/window-domurl-crash.html
+            fast/files/apply-blob-url-to-img.html
+            fast/files/create-blob-url-crash.html
+            fast/files/workers/inline-worker-via-blob-url.html
+
+        * dom/ScriptExecutionContext.cpp:
+        (WebCore::ScriptExecutionContext::fileThread):
+        (WebCore):
+        (WebCore::ScriptExecutionContext::publicURLManager):
+        * dom/ScriptExecutionContext.h:
+        (WebCore):
+        (ScriptExecutionContext):
+        * html/DOMURL.cpp:
+        (WebCore):
+        (WebCore::DOMURL::createObjectURL): Changed to static.
+        (WebCore::DOMURL::revokeObjectURL): ditto.
+        * html/DOMURL.h:
+        (DOMURL):
+        (WebCore::DOMURL::create):
+        * html/DOMURL.idl:
+        * html/PublicURLManager.h: Added.
+        (WebCore):
+        (PublicURLManager):
+        (WebCore::PublicURLManager::create):
+        (WebCore::PublicURLManager::contextDestroyed):
+        (WebCore::PublicURLManager::blobURLs):
+        (WebCore::PublicURLManager::streamURLs):
+        * page/DOMWindow.cpp: Removed object initialization for DOMURL.
+        (WebCore):
+        * page/DOMWindow.h: ditto.
+        (DOMWindow):
+        * page/DOMWindow.idl:
+        * workers/WorkerContext.cpp:
+        (WebCore):
+        * workers/WorkerContext.h:
+        (WorkerContext):
+        * workers/WorkerContext.idl:
+
 2012-02-03  Vsevolod Vlasov  <vse...@chromium.org>
 
         http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux

Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.cpp (106911 => 106912)


--- trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.cpp	2012-02-07 08:18:40 UTC (rev 106912)
@@ -38,6 +38,7 @@
 #include "EventTarget.h"
 #include "FileThread.h"
 #include "MessagePort.h"
+#include "PublicURLManager.h"
 #include "ScriptCallStack.h"
 #include "SecurityOrigin.h"
 #include "Settings.h"
@@ -126,6 +127,10 @@
         m_fileThread = 0;
     }
 #endif
+#if ENABLE(BLOB)
+    if (m_publicURLManager)
+        m_publicURLManager->contextDestroyed();
+#endif
 }
 
 #if ENABLE(SQL_DATABASE)
@@ -385,6 +390,15 @@
 }
 #endif
 
+#if ENABLE(BLOB)
+PublicURLManager& ScriptExecutionContext::publicURLManager()
+{
+    if (!m_publicURLManager)
+        m_publicURLManager = PublicURLManager::create();
+    return *m_publicURLManager;
+}
+#endif
+
 void ScriptExecutionContext::adjustMinimumTimerInterval(double oldMinimumTimerInterval)
 {
     if (minimumTimerInterval() != oldMinimumTimerInterval) {

Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.h (106911 => 106912)


--- trunk/Source/WebCore/dom/ScriptExecutionContext.h	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.h	2012-02-07 08:18:40 UTC (rev 106912)
@@ -30,6 +30,7 @@
 #include "ActiveDOMObject.h"
 #include "ConsoleTypes.h"
 #include "KURL.h"
+#include "PublicURLManager.h"
 #include "ScriptCallStack.h"
 #include "SecurityContext.h"
 #include <wtf/Forward.h>
@@ -53,6 +54,9 @@
 class EventTarget;
 class MessagePort;
 
+#if ENABLE(BLOB)
+class PublicURLManager;
+#endif
 #if ENABLE(SQL_DATABASE)
 class Database;
 class DatabaseTaskSynchronizer;
@@ -103,6 +107,9 @@
     virtual void resumeActiveDOMObjects();
     virtual void stopActiveDOMObjects();
 
+#if ENABLE(BLOB)
+    PublicURLManager& publicURLManager();
+#endif
     void didCreateActiveDOMObject(ActiveDOMObject*, void* upcastPointer);
     void willDestroyActiveDOMObject(ActiveDOMObject*);
 
@@ -205,6 +212,9 @@
     bool m_inDispatchErrorEvent;
     class PendingException;
     OwnPtr<Vector<OwnPtr<PendingException> > > m_pendingExceptions;
+#if ENABLE(BLOB)
+    OwnPtr<PublicURLManager> m_publicURLManager;
+#endif
 
 #if ENABLE(SQL_DATABASE)
     RefPtr<DatabaseThread> m_databaseThread;

Modified: trunk/Source/WebCore/html/DOMURL.cpp (106911 => 106912)


--- trunk/Source/WebCore/html/DOMURL.cpp	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/html/DOMURL.cpp	2012-02-07 08:18:40 UTC (rev 106912)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright (C) 2012 Motorola Mobility Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -29,11 +30,15 @@
 
 #include "DOMURL.h"
 
+#include "ActiveDOMObject.h"
 #include "Blob.h"
 #include "BlobURL.h"
 #include "KURL.h"
+#include "PublicURLManager.h"
 #include "ScriptExecutionContext.h"
+#include "SecurityOrigin.h"
 #include "ThreadableBlobRegistry.h"
+#include <wtf/PassOwnPtr.h>
 #include <wtf/MainThread.h>
 
 #if ENABLE(MEDIA_STREAM)
@@ -43,37 +48,13 @@
 
 namespace WebCore {
 
-DOMURL::DOMURL(ScriptExecutionContext* scriptExecutionContext)
-    : ContextDestructionObserver(scriptExecutionContext)
-{
-}
-
-DOMURL::~DOMURL()
-{
-}
-
-void DOMURL::contextDestroyed()
-{
-    ContextDestructionObserver::contextDestroyed();
-
-    HashSet<String>::iterator publicBlobURLsEnd = m_publicBlobURLs.end();
-    for (HashSet<String>::iterator iter = m_publicBlobURLs.begin(); iter != publicBlobURLsEnd; ++iter)
-        ThreadableBlobRegistry::unregisterBlobURL(KURL(ParsedURLString, *iter));
-
 #if ENABLE(MEDIA_STREAM)
-    HashSet<String>::iterator publicStreamURLsEnd = m_publicStreamURLs.end();
-    for (HashSet<String>::iterator iter = m_publicStreamURLs.begin(); iter != publicStreamURLsEnd; ++iter)
-        MediaStreamRegistry::registry().unregisterMediaStreamURL(KURL(ParsedURLString, *iter));
-#endif
-}
-
-#if ENABLE(MEDIA_STREAM)
-String DOMURL::createObjectURL(MediaStream* stream)
+String DOMURL::createObjectURL(ScriptExecutionContext* scriptExecutionContext, MediaStream* stream)
 {
-    if (!m_scriptExecutionContext || !stream)
+    if (!scriptExecutionContext || !stream)
         return String();
 
-    KURL publicURL = BlobURL::createPublicURL(scriptExecutionContext()->securityOrigin());
+    KURL publicURL = BlobURL::createPublicURL(scriptExecutionContext->securityOrigin());
     if (publicURL.isEmpty())
         return String();
 
@@ -81,46 +62,48 @@
     ASSERT(isMainThread());
 
     MediaStreamRegistry::registry().registerMediaStreamURL(publicURL, stream);
-    m_publicStreamURLs.add(publicURL.string());
+    scriptExecutionContext->publicURLManager().streamURLs().add(publicURL.string());
 
     return publicURL.string();
 }
 #endif
 
-String DOMURL::createObjectURL(Blob* blob)
+String DOMURL::createObjectURL(ScriptExecutionContext* scriptExecutionContext, Blob* blob)
 {
-    if (!m_scriptExecutionContext || !blob)
+    if (!scriptExecutionContext || !blob)
         return String();
 
-    KURL publicURL = BlobURL::createPublicURL(scriptExecutionContext()->securityOrigin());
+    KURL publicURL = BlobURL::createPublicURL(scriptExecutionContext->securityOrigin());
     if (publicURL.isEmpty())
         return String();
 
     ThreadableBlobRegistry::registerBlobURL(publicURL, blob->url());
-    m_publicBlobURLs.add(publicURL.string());
+    scriptExecutionContext->publicURLManager().blobURLs().add(publicURL.string());
 
     return publicURL.string();
 }
 
-void DOMURL::revokeObjectURL(const String& urlString)
+void DOMURL::revokeObjectURL(ScriptExecutionContext* scriptExecutionContext, const String& urlString)
 {
-    if (!m_scriptExecutionContext)
+    if (!scriptExecutionContext)
         return;
 
     KURL url(KURL(), urlString);
 
-    if (m_publicBlobURLs.contains(url.string())) {
+    HashSet<String>& blobURLs = scriptExecutionContext->publicURLManager().blobURLs();
+    if (blobURLs.contains(url.string())) {
         ThreadableBlobRegistry::unregisterBlobURL(url);
-        m_publicBlobURLs.remove(url.string());
+        blobURLs.remove(url.string());
     }
 
 #if ENABLE(MEDIA_STREAM)
-    if (m_publicStreamURLs.contains(url.string())) {
+    HashSet<String>& streamURLs = scriptExecutionContext->publicURLManager().streamURLs();
+    if (streamURLs.contains(url.string())) {
         // FIXME: make sure of this assertion below. Raise a spec question if required.
         // Since WebWorkers cannot obtain Stream objects, we should be on the main thread.
         ASSERT(isMainThread());
         MediaStreamRegistry::registry().unregisterMediaStreamURL(url);
-        m_publicStreamURLs.remove(url.string());
+        streamURLs.remove(url.string());
     }
 #endif
 }

Modified: trunk/Source/WebCore/html/DOMURL.h (106911 => 106912)


--- trunk/Source/WebCore/html/DOMURL.h	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/html/DOMURL.h	2012-02-07 08:18:40 UTC (rev 106912)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright (C) 2012 Motorola Mobility Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -26,9 +27,7 @@
 #ifndef DOMURL_h
 #define DOMURL_h
 
-#if ENABLE(BLOB)
-
-#include "ActiveDOMObject.h"
+#include "KURL.h"
 #include "PlatformString.h"
 #include <wtf/HashSet.h>
 #include <wtf/PassRefPtr.h>
@@ -40,30 +39,22 @@
 class MediaStream;
 class ScriptExecutionContext;
 
-class DOMURL : public RefCounted<DOMURL>, public ContextDestructionObserver {
+class DOMURL : public RefCounted<DOMURL> {
+
 public:
-    static PassRefPtr<DOMURL> create(ScriptExecutionContext* scriptExecutionContext) { return adoptRef(new DOMURL(scriptExecutionContext)); }
-    ~DOMURL();
+    static PassRefPtr<DOMURL> create() { return adoptRef(new DOMURL); }
 
-#if ENABLE(MEDIA_STREAM)
-    String createObjectURL(MediaStream*);
-#endif
-    String createObjectURL(Blob*);
-    void revokeObjectURL(const String&);
+#if ENABLE(BLOB)
+    static void contextDestroyed(ScriptExecutionContext*);
 
-private:
-    explicit DOMURL(ScriptExecutionContext*);
-
-    virtual void contextDestroyed();
-
-    HashSet<String> m_publicBlobURLs;
+    static String createObjectURL(ScriptExecutionContext*, Blob*);
+    static void revokeObjectURL(ScriptExecutionContext*, const String&);
 #if ENABLE(MEDIA_STREAM)
-    HashSet<String> m_publicStreamURLs;
+    static String createObjectURL(ScriptExecutionContext*, MediaStream*);
 #endif
+#endif
 };
 
 } // namespace WebCore
 
-#endif // ENABLE(BLOB)
-
 #endif // DOMURL_h

Modified: trunk/Source/WebCore/html/DOMURL.idl (106911 => 106912)


--- trunk/Source/WebCore/html/DOMURL.idl	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/html/DOMURL.idl	2012-02-07 08:18:40 UTC (rev 106912)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright (C) 2012 Motorola Mobility Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -26,15 +27,15 @@
 module html {
     interface [
         Conditional=BLOB,
-        OmitConstructor,
+        Constructor,
         GenerateNativeConverter,
         JSGenerateToJS,
         JSNoStaticTables
     ] DOMURL {
 #if defined(ENABLE_MEDIA_STREAM) && ENABLE_MEDIA_STREAM
-        [ConvertNullStringTo=Undefined] DOMString createObjectURL(in MediaStream stream);
+        static [CallWith=ScriptExecutionContext,ConvertNullStringTo=Undefined] DOMString createObjectURL(in MediaStream stream);
 #endif
-        [ConvertNullStringTo=Undefined] DOMString createObjectURL(in Blob blob);
-        void revokeObjectURL(in DOMString url);
+        static [CallWith=ScriptExecutionContext,ConvertNullStringTo=Undefined] DOMString createObjectURL(in Blob blob);
+        static [CallWith=ScriptExecutionContext] void revokeObjectURL(in DOMString url);
     };
 }

Copied: trunk/Source/WebCore/html/PublicURLManager.h (from rev 106911, trunk/Source/WebCore/html/DOMURL.h) (0 => 106912)


--- trunk/Source/WebCore/html/PublicURLManager.h	                        (rev 0)
+++ trunk/Source/WebCore/html/PublicURLManager.h	2012-02-07 08:18:40 UTC (rev 106912)
@@ -0,0 +1,76 @@
+/*
+ * Copyright (C) 2012 Motorola Mobility Inc.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1.  Redistributions of source code must retain the above copyright
+ *     notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ *     notice, this list of conditions and the following disclaimer in the
+ *     documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
+ * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef PublicURLManager_h
+#define PublicURLManager_h
+
+#if ENABLE(BLOB)
+#include "PlatformString.h"
+#include "ScriptExecutionContext.h"
+#include "ThreadableBlobRegistry.h"
+#include <wtf/HashSet.h>
+
+#if ENABLE(MEDIA_STREAM)
+#include "MediaStream.h"
+#include "MediaStreamRegistry.h"
+#endif
+
+namespace WebCore {
+
+class ScriptExecutionContext;
+
+class PublicURLManager {
+
+public:
+    static PassOwnPtr<PublicURLManager> create() { return adoptPtr(new PublicURLManager); }
+    void contextDestroyed()
+    {
+        HashSet<String>::iterator blobURLsEnd = m_blobURLs.end();
+        for (HashSet<String>::iterator iter = m_blobURLs.begin(); iter != blobURLsEnd; ++iter)
+            ThreadableBlobRegistry::unregisterBlobURL(KURL(ParsedURLString, *iter));
+
+#if ENABLE(MEDIA_STREAM)
+        HashSet<String>::iterator streamURLsEnd = m_streamURLs.end();
+        for (HashSet<String>::iterator iter = m_streamURLs.begin(); iter != streamURLsEnd; ++iter)
+            MediaStreamRegistry::registry().unregisterMediaStreamURL(KURL(ParsedURLString, *iter));
+#endif
+    }
+
+    HashSet<String>& blobURLs() { return m_blobURLs; }
+#if ENABLE(MEDIA_STREAM)
+    HashSet<String>& streamURLs() { return m_streamURLs; }
+#endif
+
+private:
+    HashSet<String> m_blobURLs;
+#if ENABLE(MEDIA_STREAM)
+    HashSet<String> m_streamURLs;
+#endif
+};
+
+} // namespace WebCore
+
+#endif // BLOB
+#endif // PUBLICURLMANAGER_h

Modified: trunk/Source/WebCore/page/DOMWindow.cpp (106911 => 106912)


--- trunk/Source/WebCore/page/DOMWindow.cpp	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/page/DOMWindow.cpp	2012-02-07 08:18:40 UTC (rev 106912)
@@ -1897,15 +1897,6 @@
     dialogFrame->page()->chrome()->runModal();
 }
 
-#if ENABLE(BLOB)
-DOMURL* DOMWindow::webkitURL() const
-{
-    if (!m_domURL && isCurrentlyDisplayedInFrame())
-        m_domURL = DOMURL::create(this->scriptExecutionContext());
-    return m_domURL.get();
-}
-#endif
-
 #if ENABLE(QUOTA)
 StorageInfo* DOMWindow::webkitStorageInfo() const
 {

Modified: trunk/Source/WebCore/page/DOMWindow.h (106911 => 106912)


--- trunk/Source/WebCore/page/DOMWindow.h	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/page/DOMWindow.h	2012-02-07 08:18:40 UTC (rev 106912)
@@ -351,10 +351,6 @@
         using RefCounted<DOMWindow>::ref;
         using RefCounted<DOMWindow>::deref;
 
-#if ENABLE(BLOB)
-        DOMURL* webkitURL() const;
-#endif
-
 #if ENABLE(DEVICE_ORIENTATION)
         DEFINE_ATTRIBUTE_EVENT_LISTENER(devicemotion);
         DEFINE_ATTRIBUTE_EVENT_LISTENER(deviceorientation);

Modified: trunk/Source/WebCore/page/DOMWindow.idl (106911 => 106912)


--- trunk/Source/WebCore/page/DOMWindow.idl	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2012-02-07 08:18:40 UTC (rev 106912)
@@ -782,7 +782,7 @@
 
         attribute [Conditional=BLOB] WebKitBlobBuilderConstructor WebKitBlobBuilder;
 
-        readonly attribute [Conditional=BLOB] DOMURL webkitURL;
+        attribute [Conditional=BLOB] DOMURLConstructor webkitURL;
 
 #if defined(ENABLE_QUOTA) && ENABLE_QUOTA
         readonly attribute [V8EnabledAtRuntime=Quota] StorageInfo webkitStorageInfo;

Modified: trunk/Source/WebCore/workers/WorkerContext.cpp (106911 => 106912)


--- trunk/Source/WebCore/workers/WorkerContext.cpp	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/workers/WorkerContext.cpp	2012-02-07 08:18:40 UTC (rev 106912)
@@ -377,15 +377,6 @@
     return &m_eventTargetData;
 }
 
-#if ENABLE(BLOB)
-DOMURL* WorkerContext::webkitURL() const
-{
-    if (!m_domURL)
-        m_domURL = DOMURL::create(this->scriptExecutionContext());
-    return m_domURL.get();
-}
-#endif
-
 #if ENABLE(FILE_SYSTEM)
 void WorkerContext::webkitRequestFileSystem(int type, long long size, PassRefPtr<FileSystemCallback> successCallback, PassRefPtr<ErrorCallback> errorCallback)
 {

Modified: trunk/Source/WebCore/workers/WorkerContext.h (106911 => 106912)


--- trunk/Source/WebCore/workers/WorkerContext.h	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/workers/WorkerContext.h	2012-02-07 08:18:40 UTC (rev 106912)
@@ -131,10 +131,6 @@
         virtual bool isContextThread() const;
         virtual bool isJSExecutionForbidden() const;
 
-#if ENABLE(BLOB)
-        DOMURL* webkitURL() const;
-#endif
-
 #if ENABLE(FILE_SYSTEM)
         enum FileSystemType {
             TEMPORARY,

Modified: trunk/Source/WebCore/workers/WorkerContext.idl (106911 => 106912)


--- trunk/Source/WebCore/workers/WorkerContext.idl	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/Source/WebCore/workers/WorkerContext.idl	2012-02-07 08:18:40 UTC (rev 106912)
@@ -101,7 +101,7 @@
         attribute FileReaderSyncConstructor FileReaderSync;
 #endif
 
-        readonly attribute [Conditional=BLOB] DOMURL webkitURL;
+        attribute [Conditional=BLOB] DOMURLConstructor webkitURL;
 
 #if defined(ENABLE_FILE_SYSTEM) && ENABLE_FILE_SYSTEM
         const unsigned short TEMPORARY = 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to