Title: [106937] trunk/Source/WebCore
- Revision
- 106937
- Author
- commit-qu...@webkit.org
- Date
- 2012-02-07 07:27:08 -0800 (Tue, 07 Feb 2012)
Log Message
Web Inspector: fix objects duplication when switching filter in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=77974
Patch by Alexei Filippov <alex...@chromium.org> on 2012-02-07
Reviewed by Yury Semikhatsky.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (106936 => 106937)
--- trunk/Source/WebCore/ChangeLog 2012-02-07 15:22:03 UTC (rev 106936)
+++ trunk/Source/WebCore/ChangeLog 2012-02-07 15:27:08 UTC (rev 106937)
@@ -1,3 +1,13 @@
+2012-02-07 Alexei Filippov <alex...@chromium.org>
+
+ Web Inspector: fix objects duplication when switching filter in heap profiler.
+ https://bugs.webkit.org/show_bug.cgi?id=77974
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/DetailedHeapshotView.js:
+ (WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
+
2012-02-07 Jonathan Backer <bac...@chromium.org>
[chromium] Add setNeedsRedraw to WebWidget
Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (106936 => 106937)
--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2012-02-07 15:22:03 UTC (rev 106936)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2012-02-07 15:27:08 UTC (rev 106937)
@@ -238,17 +238,13 @@
this.sortingChanged();
}
- if (this._filterProfileIndex === -1) {
- this.snapshot.aggregates(false, "allObjects", null, aggregatesReceived.bind(this, "allObjects"));
- return;
- }
-
this.dispose();
this.removeChildren();
this.resetSortingCache();
- var key = this._minNodeId + ".." + this._maxNodeId;
- var filter = "function(node) { var id = node.id; return id > " + this._minNodeId + " && id <= " + this._maxNodeId + "; }";
+ var key = this._filterProfileIndex === -1 ? "allObjects" : this._minNodeId + ".." + this._maxNodeId;
+ var filter = this._filterProfileIndex === -1 ? null : "function(node) { var id = node.id; return id > " + this._minNodeId + " && id <= " + this._maxNodeId + "; }";
+
this.snapshot.aggregates(false, key, filter, aggregatesReceived.bind(this, key));
},
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
