Title: [107029] trunk/Source/WebCore
Revision
107029
Author
kl...@webkit.org
Date
2012-02-07 19:26:18 -0800 (Tue, 07 Feb 2012)

Log Message

REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
<http://webkit.org/b/78068>

Reviewed by Ryosuke Niwa.

Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.

* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (107028 => 107029)


--- trunk/Source/WebCore/ChangeLog	2012-02-08 03:20:07 UTC (rev 107028)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 03:26:18 UTC (rev 107029)
@@ -1,3 +1,16 @@
+2012-02-07  Andreas Kling  <awesomekl...@apple.com>
+
+        REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
+        <http://webkit.org/b/78068>
+
+        Reviewed by Ryosuke Niwa.
+
+        Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
+        This regressed in r106756 and I suspect it'll fix up the cycler regression.
+
+        * dom/StyledElement.cpp:
+        (WebCore::StyledElement::addCSSProperty):
+
 2012-02-07  Noel Gordon  <noel.gor...@gmail.com>
 
         Remove TextureMapperQt from the gyp projects

Modified: trunk/Source/WebCore/dom/StyledElement.cpp (107028 => 107029)


--- trunk/Source/WebCore/dom/StyledElement.cpp	2012-02-08 03:20:07 UTC (rev 107028)
+++ trunk/Source/WebCore/dom/StyledElement.cpp	2012-02-08 03:26:18 UTC (rev 107029)
@@ -29,6 +29,7 @@
 #include "CSSStyleSelector.h"
 #include "CSSStyleSheet.h"
 #include "CSSValueKeywords.h"
+#include "CSSValuePool.h"
 #include "Color.h"
 #include "ClassList.h"
 #include "ContentSecurityPolicy.h"
@@ -142,9 +143,9 @@
         removeCSSProperty(id);
 }
 
-void StyledElement::addCSSProperty(int id, int value)
+void StyledElement::addCSSProperty(int propertyID, int identifier)
 {
-    ensureAttributeStyle()->setProperty(id, value);
+    ensureAttributeStyle()->setProperty(CSSProperty(propertyID, document()->cssValuePool()->createIdentifierValue(identifier)));
 }
 
 void StyledElement::addCSSImageProperty(int id, const String& url)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to