Log Message
Some API tests erroneously use = instead of == (causing build failures) https://bugs.webkit.org/show_bug.cgi?id=78915
Reviewed by Sam Weinig. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an == (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (108105 => 108106)
--- trunk/Tools/ChangeLog 2012-02-17 20:05:07 UTC (rev 108105)
+++ trunk/Tools/ChangeLog 2012-02-17 20:07:25 UTC (rev 108106)
@@ -1,3 +1,14 @@
+2012-02-17 Maciej Stachowiak <m...@apple.com>
+
+ Some API tests erroneously use = instead of == (causing build failures)
+ https://bugs.webkit.org/show_bug.cgi?id=78915
+
+ Reviewed by Sam Weinig.
+
+ * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
+ (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
+ (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
+
2012-02-17 Peter Beverloo <pe...@chromium.org>
[Chromium] Include TestShellLinux.cpp in the build for Android
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp (108105 => 108106)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp 2012-02-17 20:05:07 UTC (rev 108105)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp 2012-02-17 20:07:25 UTC (rev 108106)
@@ -90,7 +90,7 @@
State* state = reinterpret_cast<State*>(const_cast<void*>(clientInfo));
EXPECT_FALSE(state->didStartProvisionalLoadForFrame);
EXPECT_FALSE(state->didCommitLoadForFrame);
- EXPECT_TRUE(mouseButton = kWKEventMouseButtonNoButton);
+ EXPECT_TRUE(mouseButton == kWKEventMouseButtonNoButton);
state->didDecidePolicyForNavigationAction = true;
@@ -99,7 +99,7 @@
static void decidePolicyForNewWindowAction(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, WKURLRequestRef request, WKStringRef frameName, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
{
- EXPECT_TRUE(mouseButton = kWKEventMouseButtonNoButton);
+ EXPECT_TRUE(mouseButton == kWKEventMouseButtonNoButton);
WKFramePolicyListenerUse(listener);
}
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
