Title: [108515] trunk/Tools
- Revision
- 108515
- Author
- dpra...@chromium.org
- Date
- 2012-02-22 10:19:30 -0800 (Wed, 22 Feb 2012)
Log Message
webkitpy: test_function_length_check_definition_huge_lines is slow
https://bugs.webkit.org/show_bug.cgi?id=79185
Reviewed by Adam Barth.
This test takes ~3 seconds to run, apparently because we're
running a test on a 10,000 line function :). Dropping the
function length to 640 still exercises the code path and
provides a 10x speedup.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest):
(CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (108514 => 108515)
--- trunk/Tools/ChangeLog 2012-02-22 18:16:54 UTC (rev 108514)
+++ trunk/Tools/ChangeLog 2012-02-22 18:19:30 UTC (rev 108515)
@@ -1,5 +1,21 @@
2012-02-22 Dirk Pranke <dpra...@chromium.org>
+ webkitpy: test_function_length_check_definition_huge_lines is slow
+ https://bugs.webkit.org/show_bug.cgi?id=79185
+
+ Reviewed by Adam Barth.
+
+ This test takes ~3 seconds to run, apparently because we're
+ running a test on a 10,000 line function :). Dropping the
+ function length to 640 still exercises the code path and
+ provides a 10x speedup.
+
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (CppStyleTest):
+ (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
+
+2012-02-22 Dirk Pranke <dpra...@chromium.org>
+
webkitpy: speed up FileLockTest.test_lock_lifecycle
https://bugs.webkit.org/show_bug.cgi?id=79189
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (108514 => 108515)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-02-22 18:16:54 UTC (rev 108514)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-02-22 18:19:30 UTC (rev 108515)
@@ -783,7 +783,7 @@
# self.assert_lint('void Method(char* /*x*/);', message)
# self.assert_lint('typedef void (*Method)(int32);', message)
# self.assert_lint('static void operator delete[](void*) throw();', message)
- #
+ #
# self.assert_lint('virtual void D(int* p);', '')
# self.assert_lint('void operator delete(void* x) throw();', '')
# self.assert_lint('void Method(char* x)\n{', '')
@@ -792,7 +792,7 @@
# self.assert_lint('typedef void (*Method)(int32 x);', '')
# self.assert_lint('static void operator delete[](void* x) throw();', '')
# self.assert_lint('static void operator delete[](void* /*x*/) throw();', '')
- #
+ #
# # This one should technically warn, but doesn't because the function
# # pointer is confusing.
# self.assert_lint('virtual void E(void (*fn)(int* p));', '')
@@ -3072,7 +3072,7 @@
def test_function_length_check_definition_huge_lines(self):
# 5 is the limit
- self.assert_function_length_check_definition(self.trigger_lines(10), 5)
+ self.assert_function_length_check_definition(self.trigger_lines(6), 5)
def test_function_length_not_determinable(self):
# Macro invocation without terminating semicolon.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
