Title: [108560] trunk/Tools
- Revision
- 108560
- Author
- dba...@webkit.org
- Date
- 2012-02-22 15:23:44 -0800 (Wed, 22 Feb 2012)
Log Message
new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
https://bugs.webkit.org/show_bug.cgi?id=79277
Reviewed by Adam Barth.
Pass command line argument no-saved-state to run-safari to disable Safari
state restoration for the session on OS 10.7.
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_show_results_html_file):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (108559 => 108560)
--- trunk/Tools/ChangeLog 2012-02-22 23:17:46 UTC (rev 108559)
+++ trunk/Tools/ChangeLog 2012-02-22 23:23:44 UTC (rev 108560)
@@ -1,3 +1,18 @@
+2012-02-22 Daniel Bates <dba...@webkit.org>
+
+ new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
+ https://bugs.webkit.org/show_bug.cgi?id=79277
+
+ Reviewed by Adam Barth.
+
+ Pass command line argument no-saved-state to run-safari to disable Safari
+ state restoration for the session on OS 10.7.
+
+ * Scripts/webkitpy/layout_tests/port/mac.py:
+ (MacPort.show_results_html_file):
+ * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
+ (test_show_results_html_file):
+
2012-02-22 Kalev Lember <kalevlem...@gmail.com>
Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (108559 => 108560)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-02-22 23:17:46 UTC (rev 108559)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-02-22 23:23:44 UTC (rev 108560)
@@ -128,7 +128,7 @@
return self._build_path('WebCore.framework/Versions/A/WebCore')
def show_results_html_file(self, results_filename):
- self._run_script('run-safari', ['-NSOpen', results_filename])
+ self._run_script('run-safari', ['--no-saved-state', '-NSOpen', results_filename])
# FIXME: The next two routines turn off the http locking in order
# to work around failures on the bots caused when the slave restarts.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py (108559 => 108560)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py 2012-02-22 23:17:46 UTC (rev 108559)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py 2012-02-22 23:23:44 UTC (rev 108560)
@@ -161,7 +161,7 @@
port = self.make_port()
# Delay setting a should_log executive to avoid logging from MacPort.__init__.
port._executive = MockExecutive(should_log=True)
- expected_stderr = "MOCK run_command: ['Tools/Scripts/run-safari', '--release', '-NSOpen', 'test.html'], cwd=/mock-checkout\n"
+ expected_stderr = "MOCK run_command: ['Tools/Scripts/run-safari', '--release', '--no-saved-state', '-NSOpen', 'test.html'], cwd=/mock-checkout\n"
OutputCapture().assert_outputs(self, port.show_results_html_file, ["test.html"], expected_stderr=expected_stderr)
def test_operating_system(self):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
