[webkit-changes] [109029] trunk/Source/WebCore

Mon, 27 Feb 2012 15:22:44 -0800

Title: [109029] trunk/Source/WebCore
Revision
109029
Author
hara...@chromium.org
Date
2012-02-27 15:22:32 -0800 (Mon, 27 Feb 2012)

Log Message

Remove [ConstructorParameters] from IDL files that have [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=79643

Reviewed by Adam Barth.

This patch removes [ConstructorParameters] from IDL files that have [Constructor],
since CodeGeneratorJS.pm can automatically detect the number of constructor
arguments by the [Constructor(...)] signature.

Test: fast/js/constructor-length.html

* Modules/mediastream/PeerConnection.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* css/WebKitCSSMatrix.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (109028 => 109029)


--- trunk/Source/WebCore/ChangeLog	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/ChangeLog	2012-02-27 23:22:32 UTC (rev 109029)
@@ -1,3 +1,24 @@
+2012-02-27  Kentaro Hara  <hara...@chromium.org>
+
+        Remove [ConstructorParameters] from IDL files that have [Constructor]
+        https://bugs.webkit.org/show_bug.cgi?id=79643
+
+        Reviewed by Adam Barth.
+
+        This patch removes [ConstructorParameters] from IDL files that have [Constructor],
+        since CodeGeneratorJS.pm can automatically detect the number of constructor
+        arguments by the [Constructor(...)] signature.
+
+        Test: fast/js/constructor-length.html
+
+        * Modules/mediastream/PeerConnection.idl:
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateConstructorDefinition):
+        * css/WebKitCSSMatrix.idl:
+        * page/EventSource.idl:
+        * workers/SharedWorker.idl:
+        * workers/Worker.idl:
+
 2012-02-27  Julien Chaffraix  <jchaffr...@webkit.org>
 
         Avoid doing 2 hash lookups if we override RenderBox's logical width / height

Modified: trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl (109028 => 109029)


--- trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/Modules/mediastream/PeerConnection.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -27,7 +27,6 @@
     interface [
         Conditional=MEDIA_STREAM,
         ActiveDOMObject,
-        ConstructorParameters=2,
         Constructor(in DOMString serverConfiguration, in [Callback] SignalingCallback signalingCallback),
         CallWith=ScriptExecutionContext,
         JSCustomConstructor,

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (109028 => 109029)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-27 23:22:32 UTC (rev 109029)
@@ -3368,7 +3368,7 @@
     if (!defined $numberOfConstructorParameters) {
         if (IsConstructorTemplate($dataNode, "Event")) {
             $numberOfConstructorParameters = 2;
-        } elsif ($dataNode->extendedAttributes->{"Constructor"} and !$dataNode->extendedAttributes->{"CustomConstructor"} and !$dataNode->extendedAttributes->{"JSCustomConstructor"}) {
+        } elsif ($dataNode->extendedAttributes->{"Constructor"}) {
             $numberOfConstructorParameters = @{$dataNode->constructor->parameters};
         }
     }

Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (109028 => 109029)


--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -27,7 +27,6 @@
 
     // Introduced in DOM Level ?:
     interface [
-        ConstructorParameters=1,
         Constructor(in [Optional=DefaultIsNullString] DOMString cssValue),
         ConstructorRaisesException,
     ] WebKitCSSMatrix {

Modified: trunk/Source/WebCore/page/EventSource.idl (109028 => 109029)


--- trunk/Source/WebCore/page/EventSource.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/page/EventSource.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -33,7 +33,6 @@
 
     interface [
         ActiveDOMObject,
-        ConstructorParameters=1,
         Constructor(in DOMString scriptUrl),
         CallWith=ScriptExecutionContext,
         ConstructorRaisesException,

Modified: trunk/Source/WebCore/workers/SharedWorker.idl (109028 => 109029)


--- trunk/Source/WebCore/workers/SharedWorker.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/workers/SharedWorker.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -35,7 +35,6 @@
         Conditional=SHARED_WORKERS,
         ActiveDOMObject,
         JSCustomConstructor,
-        ConstructorParameters=2,
         Constructor(in DOMString scriptURL, in [Optional=DefaultIsNullString] DOMString name),
         CallWith=ScriptExecutionContext,
         ConstructorRaisesException,

Modified: trunk/Source/WebCore/workers/Worker.idl (109028 => 109029)


--- trunk/Source/WebCore/workers/Worker.idl	2012-02-27 23:09:34 UTC (rev 109028)
+++ trunk/Source/WebCore/workers/Worker.idl	2012-02-27 23:22:32 UTC (rev 109029)
@@ -31,7 +31,6 @@
         Conditional=WORKERS,
         ActiveDOMObject,
         JSCustomConstructor,
-        ConstructorParameters=1,
         Constructor(in DOMString scriptUrl),
         CallWith=ScriptExecutionContext,
         ConstructorRaisesException,

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to