Title: [111789] trunk/Source/WebCore
Revision
111789
Author
benja...@webkit.org
Date
2012-03-22 17:13:01 -0700 (Thu, 22 Mar 2012)

Log Message

Remove an obsolete comment regarding magic frames from Geolocation
https://bugs.webkit.org/show_bug.cgi?id=81871

Patch by Benjamin Poulain <bpoul...@apple.com> on 2012-03-22
Reviewed by Alexey Proskuryakov.

Moving a frame into another document is no longer possible after r111361. The comment
is now irrelevant.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::stop):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111788 => 111789)


--- trunk/Source/WebCore/ChangeLog	2012-03-23 00:09:11 UTC (rev 111788)
+++ trunk/Source/WebCore/ChangeLog	2012-03-23 00:13:01 UTC (rev 111789)
@@ -1,3 +1,16 @@
+2012-03-22  Benjamin Poulain  <bpoul...@apple.com>
+
+        Remove an obsolete comment regarding magic frames from Geolocation
+        https://bugs.webkit.org/show_bug.cgi?id=81871
+
+        Reviewed by Alexey Proskuryakov.
+
+        Moving a frame into another document is no longer possible after r111361. The comment
+        is now irrelevant.
+
+        * Modules/geolocation/Geolocation.cpp:
+        (WebCore::Geolocation::stop):
+
 2012-03-22  Csaba Osztrogonác  <o...@webkit.org>
 
         Actually move WTF files to their new home

Modified: trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp (111788 => 111789)


--- trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp	2012-03-23 00:09:11 UTC (rev 111788)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.cpp	2012-03-23 00:13:01 UTC (rev 111789)
@@ -256,12 +256,6 @@
 
 void Geolocation::stop()
 {
-    // FIXME: We should ideally allow existing Geolocation activities to continue
-    // when the Geolocation's iframe is reparented. (Assuming we continue to
-    // support reparenting iframes.)
-    // See https://bugs.webkit.org/show_bug.cgi?id=55577
-    // and https://bugs.webkit.org/show_bug.cgi?id=52877
-
     Page* page = this->page();
     if (page && m_allowGeolocation == InProgress)
         page->geolocationController()->cancelPermissionRequest(this);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to