Title: [114722] trunk
Revision
114722
Author
commit-qu...@webkit.org
Date
2012-04-20 00:27:27 -0700 (Fri, 20 Apr 2012)

Log Message

[EFL] Add setting API for author and user styles.
https://bugs.webkit.org/show_bug.cgi?id=82860

Patch by Kamil Blank <k.bl...@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.

Source/WebKit/efl:

Add missing implementation setAuthorAndUserStylesEnabled to EFL's
DumpRenderTreeSupport.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

Tools:

Implementation of setAuthorAndUserStylesEnabled.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled):

LayoutTests:

Enable test connected with setAuthorAndUserStylesEnabled.

* platform/efl/Skipped:
* platform/efl/fast/css/disabled-author-styles-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (114721 => 114722)


--- trunk/LayoutTests/ChangeLog	2012-04-20 06:58:15 UTC (rev 114721)
+++ trunk/LayoutTests/ChangeLog	2012-04-20 07:27:27 UTC (rev 114722)
@@ -1,3 +1,15 @@
+2012-04-20  Kamil Blank  <k.bl...@samsung.com>
+
+        [EFL] Add setting API for author and user styles.
+        https://bugs.webkit.org/show_bug.cgi?id=82860
+
+        Reviewed by Daniel Bates.
+
+        Enable test connected with setAuthorAndUserStylesEnabled.
+
+        * platform/efl/Skipped:
+        * platform/efl/fast/css/disabled-author-styles-expected.txt: Added.
+
 2012-04-19  Sudarsana Nagineni  <sudarsana.nagin...@linux.intel.com>
 
         [EFL] Missing keycode translation for space key

Modified: trunk/LayoutTests/platform/efl/Skipped (114721 => 114722)


--- trunk/LayoutTests/platform/efl/Skipped	2012-04-20 06:58:15 UTC (rev 114721)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-04-20 07:27:27 UTC (rev 114722)
@@ -412,9 +412,6 @@
 fast/xmlhttprequest/xmlhttprequest-no-file-access.html
 fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
 
-# EFL's LayoutTestController does not implement setAuthorAndUserStylesEnabled
-fast/css/disabled-author-styles.html
-
 # EFL's LayoutTestController does not implement setJavaScriptProfilingEnabled
 fast/profiler
 

Added: trunk/LayoutTests/platform/efl/fast/css/disabled-author-styles-expected.txt (0 => 114722)


--- trunk/LayoutTests/platform/efl/fast/css/disabled-author-styles-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl/fast/css/disabled-author-styles-expected.txt	2012-04-20 07:27:27 UTC (rev 114722)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderBlock {DIV} at (0,0) size 784x18
+        RenderText {#text} at (0,0) size 214x19
+          text run at (0,0) width 214: "This text should be black, not red."
+      RenderBlock {DIV} at (0,18) size 784x0

Modified: trunk/Source/WebKit/efl/ChangeLog (114721 => 114722)


--- trunk/Source/WebKit/efl/ChangeLog	2012-04-20 06:58:15 UTC (rev 114721)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-04-20 07:27:27 UTC (rev 114722)
@@ -1,3 +1,15 @@
+2012-04-20  Kamil Blank  <k.bl...@samsung.com>
+
+        [EFL] Add setting API for author and user styles.
+        https://bugs.webkit.org/show_bug.cgi?id=82860
+
+        Reviewed by Daniel Bates.
+
+        Add missing implementation setAuthorAndUserStylesEnabled to EFL's
+        DumpRenderTreeSupport.
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+
 2012-04-19  Christophe Dumez  <christophe.du...@intel.com>
 
         [EFL] dispatchDidCancelClientRedirect needs implementation

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (114721 => 114722)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-04-20 06:58:15 UTC (rev 114721)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-04-20 07:27:27 UTC (rev 114722)
@@ -561,3 +561,12 @@
     RefPtr<WebCore::CSSComputedStyleDeclaration> style = WebCore::CSSComputedStyleDeclaration::create(element, true);
     return toRef(exec, toJS(exec, jsElement->globalObject(), style.get()));
 }
+
+void DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled(Evas_Object* ewkView, bool enabled)
+{
+    WebCore::Page* corePage = EWKPrivate::corePage(ewkView);
+    if (!corePage)
+        return;
+
+    corePage->settings()->setAuthorAndUserStylesEnabled(enabled);
+}

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (114721 => 114722)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-04-20 06:58:15 UTC (rev 114721)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-04-20 07:27:27 UTC (rev 114722)
@@ -93,6 +93,7 @@
     static String markerTextForListItem(JSContextRef, JSValueRef nodeObject);
     static void setInteractiveFormValidationEnabled(Evas_Object* ewkView, bool enabled);
     static JSValueRef computedStyleIncludingVisitedInfo(JSContextRef, JSValueRef);
+    static void setAuthorAndUserStylesEnabled(Evas_Object* ewkView, bool);
 };
 
 #endif // DumpRenderTreeSupportEfl_h

Modified: trunk/Tools/ChangeLog (114721 => 114722)


--- trunk/Tools/ChangeLog	2012-04-20 06:58:15 UTC (rev 114721)
+++ trunk/Tools/ChangeLog	2012-04-20 07:27:27 UTC (rev 114722)
@@ -1,3 +1,15 @@
+2012-04-20  Kamil Blank  <k.bl...@samsung.com>
+
+        [EFL] Add setting API for author and user styles.
+        https://bugs.webkit.org/show_bug.cgi?id=82860
+
+        Reviewed by Daniel Bates.
+
+        Implementation of setAuthorAndUserStylesEnabled.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::setAuthorAndUserStylesEnabled):
+
 2012-04-19  Sudarsana Nagineni  <sudarsana.nagin...@linux.intel.com>
 
         [EFL] Missing keycode translation for space key

Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (114721 => 114722)


--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-20 06:58:15 UTC (rev 114721)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-04-20 07:27:27 UTC (rev 114722)
@@ -354,9 +354,9 @@
     notImplemented();
 }
 
-void LayoutTestController::setAuthorAndUserStylesEnabled(bool)
+void LayoutTestController::setAuthorAndUserStylesEnabled(bool flag)
 {
-    notImplemented();
+    DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled(browser->mainView(), flag);
 }
 
 void LayoutTestController::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to