Title: [114725] trunk/Tools
Revision
114725
Author
rn...@webkit.org
Date
2012-04-20 00:42:27 -0700 (Fri, 20 Apr 2012)

Log Message

REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
https://bugs.webkit.org/show_bug.cgi?id=84424

Reviewed by Mark Rowe.

Let Windows and Chromium have their own list of files to copy.

* BuildSlaveSupport/built-product-archive:
(removeDirectoryIfExists):
(copyBuildFiles):
(archiveBuiltProduct):

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (114724 => 114725)


--- trunk/Tools/BuildSlaveSupport/built-product-archive	2012-04-20 07:40:12 UTC (rev 114724)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2012-04-20 07:42:27 UTC (rev 114725)
@@ -73,9 +73,8 @@
         shutil.rmtree(thinDirectory)
 
 
-def copyBuildFiles(source, destination):
-    shutil.copytree(source, destination,
-        ignore=shutil.ignore_patterns('.svn', '*.a', '*.d', '*.dSYM', '*.o', '*.ilk', '*.lib', '*.idb', 'BuildLog.htm', '*.obj', '*.pdb'))
+def copyBuildFiles(source, destination, patterns):
+    shutil.copytree(source, destination, ignore=shutil.ignore_patterns(*patterns))
 
 
 def createZipManually(directoryToZip, archiveFile):
@@ -130,7 +129,7 @@
         thinBinDirectory = os.path.join(thinDirectory, "bin")
 
         removeDirectoryIfExists(thinDirectory)
-        copyBuildFiles(binDirectory, thinBinDirectory)
+        copyBuildFiles(binDirectory, thinBinDirectory, ['*.ilk'])
         if createZip(thinDirectory, configuration):
             return 1
 
@@ -166,7 +165,8 @@
         thinDirectory = os.path.join(configurationBuildDirectory, "thin")
 
         removeDirectoryIfExists(thinDirectory)
-        copyBuildFiles(configurationBuildDirectory, thinDirectory)
+        copyBuildFiles(configurationBuildDirectory, thinDirectory,
+            ['.svn', '*.a', '*.d', '*.dSYM', '*.o', '*.ilk', '*.lib', '*.idb', 'BuildLog.htm', '*.obj', '*.pdb'])
         if createZip(thinDirectory, configuration):
             return 1
 

Modified: trunk/Tools/ChangeLog (114724 => 114725)


--- trunk/Tools/ChangeLog	2012-04-20 07:40:12 UTC (rev 114724)
+++ trunk/Tools/ChangeLog	2012-04-20 07:42:27 UTC (rev 114725)
@@ -1,3 +1,17 @@
+2012-04-20  Ryosuke Niwa  <rn...@webkit.org>
+
+        REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
+        https://bugs.webkit.org/show_bug.cgi?id=84424
+
+        Reviewed by Mark Rowe.
+
+        Let Windows and Chromium have their own list of files to copy.
+
+        * BuildSlaveSupport/built-product-archive:
+        (removeDirectoryIfExists):
+        (copyBuildFiles):
+        (archiveBuiltProduct):
+
 2012-04-20  Kamil Blank  <k.bl...@samsung.com>
 
         [EFL] Add setting API for author and user styles.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to