Title: [114868] trunk/Tools
Revision
114868
Author
zandober...@gmail.com
Date
2012-04-22 22:22:58 -0700 (Sun, 22 Apr 2012)

Log Message

[TestResultsServer] Impossible to inspect builds on non-Chromium builders
https://bugs.webkit.org/show_bug.cgi?id=84544

Reviewed by Ryosuke Niwa.

Use the groupEnum parameter that is passed through to the onBuilderListLoad
function rather than an undefined attribute of the BuilderGroup object. This
makes it again possible to inspect builds on non-Chromium builders in the
test results server by not trying to always add Chromium revision links.

* TestResultServer/static-dashboards/builders.js:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (114867 => 114868)


--- trunk/Tools/ChangeLog	2012-04-23 05:19:46 UTC (rev 114867)
+++ trunk/Tools/ChangeLog	2012-04-23 05:22:58 UTC (rev 114868)
@@ -1,3 +1,17 @@
+2012-04-22  Zan Dobersek  <zandober...@gmail.com>
+
+        [TestResultsServer] Impossible to inspect builds on non-Chromium builders
+        https://bugs.webkit.org/show_bug.cgi?id=84544
+
+        Reviewed by Ryosuke Niwa.
+
+        Use the groupEnum parameter that is passed through to the onBuilderListLoad
+        function rather than an undefined attribute of the BuilderGroup object. This
+        makes it again possible to inspect builds on non-Chromium builders in the
+        test results server by not trying to always add Chromium revision links.
+
+        * TestResultServer/static-dashboards/builders.js:
+
 2012-04-20  Martin Robinson  <mrobin...@igalia.com>
 
         [GTK] Revert changes that disabled Cairo fonts metrics hinting

Modified: trunk/Tools/TestResultServer/static-dashboards/builders.js (114867 => 114868)


--- trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-04-23 05:19:46 UTC (rev 114867)
+++ trunk/Tools/TestResultServer/static-dashboards/builders.js	2012-04-23 05:22:58 UTC (rev 114868)
@@ -179,7 +179,7 @@
 {
     var builders = generateBuildersFromBuilderList(Object.keys(json), builderFilter);
     associateBuildersWithMaster(builders, master);
-    builderGroups[groupName] = new BuilderGroup(BuilderGroup.groupEnum, builders);
+    builderGroups[groupName] = new BuilderGroup(groupEnum, builders);
     g_handleBuildersListLoaded();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to