Title: [115174] trunk/Source/WebCore
- Revision
- 115174
- Author
- commit-qu...@webkit.org
- Date
- 2012-04-25 00:55:46 -0700 (Wed, 25 Apr 2012)
Log Message
No audio from MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=84669
MediaElementAudioSourceNode needs custom propagatesSilence() to
return false to indicate the node never propagates silence.
Patch by Raymond Toy <r...@google.com> on 2012-04-25
Reviewed by Chris Rogers.
* Modules/webaudio/MediaElementAudioSourceNode.h:
(MediaElementAudioSourceNode): Add propagatesSilence().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (115173 => 115174)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 07:39:19 UTC (rev 115173)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 07:55:46 UTC (rev 115174)
@@ -1,3 +1,16 @@
+2012-04-25 Raymond Toy <r...@google.com>
+
+ No audio from MediaElementAudioSourceNode
+ https://bugs.webkit.org/show_bug.cgi?id=84669
+
+ MediaElementAudioSourceNode needs custom propagatesSilence() to
+ return false to indicate the node never propagates silence.
+
+ Reviewed by Chris Rogers.
+
+ * Modules/webaudio/MediaElementAudioSourceNode.h:
+ (MediaElementAudioSourceNode): Add propagatesSilence().
+
2012-04-25 Xianzhu Wang <wangxian...@chromium.org>
Web Inspector: Incorrect highlight position of inspected element in a scrolled page
Modified: trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h (115173 => 115174)
--- trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h 2012-04-25 07:39:19 UTC (rev 115173)
+++ trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h 2012-04-25 07:55:46 UTC (rev 115174)
@@ -60,6 +60,9 @@
private:
MediaElementAudioSourceNode(AudioContext*, HTMLMediaElement*);
+ // As an audio source, we will never propagate silence.
+ virtual bool propagatesSilence() const OVERRIDE { return false; }
+
RefPtr<HTMLMediaElement> m_mediaElement;
Mutex m_processLock;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
