Diff
Modified: trunk/Source/WebCore/ChangeLog (115232 => 115233)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 18:38:48 UTC (rev 115233)
@@ -1,5 +1,30 @@
2012-04-25 Kentaro Hara <hara...@chromium.org>
+ [V8] Pass Isolate to SerializedScriptValue::create() in custom bindings
+ https://bugs.webkit.org/show_bug.cgi?id=84757
+
+ Reviewed by Nate Chapin.
+
+ The objective is to pass Isolate around in V8 bindings.
+ This patch passes Isolate to SerializedScriptValue::create()
+ in custom bindings.
+
+ No tests. No change in behavior.
+
+ * bindings/v8/custom/V8DOMWindowCustom.cpp:
+ (WebCore::handlePostMessageCallback):
+ * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
+ (WebCore::handlePostMessageCallback):
+ * bindings/v8/custom/V8HistoryCustom.cpp:
+ (WebCore::V8History::pushStateCallback):
+ (WebCore::V8History::replaceStateCallback):
+ * bindings/v8/custom/V8MessagePortCustom.cpp:
+ (WebCore::handlePostMessageCallback):
+ * bindings/v8/custom/V8WorkerCustom.cpp:
+ (WebCore::handlePostMessageCallback):
+
+2012-04-25 Kentaro Hara <hara...@chromium.org>
+
[V8] Pass Isolate to SerializedScriptValue::create() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84753
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -336,7 +336,8 @@
SerializedScriptValue::create(args[0],
&portArray,
extendedTransfer ? &arrayBufferArray : 0,
- didThrow);
+ didThrow,
+ args.GetIsolate());
if (didThrow)
return v8::Undefined();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -57,7 +57,8 @@
SerializedScriptValue::create(args[0],
&ports,
extendedTransfer ? &arrayBuffers : 0,
- didThrow);
+ didThrow,
+ args.GetIsolate());
if (didThrow)
return v8::Undefined();
ExceptionCode ec = 0;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -62,7 +62,7 @@
v8::Handle<v8::Value> V8History::pushStateCallback(const v8::Arguments& args)
{
bool didThrow = false;
- RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(args[0], 0, 0, didThrow);
+ RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(args[0], 0, 0, didThrow, args.GetIsolate());
if (didThrow)
return v8::Undefined();
@@ -87,7 +87,7 @@
v8::Handle<v8::Value> V8History::replaceStateCallback(const v8::Arguments& args)
{
bool didThrow = false;
- RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(args[0], 0, 0, didThrow);
+ RefPtr<SerializedScriptValue> historyState = SerializedScriptValue::create(args[0], 0, 0, didThrow, args.GetIsolate());
if (didThrow)
return v8::Undefined();
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -56,7 +56,8 @@
SerializedScriptValue::create(args[0],
&portArray,
extendedTransfer ? &arrayBufferArray : 0,
- didThrow);
+ didThrow,
+ args.GetIsolate());
if (didThrow)
return v8::Undefined();
ExceptionCode ec = 0;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp (115232 => 115233)
--- trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp 2012-04-25 18:21:16 UTC (rev 115232)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WorkerCustom.cpp 2012-04-25 18:38:48 UTC (rev 115233)
@@ -62,7 +62,8 @@
SerializedScriptValue::create(args[0],
&ports,
extendedTransfer ? &arrayBuffers : 0,
- didThrow);
+ didThrow,
+ args.GetIsolate());
if (didThrow)
return v8::Undefined();
ExceptionCode ec = 0;
