Title: [115273] trunk/LayoutTests
- Revision
- 115273
- Author
- dglaz...@chromium.org
- Date
- 2012-04-25 18:16:38 -0700 (Wed, 25 Apr 2012)
Log Message
Remove unnecessary timeouts (and closures) from content-element-in-* tests.
https://bugs.webkit.org/show_bug.cgi?id=84896
These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.
Reviewed by Ojan Vafai.
* fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
* fast/dom/shadow/content-element-in-meter-element.html: Ditto.
* fast/dom/shadow/content-element-in-progress-element.html: Ditto.
* fast/dom/shadow/content-element-in-select-element.html: Ditto.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (115272 => 115273)
--- trunk/LayoutTests/ChangeLog 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/ChangeLog 2012-04-26 01:16:38 UTC (rev 115273)
@@ -1,3 +1,17 @@
+2012-04-25 Dimitri Glazkov <dglaz...@chromium.org>
+
+ Remove unnecessary timeouts (and closures) from content-element-in-* tests.
+ https://bugs.webkit.org/show_bug.cgi?id=84896
+
+ These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.
+
+ Reviewed by Ojan Vafai.
+
+ * fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
+ * fast/dom/shadow/content-element-in-meter-element.html: Ditto.
+ * fast/dom/shadow/content-element-in-progress-element.html: Ditto.
+ * fast/dom/shadow/content-element-in-select-element.html: Ditto.
+
2012-04-25 Alexandru Chiculita <ach...@adobe.com>
[Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-in-media-element.html (115272 => 115273)
--- trunk/LayoutTests/fast/dom/shadow/content-element-in-media-element.html 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-in-media-element.html 2012-04-26 01:16:38 UTC (rev 115273)
@@ -29,17 +29,12 @@
var sr = new WebKitShadowRoot(div);
- var f = (function(sr, callIfDone) {
- return function() {
- var video = document.createElement('video');
- var content = document.createElement('content');
- video.appendChild(content);
- sr.appendChild(video);
- callIfDone();
- };
- })(sr, callIfDone);
-
- setTimeout(f, 0);
+ var video = document.createElement('video');
+ var content = document.createElement('content');
+ video.appendChild(content);
+ sr.appendChild(video);
+ document.body.offsetWidth; // force style recalc.
+ callIfDone();
});
</script>
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-in-meter-element.html (115272 => 115273)
--- trunk/LayoutTests/fast/dom/shadow/content-element-in-meter-element.html 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-in-meter-element.html 2012-04-26 01:16:38 UTC (rev 115273)
@@ -29,17 +29,12 @@
var sr = new WebKitShadowRoot(div);
- var f = (function(sr, callIfDone) {
- return function() {
- var meter = document.createElement('meter');
- var content = document.createElement('content');
- meter.appendChild(content);
- sr.appendChild(meter);
- callIfDone();
- };
- })(sr, callIfDone);
-
- setTimeout(f, 0);
+ var meter = document.createElement('meter');
+ var content = document.createElement('content');
+ meter.appendChild(content);
+ sr.appendChild(meter);
+ document.body.offsetWidth; // force style recalc.
+ callIfDone();
});
</script>
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-in-progress-element.html (115272 => 115273)
--- trunk/LayoutTests/fast/dom/shadow/content-element-in-progress-element.html 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-in-progress-element.html 2012-04-26 01:16:38 UTC (rev 115273)
@@ -29,17 +29,12 @@
var sr = new WebKitShadowRoot(div);
- var f = (function(sr, callIfDone) {
- return function() {
- var progress = document.createElement('progress');
- var content = document.createElement('content');
- progress.appendChild(content);
- sr.appendChild(progress);
- callIfDone();
- };
- })(sr, callIfDone);
-
- setTimeout(f, 0);
+ var progress = document.createElement('progress');
+ var content = document.createElement('content');
+ progress.appendChild(content);
+ sr.appendChild(progress);
+ document.body.offsetWidth; // force style recalc.
+ callIfDone();
});
</script>
Modified: trunk/LayoutTests/fast/dom/shadow/content-element-in-select-element.html (115272 => 115273)
--- trunk/LayoutTests/fast/dom/shadow/content-element-in-select-element.html 2012-04-26 01:13:06 UTC (rev 115272)
+++ trunk/LayoutTests/fast/dom/shadow/content-element-in-select-element.html 2012-04-26 01:16:38 UTC (rev 115273)
@@ -29,17 +29,12 @@
var sr = new WebKitShadowRoot(div);
- var f = (function(sr, callIfDone) {
- return function() {
- var select = document.createElement('select');
- var content = document.createElement('content');
- select.appendChild(content);
- sr.appendChild(select);
- callIfDone();
- };
- })(sr, callIfDone);
-
- setTimeout(f, 0);
+ var select = document.createElement('select');
+ var content = document.createElement('content');
+ select.appendChild(content);
+ sr.appendChild(select);
+ document.body.offsetWidth; // force style recalc.
+ callIfDone();
});
</script>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
