Title: [117410] trunk/Tools
Revision
117410
Author
hara...@chromium.org
Date
2012-05-17 00:46:04 -0700 (Thu, 17 May 2012)

Log Message

[Performance test] Always fill results['description'] in perftest.py
https://bugs.webkit.org/show_bug.cgi?id=86696

Reviewed by Ryosuke Niwa.

This is a follow-up patch for r117397 to fix perf bot failures.
This patch fills results['description'] always.

* Scripts/webkitpy/performance_tests/perftest.py:
(PageLoadingPerfTest.run):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (117409 => 117410)


--- trunk/Tools/ChangeLog	2012-05-17 07:30:03 UTC (rev 117409)
+++ trunk/Tools/ChangeLog	2012-05-17 07:46:04 UTC (rev 117410)
@@ -1,3 +1,16 @@
+2012-05-17  Kentaro Hara  <hara...@chromium.org>
+
+        [Performance test] Always fill results['description'] in perftest.py
+        https://bugs.webkit.org/show_bug.cgi?id=86696
+
+        Reviewed by Ryosuke Niwa.
+
+        This is a follow-up patch for r117397 to fix perf bot failures.
+        This patch fills results['description'] always.
+
+        * Scripts/webkitpy/performance_tests/perftest.py:
+        (PageLoadingPerfTest.run):
+
 2012-05-16  Kentaro Hara  <hara...@chromium.org>
 
         [Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond

Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (117409 => 117410)


--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2012-05-17 07:30:03 UTC (rev 117409)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2012-05-17 07:46:04 UTC (rev 117410)
@@ -154,6 +154,7 @@
             elif not len(line) == 0:
                 test_failed = True
                 _log.error(line)
+        results['description'] = ''
         return results if results and not test_failed else None
 
 
@@ -190,6 +191,7 @@
             'max': max(test_times),
             'median': test_times[middle] if len(test_times) % 2 else (test_times[middle - 1] + test_times[middle]) / 2,
             'stdev': math.sqrt(squareSum),
+            'description': '',
             'unit': 'ms'}
         self.output_statistics(self.test_name(), results)
         return {self.test_name(): results}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to