Title: [117411] trunk/LayoutTests
- Revision
- 117411
- Author
- commit-qu...@webkit.org
- Date
- 2012-05-17 01:06:38 -0700 (Thu, 17 May 2012)
Log Message
[Worker] Web Worker lacks test to check the name attribute of SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=86714
Patch by Li Yin <li....@intel.com> on 2012-05-17
Reviewed by Kentaro Hara.
Spec: http://www.w3.org/TR/2012/CR-workers-20120501/#sharedworkerglobalscope
The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created.
So we should have a test to check it, there is a related test "fast/worker/shared-worker-name.html" already,
but it doesn't cover this.
* fast/workers/resources/shared-worker-common.js:
(handleMessage):
* fast/workers/resources/shared-worker-name.js:
(test11.worker.port.onmessage):
(test11):
* fast/workers/shared-worker-name-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (117410 => 117411)
--- trunk/LayoutTests/ChangeLog 2012-05-17 07:46:04 UTC (rev 117410)
+++ trunk/LayoutTests/ChangeLog 2012-05-17 08:06:38 UTC (rev 117411)
@@ -1,3 +1,22 @@
+2012-05-17 Li Yin <li....@intel.com>
+
+ [Worker] Web Worker lacks test to check the name attribute of SharedWorker
+ https://bugs.webkit.org/show_bug.cgi?id=86714
+
+ Reviewed by Kentaro Hara.
+
+ Spec: http://www.w3.org/TR/2012/CR-workers-20120501/#sharedworkerglobalscope
+ The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created.
+ So we should have a test to check it, there is a related test "fast/worker/shared-worker-name.html" already,
+ but it doesn't cover this.
+
+ * fast/workers/resources/shared-worker-common.js:
+ (handleMessage):
+ * fast/workers/resources/shared-worker-name.js:
+ (test11.worker.port.onmessage):
+ (test11):
+ * fast/workers/shared-worker-name-expected.txt:
+
2012-05-17 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
[EFL] fast/frames/frame-crash-with-page-cache.html is crashing
Modified: trunk/LayoutTests/fast/workers/resources/shared-worker-common.js (117410 => 117411)
--- trunk/LayoutTests/fast/workers/resources/shared-worker-common.js 2012-05-17 07:46:04 UTC (rev 117410)
+++ trunk/LayoutTests/fast/workers/resources/shared-worker-common.js 2012-05-17 08:06:38 UTC (rev 117411)
@@ -24,6 +24,8 @@
port.postMessage("DONE");
else if (event.data == "throw")
generateError();
+ else if (event.data == "testingNameAttribute")
+ port.postMessage(self.name);
else if (/eval.+/.test(event.data)) {
try {
port.postMessage(event.data.substr(5) + ": " + eval(event.data.substr(5)));
Modified: trunk/LayoutTests/fast/workers/resources/shared-worker-name.js (117410 => 117411)
--- trunk/LayoutTests/fast/workers/resources/shared-worker-name.js 2012-05-17 07:46:04 UTC (rev 117410)
+++ trunk/LayoutTests/fast/workers/resources/shared-worker-name.js 2012-05-17 08:06:38 UTC (rev 117411)
@@ -147,6 +147,17 @@
}
}
+function test11()
+{
+ // Creating a worker with a specific name, the name attribute should be set to worker correctly.
+ var worker = new SharedWorker('resources/shared-worker-common.js', "testingNameAttribute");
+ worker.port.postMessage("testingNameAttribute");
+ worker.port._onmessage_ = function(event) {
+ shouldBeEqual("the name attribute of worker can be set correctly", event.data, "testingNameAttribute");
+ nextTest();
+ }
+}
+
function shouldBeEqual(description, a, b)
{
if (a == b)
Modified: trunk/LayoutTests/fast/workers/shared-worker-name-expected.txt (117410 => 117411)
--- trunk/LayoutTests/fast/workers/shared-worker-name-expected.txt 2012-05-17 07:46:04 UTC (rev 117410)
+++ trunk/LayoutTests/fast/workers/shared-worker-name-expected.txt 2012-05-17 08:06:38 UTC (rev 117411)
@@ -16,6 +16,7 @@
PASS created SharedWorker with name 'undefined'
PASS setting self.foo
PASS creating worker with an undefined name
+PASS the name attribute of worker can be set correctly
TEST COMPLETE
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
