Title: [117447] trunk/Source/WebCore
- Revision
- 117447
- Author
- ca...@chromium.org
- Date
- 2012-05-17 07:21:41 -0700 (Thu, 17 May 2012)
Log Message
Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
https://bugs.webkit.org/show_bug.cgi?id=86659
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionView):
(WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.
* inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.
(iframe.extension):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117446 => 117447)
--- trunk/Source/WebCore/ChangeLog 2012-05-17 14:08:58 UTC (rev 117446)
+++ trunk/Source/WebCore/ChangeLog 2012-05-17 14:21:41 UTC (rev 117447)
@@ -1,3 +1,16 @@
+2012-05-16 Andrey Kosyakov <ca...@chromium.org>
+
+ Web Inspector: [Extensions API] pages shown in sidebar are limited in height to 150px
+ https://bugs.webkit.org/show_bug.cgi?id=86659
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/front-end/ExtensionPanel.js:
+ (WebInspector.ExtensionView):
+ (WebInspector.ExtensionSidebarPane.prototype.setPage): set default iframe height to 150px, unless already set by user.
+ * inspector/front-end/inspector.css: set extension view and iframe elements to "fill", iframe to 100% height.
+ (iframe.extension):
+
2012-05-17 Sam D <dsam2...@gmail.com>
Web Inspector: Hover on a breakpoint in breakpoint-pane does not get differentiated.
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js (117446 => 117447)
--- trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2012-05-17 14:08:58 UTC (rev 117446)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2012-05-17 14:21:41 UTC (rev 117447)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright (C) 2012 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -39,6 +39,7 @@
WebInspector.ExtensionView = function(id, parent, src, className)
{
WebInspector.View.call(this);
+ this.element.className = "fill";
this._id = id;
this._iframe = document.createElement("iframe");
@@ -263,7 +264,9 @@
if (this._extensionView)
this._extensionView.detach(true);
- this._extensionView = new WebInspector.ExtensionView(this._id, this.bodyElement, url, "extension");
+ this._extensionView = new WebInspector.ExtensionView(this._id, this.bodyElement, url, "extension fill");
+ if (!this.bodyElement.style.height)
+ this.setHeight("150px");
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (117446 => 117447)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-05-17 14:08:58 UTC (rev 117446)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-05-17 14:21:41 UTC (rev 117447)
@@ -993,6 +993,7 @@
iframe.extension {
width: 100%;
+ height: 100%;
}
iframe.panel.extension {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
